From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by sourceware.org (Postfix) with ESMTPS id 714C9384803F for ; Wed, 17 Mar 2021 19:35:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 714C9384803F Received: by mail-qt1-x82c.google.com with SMTP id s2so2312807qtx.10 for ; Wed, 17 Mar 2021 12:35:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TH9wjL72RIiyD62j3T1v6EeMgTakFNyaS4EJt5RXSCY=; b=YlhVk/OPE8a/fBL9ivFcWKGINfpQfEhTHvpOvzbvU4qRzqOTKn+wdroWuh2HtWNMDo oi+3WHpz009EaqVuh+OIUhFd1ftTHnjbzy5BMAEPuYWuPn11hPGMygWfUvyufQvRkihw RtW99Ge1IyfrVOGbNWYxTHiRMPr7w6x4xQ70cRHTWRrIGTpF18VffITbe1VHnTa+VzJ7 KWek4WihY0h+mQvNoxbhj3EIwjcKknfdYyY9M9J6lysfaJn+b975O5JWD0FFwCUeBiIp h7H2JVNvsvT0rtQsOwApuXIB9z8npnl3zNkrBjet7A6l0cgTq2SQhaAgZ0ReBkpojzfc EoPw== X-Gm-Message-State: AOAM533dbNSZ9/4xNCpsQgMNmsUHi5TfbqdugxfqcjPQWY5JTMwoC5ci BUw+ijPTtUbWk03KVxhbKeloNSZUAwVuMotn X-Google-Smtp-Source: ABdhPJwfvi4Yv7T6XCVr+mpo6YSyhnVGenNyPIf2vqgoI9lGmu4ZKqCZx/P873wt57/PzybQDz2+2g== X-Received: by 2002:ac8:5684:: with SMTP id h4mr604217qta.61.1616009720789; Wed, 17 Mar 2021 12:35:20 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id i78sm1287956qke.46.2021.03.17.12.35.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 12:35:20 -0700 (PDT) Subject: Re: [PATCH 15/30] nptl: Remove pread from libpthread To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210316200510.2135405-1-adhemerval.zanella@linaro.org> <20210316200510.2135405-16-adhemerval.zanella@linaro.org> <87o8fhy3r8.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Wed, 17 Mar 2021 16:35:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87o8fhy3r8.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 19:35:23 -0000 On 17/03/2021 16:33, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/sysdeps/unix/sysv/linux/alpha/pread64.c b/sysdeps/unix/sysv/linux/alpha/pread64.c >> new file mode 100644 >> index 0000000000..a40e4447e1 >> --- /dev/null >> +++ b/sysdeps/unix/sysv/linux/alpha/pread64.c >> @@ -0,0 +1,33 @@ >> +/* Read from to a file descriptor at a given offset. Linux/alpha version. >> + Copyright (C) 2021 Free Software Foundation, Inc. >> + This file is part of the GNU C Library. >> + >> + The GNU C Library is free software; you can redistribute it and/or >> + modify it under the terms of the GNU Lesser General Public >> + License as published by the Free Software Foundation; either >> + version 2.1 of the License, or (at your option) any later version. >> + >> + The GNU C Library is distributed in the hope that it will be useful, >> + but WITHOUT ANY WARRANTY; without even the implied warranty of >> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU >> + Lesser General Public License for more details. >> + >> + You should have received a copy of the GNU Lesser General Public >> + License along with the GNU C Library; if not, see >> + . */ >> + >> +#define PREAD64_REQUIRE_PREAD_COMPAT >> +#include >> + >> +/* libpthread compat symbols. */ >> +# if SHLIB_COMPAT (libc, GLIBC_2_1, GLIBC_2_2) >> +strong_alias (__libc_pread64, __compat_pread) >> +compat_symbol (libc, __compat_pread, pread, GLIBC_2_1); >> + >> +strong_alias (__libc_pread64, __default_pread) >> +versioned_symbol (libc, __default_pread, pread, GLIBC_2_2); >> + >> +/* It is a libc_hidden_def (__pread), but with a redirection due the symbol >> + versioning. */ >> +__hidden_ver1 (__compat_pread, __GI___pread, __compat_pread); >> +#endif > > I believe this is libc_hidden_ver. It took me a while to find it (see > the original dance around ___libc_once). > > This applies else where in this patch and also the pwrite patch. Yes and I simplified the versioned and compat definitions a bit with newer macros.