From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id BF6C33858D34 for ; Thu, 2 Jul 2020 20:05:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BF6C33858D34 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-c-payatANIu0FbNqazw3fQ-1; Thu, 02 Jul 2020 16:05:43 -0400 X-MC-Unique: c-payatANIu0FbNqazw3fQ-1 Received: by mail-qk1-f200.google.com with SMTP id s5so1389678qkj.1 for ; Thu, 02 Jul 2020 13:05:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=40k1hYQIPYO30z1M0K4Mp80w6X6w70ihyu4VZDk8Nj0=; b=n9WZLlcK/PfxGiGcj3UcDSq4RxdyRiQ2DlRFLrz/8ssclIyzvAm/0A+sNgF+Umhvri AfoWJ3fiq8xle4wMzUvSSOOJrLsKzl1vEpsE+AxF1czaI+5KKW+yEZXCOimikCAp+wPD bPt85O3VOZuvTl+aWOEepVVtcQTQrvDy6zbdPc2xIOhNlN3/z+6sIWEMdaurVc1gg8CX lsTW5S/m/RylxCrMbYMjIVRgZFys64gkUiJhU8Xn24bFIVN7jbk2o8snYfnQ1eCYADKD YM0TVVzwhnsqEV4YpJS4yIuPSQdRApuycqfrQwcIvTamJuE8miVr+uVYdpceUpu9K60/ lTCg== X-Gm-Message-State: AOAM532sAaUWEymwSAFQrVHaY2o1bCrtO6gA1oyoulTsUsV1k0LSwaRG ZHH+WetfzoKtKr/w3sC5tPAHa5oDynCNCOGiT8IqG5ixN0hS8BzI4oKuyAO/P7rsmFi9pfrRznn 5bFQxfJWr5WZEMdxev23j X-Received: by 2002:a0c:b520:: with SMTP id d32mr31725793qve.6.1593720342345; Thu, 02 Jul 2020 13:05:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSA9fgxq9wcJjwklh2dm5+pajzG/BVyQzJqVAFzN5oNj22AD5qClZr7TbyJfR4bPr6ayexqg== X-Received: by 2002:a0c:b520:: with SMTP id d32mr31725779qve.6.1593720342154; Thu, 02 Jul 2020 13:05:42 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id z4sm9082741qkb.66.2020.07.02.13.05.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2020 13:05:41 -0700 (PDT) Subject: Re: [PATCH v5 11/13] string: Add strerror_l on test-strerror-errno To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20200619134352.297146-1-adhemerval.zanella@linaro.org> <20200619134352.297146-11-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Thu, 2 Jul 2020 16:05:40 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200619134352.297146-11-adhemerval.zanella@linaro.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jul 2020 20:05:45 -0000 On 6/19/20 9:43 AM, Adhemerval Zanella wrote: > Checked on x86-64-linux-gnu, i686-linux-gnu, powerpc64le-linux-gnu, > and s390x-linux-gnu. OK for master. No regression on x86_64 and i686. Tested-by: Carlos O'Donell Reviewed-by: Carlos O'Donell > --- > string/test-strerror-errno.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/string/test-strerror-errno.c b/string/test-strerror-errno.c > index 0c52561015..f3b1a98d22 100644 > --- a/string/test-strerror-errno.c > +++ b/string/test-strerror-errno.c > @@ -55,6 +55,11 @@ do_test (void) > (void) msg; > TEST_COMPARE (errno, 0); > > + locale_t l = xnewlocale (LC_ALL_MASK, "C", NULL); > + msg = strerror_l (-3, l); > + (void) msg; > + TEST_COMPARE (errno, 0); OK, make new locale, then translate with strerror_l for an invalid errnum and make sure errno is unchanged. > + > return 0; > } > > -- Cheers, Carlos.