From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 721513857838 for ; Wed, 23 Nov 2022 02:14:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 721513857838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.143]) by gateway (Coremail) with SMTP id _____8CxbesWgn1jdiYAAA--.431S3; Wed, 23 Nov 2022 10:14:46 +0800 (CST) Received: from [10.20.4.143] (unknown [10.20.4.143]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxDuIRgn1jp3YYAA--.63869S3; Wed, 23 Nov 2022 10:14:43 +0800 (CST) Subject: Re: [PATCH 0/9] LoongArch: Use builtins with GCC >= 13 To: Xi Ruoyao , adhemerval.zanella@linaro.org, libc-alpha@sourceware.org, caiyinyu@loongson.cn Cc: xuchenghua@loongson.cn, chenglulu@loongson.cn References: <20221118112912.2501774-1-tangxiaolin@loongson.cn> <16d2603ead227edc39cd46bbd25c0fb4611c0392.camel@xry111.site> From: tangxiaolin Message-ID: Date: Wed, 23 Nov 2022 10:14:41 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <16d2603ead227edc39cd46bbd25c0fb4611c0392.camel@xry111.site> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxDuIRgn1jp3YYAA--.63869S3 X-CM-SenderInfo: pwdqw5xldrzx3q6o00pqjv00gofq/ X-Coremail-Antispam: 1Uk129KBjvJXoWxZr4DArWrKrWkKw45GFW7Jwb_yoWrCFWDpa yxur15JryUC3WxJrsFv3WaqFyrAF4xWw1UAr13ta4UXr18Cr1YqrWSvr1qgFy7Gw48Gw1q 9r1UGa4UuFn8JFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bxAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jrv_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4 x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJwAS 0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc02F40EFcxC0V AKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1l Ox8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42 xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWU GwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI4 8JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4U MIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I 8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07jUsqXUUUUU= X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: OK, thank you for pointing this out.  Please delete them, and I will resend this series. 在 2022/11/23 上午12:20, Xi Ruoyao 写道: > Hi Xiaolin, > > I guess you need to resent the series because {1,8,9}/9 lacks the proper > In-Reply-To: header, causing them missing from the patchwork interface > (https://patchwork.sourceware.org/project/glibc/list/?series=14494). > The reviewers will use the patchwork interface to track the patches. > > On Fri, 2022-11-18 at 19:29 +0800, Xiaolin Tang wrote: >> Patch 0001-0007: >> GCC 13, LoongArch support builtins for {,l,ll}rint, logb, >> use these built-ins instead of generic function implementation. >> >> Patch 0008: >> GCC 13, LoongArch support ___builtin_scalbn{,f} with -fno-math-errno, >> but only "libm" can use -fno-math-errno in GLIBC, and scalbn is in >> libc >> instead of libm because __printf_fp calls it. So inline assembler of >> the scalbn functions is a better choice for LoongArch. >> >> Patch 0009: Add LoongArch support for scalb[f]. >> >> Discuss with Xi Ruoyao >> Link: >> https://sourceware.org/pipermail/libc-alpha/2022-November/143425.html >> >> Xi Ruoyao (1): >>   LoongArch: Use __builtin_rint{,f} with GCC >= 13 >> >> Xiaolin Tang (8): >>   Use GCC builtins for lrint functions if desired. >>   LoongArch: Use __builtin_lrint{,f} with GCC >= 13 >>   Use GCC builtins for llrint functions if desired. >>   LoongArch: Use __builtin_llrint{,f} with GCC >= 13 >>   Use GCC builtins for logb functions if desired. >>   LoongArch: Use __builtin_logb{,f} with GCC >= 13 >>   LoongArch: Add support for scalbn[f] >>   LoongArch: Add support for scalb[f] >> >>  sysdeps/generic/math-use-builtins-llrint.h    |  4 ++ >>  sysdeps/generic/math-use-builtins-logb.h      |  4 ++ >>  sysdeps/generic/math-use-builtins-lrint.h     |  4 ++ >>  sysdeps/generic/math-use-builtins.h           |  3 + >>  sysdeps/ieee754/dbl-64/s_llrint.c             | 18 ++++-- >>  sysdeps/ieee754/dbl-64/s_logb.c               |  5 ++ >>  sysdeps/ieee754/dbl-64/s_lrint.c              | 18 ++++-- >>  sysdeps/ieee754/float128/float128_private.h   |  6 ++ >>  sysdeps/ieee754/flt-32/s_llrintf.c            | 18 ++++-- >>  sysdeps/ieee754/flt-32/s_logbf.c              |  5 ++ >>  sysdeps/ieee754/flt-32/s_lrintf.c             | 18 ++++-- >>  sysdeps/ieee754/ldbl-128/s_llrintl.c          | 17 ++++-- >>  sysdeps/ieee754/ldbl-128/s_logbl.c            |  6 ++ >>  sysdeps/ieee754/ldbl-128/s_lrintl.c           | 17 ++++-- >>  sysdeps/loongarch/fpu/e_scalb.c               | 60 >> +++++++++++++++++++ >>  sysdeps/loongarch/fpu/e_scalbf.c              | 60 >> +++++++++++++++++++ >>  .../loongarch/fpu/math-use-builtins-llrint.h  | 10 ++++ >>  .../loongarch/fpu/math-use-builtins-logb.h    | 10 ++++ >>  .../loongarch/fpu/math-use-builtins-lrint.h   | 10 ++++ >>  .../loongarch/fpu/math-use-builtins-rint.h    |  9 +++ >>  sysdeps/loongarch/fpu/s_scalbn.c              | 29 +++++++++ >>  sysdeps/loongarch/fpu/s_scalbnf.c             | 29 +++++++++ >>  22 files changed, 326 insertions(+), 34 deletions(-) >>  create mode 100644 sysdeps/generic/math-use-builtins-llrint.h >>  create mode 100644 sysdeps/generic/math-use-builtins-logb.h >>  create mode 100644 sysdeps/generic/math-use-builtins-lrint.h >>  create mode 100644 sysdeps/loongarch/fpu/e_scalb.c >>  create mode 100644 sysdeps/loongarch/fpu/e_scalbf.c >>  create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-llrint.h >>  create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-logb.h >>  create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-lrint.h >>  create mode 100644 sysdeps/loongarch/fpu/math-use-builtins-rint.h >>  create mode 100644 sysdeps/loongarch/fpu/s_scalbn.c >>  create mode 100644 sysdeps/loongarch/fpu/s_scalbnf.c >>