From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by sourceware.org (Postfix) with ESMTPS id 5B8EA385843D for ; Tue, 4 Jan 2022 14:09:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B8EA385843D Received: by mail-qt1-x835.google.com with SMTP id 8so34153304qtx.5 for ; Tue, 04 Jan 2022 06:09:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=pn3Jpy4x9Z02JzSikRdKlU3wwdVE6OAvtc9q70ASbrE=; b=WvwM3hAulnUJ5+G059pnZKYizi4f2HmrNxzkBws6SXwK3tO1/Ni3OJfVI22vd0AeLl fRN0eUQ6wAviUJ3c8ZsGqxmFa1hLZ1HZalbMbRFf7HETwNIDEXaHWKhk/1MRSYTTUZxW ep6+UKcN8iZTtDlPOy1cDyrtQOMeRJX+lC+TfCOAYy3UgEfaygNJJAYrUhC/NfZ8b17x gCYuqGDFFE4SVFU+Ip4ycIFSDyjIonSb9MSS6Jz5cfp6ZG62JvmK4gNAcVILJYeUlBhb VKXs1a4fxxV+zfwhQ+CrpetmcKmIzE2jxG0BgRWeT8zYJVxmbZqljC1Lf8r1Oe+zKA1y oh4w== X-Gm-Message-State: AOAM533KDh2Z0h64EVxrZSj+yGeGg7O50loU3YFJgo4incgNcZRxPhh0 JdD/HYbLqLr+khQJXI7MBR1bmg== X-Google-Smtp-Source: ABdhPJze9ACIk3tq+NUTJpFGTgO+nccJgXue0FZjGhq2RR9xbgEOxLOuVE086undSwAwX/EvCdxNgg== X-Received: by 2002:a05:622a:155:: with SMTP id v21mr43613745qtw.523.1641305365831; Tue, 04 Jan 2022 06:09:25 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a350:1960:9a87:fba4:a664? ([2804:431:c7ca:a350:1960:9a87:fba4:a664]) by smtp.gmail.com with ESMTPSA id s19sm32024758qtk.40.2022.01.04.06.09.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 06:09:25 -0800 (PST) Message-ID: Date: Tue, 4 Jan 2022 11:09:23 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v2 07/14] LoongArch: Atomic and Locking Routines Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org Cc: xuchenghua@loongson.cn, joseph_myers@mentor.com References: <20211231064455.1030051-1-caiyinyu@loongson.cn> <20211231064455.1030051-8-caiyinyu@loongson.cn> From: Adhemerval Zanella In-Reply-To: <20211231064455.1030051-8-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 14:09:28 -0000 On 31/12/2021 03:44, caiyinyu wrote: > This patch implements various atomic and locking routines on LoongArch. > --- > .../loongarch/nptl/bits/pthreadtypes-arch.h | 41 ++++ > sysdeps/loongarch/nptl/bits/semaphore.h | 32 +++ > sysdeps/loongarch/nptl/libc-lowlevellock.c | 8 + > .../sysv/linux/loongarch/atomic-machine.h | 196 ++++++++++++++++++ > 4 files changed, 277 insertions(+) > create mode 100644 sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h > create mode 100644 sysdeps/loongarch/nptl/bits/semaphore.h > create mode 100644 sysdeps/loongarch/nptl/libc-lowlevellock.c > create mode 100644 sysdeps/unix/sysv/linux/loongarch/atomic-machine.h > > diff --git a/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h b/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h > new file mode 100644 > index 0000000000..e57f122a98 > --- /dev/null > +++ b/sysdeps/loongarch/nptl/bits/pthreadtypes-arch.h > @@ -0,0 +1,41 @@ > +/* Machine-specific pthread type layouts. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _BITS_PTHREADTYPES_ARCH_H > +#define _BITS_PTHREADTYPES_ARCH_H 1 > + > +#include > + > +#ifdef __loongarch_lp64 > +#define __SIZEOF_PTHREAD_ATTR_T 56 > +#define __SIZEOF_PTHREAD_MUTEX_T 40 > +#define __SIZEOF_PTHREAD_MUTEXATTR_T 4 > +#define __SIZEOF_PTHREAD_COND_T 48 > +#define __SIZEOF_PTHREAD_CONDATTR_T 4 > +#define __SIZEOF_PTHREAD_RWLOCK_T 56 > +#define __SIZEOF_PTHREAD_RWLOCKATTR_T 8 > +#define __SIZEOF_PTHREAD_BARRIER_T 32 > +#define __SIZEOF_PTHREAD_BARRIERATTR_T 4 > +#else > +#error "32bit LoongArch systems are not supported" > +#endif > + > +#define __LOCK_ALIGNMENT > +#define __ONCE_ALIGNMENT > + > +#endif /* bits/pthreadtypes.h */ Why can't you use the generic definition? Also, I think all the __loongarch_lp64 tests to avoid 32-bit build should be moved to a configure test instead. > diff --git a/sysdeps/loongarch/nptl/bits/semaphore.h b/sysdeps/loongarch/nptl/bits/semaphore.h > new file mode 100644 > index 0000000000..510f3b0e9a > --- /dev/null > +++ b/sysdeps/loongarch/nptl/bits/semaphore.h > @@ -0,0 +1,32 @@ > +/* POSIX semaphore type layout > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _SEMAPHORE_H > +#error "Never use directly; include instead." > +#endif > + > +#define __SIZEOF_SEM_T (4 * __SIZEOF_POINTER__) > + > +/* Value returned if `sem_open' failed. */ > +#define SEM_FAILED ((sem_t *) 0) > + > +typedef union > +{ > + char __size[__SIZEOF_SEM_T]; > + long int __align; > +} sem_t; Why can't you use the generic linux header interface? > diff --git a/sysdeps/loongarch/nptl/libc-lowlevellock.c b/sysdeps/loongarch/nptl/libc-lowlevellock.c > new file mode 100644 > index 0000000000..f4b8b5c193 > --- /dev/null > +++ b/sysdeps/loongarch/nptl/libc-lowlevellock.c > @@ -0,0 +1,8 @@ > +/* This kludge works around a libpthread static linking problem: > + https://sourceware.org/bugzilla/show_bug.cgi?id=15648. */ > + > +#ifndef SHARED > +#define __lll_lock_wait_private weak_function __lll_lock_wait_private > +#endif > + > +#include Why this file is required? > diff --git a/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h b/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h > new file mode 100644 > index 0000000000..dbae608ee5 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/loongarch/atomic-machine.h > @@ -0,0 +1,196 @@ > +/* Atomic operations. > + Copyright (C) 2021 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _LINUX_LOONGARCH_BITS_ATOMIC_H > +#define _LINUX_LOONGARCH_BITS_ATOMIC_H 1 > + > +#include > + > +typedef int32_t atomic32_t; > +typedef uint32_t uatomic32_t; > + > +typedef int64_t atomic64_t; > +typedef uint64_t uatomic64_t; > + > +typedef intptr_t atomicptr_t; > +typedef uintptr_t uatomicptr_t; > +typedef intmax_t atomic_max_t; > +typedef uintmax_t uatomic_max_t; These definition are not required any longer. > + > +#define atomic_full_barrier() __sync_synchronize () > + > +#ifdef __LP64__ > +#define __HAVE_64B_ATOMICS 1 > +#endif I think there is no need to guard it for __LP64__.