From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106370 invoked by alias); 29 Jun 2018 16:01:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 106053 invoked by uid 89); 29 Jun 2018 16:00:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:sk:k10-v6m, HTo:D*ucla.edu, Hx-languages-length:1279 X-HELO: mail-qt0-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TZQdLdNE79yfD0YPYwjtM84t5GkpLMy/fWfT+k07HTU=; b=iAo+1Dh/G2rooBiggTjxwy6mZ2oUvfqfbGikEsPxEn+/ri3HrfgbfYXAnpDAUUSW/Q zV1KAW61fLZya3LnVYsvg/BSG06vQ1T4LZimDvgZ9YLrtgHTIoe941JCCWIN9IGGKz/s YbN3MZrsuGUJerEvFxYInp8GrIb2zjikXiOp4= Return-Path: Subject: Re: [PATCH] posix: Sync gnulib regex implementation To: Florian Weimer , Paul Eggert , libc-alpha@sourceware.org References: <1530204275-31537-1-git-send-email-adhemerval.zanella@linaro.org> <135856c7-fee5-a5de-4ccb-12bf0b8fe166@linaro.org> <17feeb08-1478-21ae-e581-6ffecfddab5c@cs.ucla.edu> <50b3b084-4049-0ed8-bdf5-3a75547c0894@redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: Date: Fri, 29 Jun 2018 16:01:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <50b3b084-4049-0ed8-bdf5-3a75547c0894@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00994.txt.bz2 On 29/06/2018 12:41, Florian Weimer wrote: > On 06/29/2018 05:26 PM, Paul Eggert wrote: >> As I recall the last time I suggested adding it, the only concern raised was over the licensing boilerplate at the start of the file. I have fixed that in Gnulib, so as far as I know the concerns have been addressed. We can make intprops.h's addition independent by separating its addition into a separate patch, as I proposed in my most-recent email. > > Most of intprops.h is untestable due to lack of relevant implementations existing out there on which the code could be tested, so I think it's not maintainable and does not match current glibc quality standards. > > Florian I tried to check the pos-processed implementation using intprops.h for the snippet: --- bool wrap_int (int a, int b, int *r) { return INT_ADD_WRAPV (a, b, r); } --- And its results are pretty much unreadable [1]. I think I tend to agree with Florian where a simple implementation should be better than import all intprops.h. Paul, could you check what I am missing on the overflow check so we can move forward? I really don't want to get this sync stalled because of intprops.h addition as a pre-requisite. [1] https://paste.ubuntu.com/p/QCr3QQ6X5w/