From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH v2 17/19] nptl: Use tidlock when accessing TID on pthread_sigqueue
Date: Thu, 26 Aug 2021 14:49:32 -0300 [thread overview]
Message-ID: <eb460539-abc0-f598-d775-e7ecf9b0b729@linaro.org> (raw)
In-Reply-To: <87eeag5ksb.fsf@oldenburg.str.redhat.com>
On 26/08/2021 11:43, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> + /* Block all signal, since the lock is recursive and used on pthread_cancel
>> + (which should be async-signal-safe). */
>> + sigset_t oldmask;
>> + __libc_signal_block_all (&oldmask);
>> + lll_lock (pd->tidlock, LLL_PRIVATE);
>> +
>> + int res;
>> + if (pd->tid == 0)
>> + {
>> + pid_t pid = getpid ();
>
> Huh, that can't be right, should be pd->tid != 0.
>
It is definitely not, I have fixed.
> Don't we have test coverage for this?
Nops, I will add one in the next version.
>
>> + else
>> + res = -ESRCH;
>
> We can return 0 in this case, I think.
No sure about this, we can return 0 but it means signal won't be potentially
delivered.
>
> It's possibly that the same issue regarding synchronous signal delivery
> for pthread_jill applies here.
>
> Thanks,
> Florian
>
next prev parent reply other threads:[~2021-08-26 17:49 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 19:50 [PATCH v2 00/19] Fix various NPTL synchronization issues Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 01/19] nptl: Fix tst-cancel7 and tst-cancelx7 race condition (BZ #14232) Adhemerval Zanella
2021-08-26 9:33 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 02/19] nptl: Set cancellation type and state on pthread_exit Adhemerval Zanella
2021-08-26 9:38 ` Florian Weimer
2021-08-26 9:42 ` Florian Weimer
2021-08-26 11:56 ` Adhemerval Zanella
2021-08-26 11:52 ` Adhemerval Zanella
2021-08-26 12:08 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 03/19] nptl: Handle robust PI mutexes for !__ASSUME_SET_ROBUST_LIST Adhemerval Zanella
2021-08-26 9:42 ` Florian Weimer
2021-08-26 12:14 ` Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 04/19] nptl: Do not use pthread set_tid_address as state synchronization (BZ #19951) Adhemerval Zanella
2021-08-26 10:41 ` Florian Weimer
2021-08-26 14:58 ` Adhemerval Zanella
2021-08-26 15:06 ` Florian Weimer
2021-08-26 16:16 ` Adhemerval Zanella
2021-08-30 10:42 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 05/19] nptl: Move setxid flag out of cancelhandling Adhemerval Zanella
2021-08-26 11:34 ` Florian Weimer
2021-08-26 15:11 ` Adhemerval Zanella
2021-08-26 15:21 ` Florian Weimer
2021-08-26 16:39 ` Adhemerval Zanella
2021-08-30 11:27 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 06/19] nptl: Replace struct thread cancelhandling field Adhemerval Zanella
2021-08-26 14:34 ` Florian Weimer
2021-08-26 16:48 ` Adhemerval Zanella
2021-08-30 10:36 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 07/19] support: Add support_wait_for_thread_exit Adhemerval Zanella
2021-08-26 9:31 ` Florian Weimer
2021-08-26 16:49 ` Adhemerval Zanella
2021-08-30 11:46 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 08/19] nptl: pthread_kill, pthread_cancel should fail after exit (bug 19193) Adhemerval Zanella
2021-08-26 10:03 ` Florian Weimer
2021-08-26 16:49 ` Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 09/19] nptl: Fix race between pthread_kill and thread exit (bug 12889) Adhemerval Zanella
2021-08-26 14:23 ` Florian Weimer
2021-08-26 17:06 ` Adhemerval Zanella
2021-08-30 9:25 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 10/19] nptl: Use tidlock when accessing TID on pthread_getaffinity_np Adhemerval Zanella
2021-08-26 14:24 ` Florian Weimer
2021-08-26 17:29 ` Adhemerval Zanella
2021-08-30 9:30 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 11/19] nptl: Use tidlock when accessing TID on pthread_setaffinity Adhemerval Zanella
2021-08-26 14:25 ` Florian Weimer
2021-08-26 17:31 ` Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 12/19] nptl: Use tidlock when accessing TID on pthread_getcpuclockid Adhemerval Zanella
2021-08-26 14:27 ` Florian Weimer
2021-08-26 17:41 ` Adhemerval Zanella
2021-08-30 9:34 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 13/19] nptl: Use tidlock when accessing TID on pthread_getschedparam Adhemerval Zanella
2021-08-26 15:00 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 14/19] nptl: Use tidlock when accessing TID on pthread_setschedparam Adhemerval Zanella
2021-08-26 14:35 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 15/19] nptl: Use tidlock when accessing TID on pthread_getname_np Adhemerval Zanella
2021-08-26 14:38 ` Florian Weimer
2021-08-26 17:45 ` Adhemerval Zanella
2021-08-30 9:37 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 16/19] nptl: Use tidlock when accessing TID on pthread_setname_np Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 17/19] nptl: Use tidlock when accessing TID on pthread_sigqueue Adhemerval Zanella
2021-08-26 14:43 ` Florian Weimer
2021-08-26 17:49 ` Adhemerval Zanella [this message]
2021-08-30 9:26 ` Florian Weimer
2021-08-23 19:50 ` [PATCH v2 18/19] nptl: Use tidlock when accessing TID on pthread_setschedprio Adhemerval Zanella
2021-08-23 19:50 ` [PATCH v2 19/19] nptl: Remove INVALID_TD_P Adhemerval Zanella
2021-08-26 9:30 ` Florian Weimer
2021-08-26 14:47 ` [PATCH v2 00/19] Fix various NPTL synchronization issues Florian Weimer
2021-08-26 18:19 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb460539-abc0-f598-d775-e7ecf9b0b729@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).