public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: [PATCH v4 06/11] stdio-common: Add lock optimization to vfprintf and vfwprintf
Date: Thu, 18 Aug 2022 10:54:49 +0200	[thread overview]
Message-ID: <ebd7ff3c2772390a5293ed87fbcf699ceed84f54.1660812721.git.fweimer@redhat.com> (raw)
In-Reply-To: <cover.1660812721.git.fweimer@redhat.com>

After the rewrite and the implicit unbuffered streams handling, this
is very straightforward to add.
---
 stdio-common/vfprintf-internal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/stdio-common/vfprintf-internal.c b/stdio-common/vfprintf-internal.c
index 83a6aea510..23ada8d0ff 100644
--- a/stdio-common/vfprintf-internal.c
+++ b/stdio-common/vfprintf-internal.c
@@ -1452,6 +1452,14 @@ vfprintf (FILE *s, const CHAR_T *format, va_list ap, unsigned int mode_flags)
     return EOF;
 #endif
 
+  if (!_IO_need_lock (s))
+    {
+      struct Xprintf (buffer_to_file) wrap;
+      Xprintf (buffer_to_file_init) (&wrap, s);
+      Xprintf_buffer (&wrap.base, format, ap, mode_flags);
+      return Xprintf (buffer_to_file_done) (&wrap);
+    }
+
   int done;
 
   /* Lock stream.  */
-- 
2.37.1



  parent reply	other threads:[~2022-08-18  8:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-18  8:53 [PATCH v4 00/11] vfprintf refactor Florian Weimer
2022-08-18  8:53 ` [PATCH v4 01/11] locale: Implement struct grouping_iterator Florian Weimer
2022-08-18  8:54 ` [PATCH v4 02/11] stdio-common: Introduce buffers for implementing printf Florian Weimer
2022-08-18  8:54 ` [PATCH v4 03/11] stdio-common: Add __printf_function_invoke Florian Weimer
2022-08-18  8:54 ` [PATCH v4 04/11] stdio-common: Add __translated_number_width Florian Weimer
2022-08-18  8:54 ` [PATCH v4 05/11] stdio-common: Convert vfprintf and related functions to buffers Florian Weimer
2022-08-18  8:54 ` Florian Weimer [this message]
2022-08-18  8:54 ` [PATCH v4 07/11] libio: Convert __vsprintf_internal " Florian Weimer
2022-08-18  8:54 ` [PATCH v4 08/11] libio: Convert __vasprintf_internal " Florian Weimer
2022-08-18  8:55 ` [PATCH v4 09/11] libio: Convert __vdprintf_internal " Florian Weimer
2022-08-18  8:55 ` [PATCH v4 10/11] libio: Convert __obstack_vprintf_internal to buffers (bug 27124) Florian Weimer
2022-08-18  8:55 ` [PATCH v4 11/11] libio: Convert __vswprintf_internal to buffers (bug 27857) Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebd7ff3c2772390a5293ed87fbcf699ceed84f54.1660812721.git.fweimer@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).