From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by sourceware.org (Postfix) with ESMTPS id 830AC395180D for ; Mon, 8 Mar 2021 13:46:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 830AC395180D Received: by mail-qv1-xf32.google.com with SMTP id s17so4546912qvr.12 for ; Mon, 08 Mar 2021 05:46:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3XldlvHnXg7IJm9tGVQkGIq0/Px7hhTCLjofulKyqTg=; b=q0iEa/Xj78wtx/gwCA2OeazM7B1waGbSEB0ABrJTQ6AO49uqDiZ/i4hiLm7PPBDS5x Yy8i0+EMDLa93Os3lOme4NsWFgTPMT5TTH6kyHjUhUWW0p1FGCGiEQBBrGjg+msmgjcM 4Vz4ZyCcY5u7CFAKTcHU6OQ6Dv4JN3OsZnWmLKhYYhiNpSO8sIltBKA0FR8tk+Na2jRe 2M0LM/EQkyEux/4puyFfsSgQ1zEIzO5Ckeqt62CXS/pr+rc0Ve71B+qnNWllGrDzbXFZ 4ZakvExvvQ25pSDYZchTI1IiQcYvpfRqO0zXs5N4qQXPOI2PE+tSs5sauT0MWegrDnsl he/w== X-Gm-Message-State: AOAM530AZWyYRH4RMb61RFgJGgNgyzKtEpnNRNGOG/6yjoQpNrlR6/b2 5zCf0adPYanO0R3Y3yRFzb49ng== X-Google-Smtp-Source: ABdhPJwKNc/IiWS98134UmBYuef+hnDLjm687b/dTsWIBwv57/iBiSt2OMkBW4RM78MsUgoej3xAhQ== X-Received: by 2002:a0c:b617:: with SMTP id f23mr20743884qve.44.1615211207301; Mon, 08 Mar 2021 05:46:47 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id h6sm7616335qtj.75.2021.03.08.05.46.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Mar 2021 05:46:46 -0800 (PST) Subject: Re: [PATCH] resolv: tst-p_secstodate can be a regular test To: libc-alpha@sourceware.org, Florian Weimer References: <874khpg3ml.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Mon, 8 Mar 2021 10:46:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <874khpg3ml.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Mar 2021 13:46:53 -0000 On 05/03/2021 09:57, Florian Weimer via Libc-alpha wrote: > Now that compat_symbol_reference works for non-internal tests, too. > Also do not build and run the tests on architectures which lack the > __p_secstodate compatibility symbol. LGTM, thanks. Reviewed-by: Adhemerval Zanella > > --- > resolv/Makefile | 4 +++- > resolv/tst-p_secstodate.c | 12 ------------ > 2 files changed, 3 insertions(+), 13 deletions(-) > > diff --git a/resolv/Makefile b/resolv/Makefile > index 1047bb6ae5..fb19c93026 100644 > --- a/resolv/Makefile > +++ b/resolv/Makefile > @@ -94,7 +94,9 @@ endif # $(build-shared) > tests-internal += tst-inet_pton > > # This test accesses the __p_secstodate compat symbol. > -tests-internal += tst-p_secstodate > +ifeq ($(have-GLIBC_2.26)$(build-shared),yesyes) > +tests += tst-p_secstodate > +endif > > # This test sends millions of packets and is rather slow. > xtests += tst-resolv-qtypes Ok. > diff --git a/resolv/tst-p_secstodate.c b/resolv/tst-p_secstodate.c > index 78b3aa1d6f..f45c908025 100644 > --- a/resolv/tst-p_secstodate.c > +++ b/resolv/tst-p_secstodate.c > @@ -25,8 +25,6 @@ > > #include > > -#if TEST_COMPAT (libresolv, GLIBC_2_0, GLIBC_2_27) > - > char *__p_secstodate (unsigned long int); > compat_symbol_reference (libresolv, __p_secstodate, __p_secstodate, GLIBC_2_0); > > @@ -71,14 +69,4 @@ do_test (void) > return ret; > } > > -#else > - > -static int > -do_test (void) > -{ > - return 77; > -} > - > -#endif > - > #include > Ok.