From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) by sourceware.org (Postfix) with ESMTPS id 665073954468 for ; Tue, 1 Jun 2021 12:55:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 665073954468 Received: by mail-qk1-x72e.google.com with SMTP id k4so14094004qkd.0 for ; Tue, 01 Jun 2021 05:55:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=tbnTqU+PfpaeAC4m97NZWXgDunx/VHPiaQ0SnBwjgPk=; b=JiEtc4X/8SUiphB2ySq67JJ6YwBsZRPPuoP3nznJytX4PM2hQwIeU/7cgp8dFPJ5rl BgYgGmK0sHNIkiCXUpRH38JiRDvgE/2Kewf33JQjZNedvM2WxYoMlU6bSGs7Z2bF3B6V BSq6F8vsK0OFLAG8ViUefRmvJpt/SdC1OZ0uVK+umT0/7KxnaPOMlx4yIydkiHAJuJd5 TkduvvxzXSFF736Cg1YX3aoNyszyj8/x9xsG8CIa4WgvK9qSWVn9A7YXcO6Ho5q8M2zo 8LCNySQN37ezqqOUxaUAw9h4aaRZG+8b+/3vEFVgwwMq5Y9FKxyT/52c/q69+HmH+l36 TXSg== X-Gm-Message-State: AOAM533EB6W5bUmM6rQZqwRAV4SICHAs3zbl9Nc3oeXrP/zAbnSlwm/v wl7yOIYJHY5oNT96nU3zVMekBcPs8TxKLg== X-Google-Smtp-Source: ABdhPJy+2ANpMzJdEHciDbiM/s/pb6Cinn9QnYMOmBF50i1FTcKuLIl2mGlPnoFuJvlyGe7p8t4cTQ== X-Received: by 2002:a05:620a:918:: with SMTP id v24mr11472540qkv.325.1622552124773; Tue, 01 Jun 2021 05:55:24 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id e20sm10144569qto.93.2021.06.01.05.55.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 05:55:24 -0700 (PDT) Subject: Re: [PATCH v2 1/9] nptl: Remove exit-thread.h To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org> <20210527172823.3461314-2-adhemerval.zanella@linaro.org> <87zgwa6n0m.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: Date: Tue, 1 Jun 2021 09:55:22 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87zgwa6n0m.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jun 2021 12:55:26 -0000 On 01/06/2021 04:51, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/nptl/pthread_create.c b/nptl/pthread_create.c >> index 2d2535b07d..aacbba1cac 100644 >> --- a/nptl/pthread_create.c >> +++ b/nptl/pthread_create.c >> @@ -30,7 +30,6 @@ >> #include >> #include >> #include >> -#include >> #include >> #include >> #include >> @@ -575,7 +574,10 @@ start_thread (void *arg) >> >> The exit code is zero since in case all threads exit by calling >> 'pthread_exit' the exit status must be 0 (zero). */ >> - __exit_thread (); >> + while (1) >> + { >> + INTERNAL_SYSCALL_CALL (exit, 0); >> + } >> >> /* NOTREACHED */ >> } > > You could leave off the braces. But still looks good. Ack.