public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: libc-alpha@sourceware.org, Jorgen Hansen <jhansen@vmware.com>
Subject: Re: [RFC PATCH 0/2] Add AF_VSOCK support to getnameinfo(3) and getaddrinfo(3)
Date: Fri, 07 Oct 2016 14:02:00 -0000	[thread overview]
Message-ID: <ed9abbad-099b-470b-b36c-da8d002aa84d@redhat.com> (raw)
In-Reply-To: <3649baeb-be14-fa8a-f1af-7ac3637d0547@redhat.com>

On 10/06/2016 01:19 PM, Florian Weimer wrote:

>>> How do you expect that applications will know that they have to pass
>>> AF_VSOCK to getaddrinfo instead of AF_UNSPEC?
>>
>> For example ncat(1) has --unixsock and --udp command-line options.  A
>> --vsock option can be added.  At that point the program knows to use
>> AF_VSOCK and the same getaddrinfo(3) code path can be used by TCP, UDP,
>> UNIX, and vsock.
>
> ncat doesn't use getaddrinfo AFAICS, so this isn't going to help it. The
> larger nmap codebase has a call to getaddrinfo, but the code leading to
> it assumes 16-bit port numbers, so it won't be able to use getaddrinfo
> either.
>
> Do you have a better example?

I've looked briefly at nfs-utils.  I don't see how you can patch in 
AF_VSOCK support using the proposed getaddrinfo support, either.  It 
seems to do the address and service lookup separately.

Thanks,
Florian

  reply	other threads:[~2016-10-07 14:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-29 10:27 Stefan Hajnoczi
2016-09-29 10:27 ` [RFC PATCH 1/2] getnameinfo: Add AF_VSOCK support Stefan Hajnoczi
2016-09-29 10:27 ` [RFC PATCH 2/2] getaddrinfo: " Stefan Hajnoczi
2016-10-06 11:04   ` Florian Weimer
2016-09-29 13:26 ` [RFC PATCH 0/2] Add AF_VSOCK support to getnameinfo(3) and getaddrinfo(3) Florian Weimer
2016-09-30 11:11   ` Stefan Hajnoczi
2016-10-06  9:07     ` Stefan Hajnoczi
2016-10-06 11:19     ` Florian Weimer
2016-10-07 14:02       ` Florian Weimer [this message]
2016-12-05 15:58         ` Stefan Hajnoczi
2016-12-05 16:02           ` Florian Weimer
2016-12-06 13:29             ` Stefan Hajnoczi
2016-10-07 15:05       ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ed9abbad-099b-470b-b36c-da8d002aa84d@redhat.com \
    --to=fweimer@redhat.com \
    --cc=jhansen@vmware.com \
    --cc=libc-alpha@sourceware.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).