From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 0D7483857C50 for ; Wed, 24 Mar 2021 13:09:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0D7483857C50 Received: by mail-qt1-x82d.google.com with SMTP id x9so17444195qto.8 for ; Wed, 24 Mar 2021 06:09:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gPFIFzq6iRAyq30tCYVPVZTnj8AKideWsKJkSWh9pXo=; b=DdaCw4PFoie8GJyxJt4DvrY1yGT4Bir3YcwpqZFxrNNQ02K2U/ihHF0g2zuNN/n7bS OTgpupiUJix/bz7rTGBBrGObTWMLPyhP0V8Ed8t6tYsg0dCWpfooOAKhC24TOFs6+hIZ qahSedb3yscL905aGpVaJSG/BwEkTiYjpS3EAyf9ZpeeHL0oC+9VpB4yUVXw5kH5l9Fl KQzAhGZMj0LGJ0rGFackiO4yWwTuS5Rne2FY9FrhBGPFNUbC0M/Fyjqlay5lV4PPN0M/ 0brA0QZGGnfHLGunzpiOiTQKKsrPuwnNIVtmiWmc1UytmqiV0TdHxxqHmxgjr2L1X7Er 2Xxw== X-Gm-Message-State: AOAM532WPfFfc7cy/zP4oyQ5OfUTPC/Z33FJYUUIeMtEmkpZTVcmI4zm 5CzmxZE5osYZePv5cfgjXrTSGw4q44OmTQ== X-Google-Smtp-Source: ABdhPJxorqaiIqlp+6geqe6VrtX/+ihdse760i0RPuq1Rur6q5tLP4fOroxoqT1gn+CIyP4MXu4aDg== X-Received: by 2002:ac8:7215:: with SMTP id a21mr2918660qtp.199.1616591351959; Wed, 24 Mar 2021 06:09:11 -0700 (PDT) Received: from [192.168.1.132] ([177.194.41.149]) by smtp.gmail.com with ESMTPSA id h75sm1570963qke.80.2021.03.24.06.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 06:09:11 -0700 (PDT) Subject: Re: [hurd,commited] htl: Add missing fork.h From: Adhemerval Zanella To: Samuel Thibault Cc: libc-alpha@sourceware.org References: <20210324002015.338244-1-samuel.thibault@ens-lyon.org> <20210324123136.x5ab7fkrcm557enm@begin> <6aa8826c-b8ab-d999-4b99-e61c27282587@linaro.org> <20210324124532.sp6nkal764gwyatj@begin> <20210324130039.stnuexy2tw7wnkuf@begin> <79f51c68-8820-1994-8802-91411a705de3@linaro.org> Message-ID: Date: Wed, 24 Mar 2021 10:09:09 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <79f51c68-8820-1994-8802-91411a705de3@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Mar 2021 13:09:14 -0000 On 24/03/2021 10:04, Adhemerval Zanella wrote: > > > On 24/03/2021 10:00, Samuel Thibault wrote: >> Adhemerval Zanella, le mer. 24 mars 2021 09:56:47 -0300, a ecrit: >>> On 24/03/2021 09:45, Samuel Thibault wrote: >>>> Adhemerval Zanella, le mer. 24 mars 2021 09:40:36 -0300, a ecrit: >>>>> Why exactly tst-atfork2 fails without this includes? >>>> >>>> It misses the atfork unregister hook called at module unload. >>> >>> Ok, but *why* exactly? The sysdeps/htl/pt-atfork.c already >>> includes register-atfork.h after the fork.h inclusion. >> >> It's not pt-atfork.c which needs UNREGISTER_ATFORK, but >> stdlib/cxa_finalize, which gets it from fork.h > > Thanks, this is a good indication that is better to just remove > the ifdef UNREGISTER_ATFORK from cxa_finalize (since now it is > defined on generic implementation). And I think the fork.h header is not really required here, it is being used solely to define the NPTL specific __fork_generation, which Florian recent patch moves to libc.so. So I think we can move this declaration to another internal header and remove fork.h.