From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id AAC753858433 for ; Wed, 22 Mar 2023 18:46:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AAC753858433 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-17aeb49429eso20051150fac.6 for ; Wed, 22 Mar 2023 11:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679510791; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IMOzrOXn+HMdM9PaamCxG7UjwA/xFsYDAvxy0scHuEs=; b=NVRnXkbaRuPOd33sfD+HvBsmILcJFM+cSUMYs/SBydhOHeKZDMg6Io1VjrsWod4qPa FMcUGy9SWYu8bH1pvs4bFE6BwuRK4ZuFQ8Cbs6ldxG3iT1EzlWDXQLW1YBLctCCdjM5M QeGNM94fGrErlYyJ1b0At3DduZX3pp1X0GkL+h/mlLKpmcGAeMZu4Y0O+jOu4bUzq6Ew 8JN8q29aIT7ey0/Tg6pNi6Q3k6YCWLYekihBNmueZSYpBhuP9FesNZNRtv5hMl8K1jQy WP6xbU50d9Wx9n3fsXjm3/+PVplZAHLTzXvBtsc6g8kGcrOy+DPuOChNEAZnc6sOiVDb 3aKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679510791; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IMOzrOXn+HMdM9PaamCxG7UjwA/xFsYDAvxy0scHuEs=; b=tMvNI55ZwehRtn/GFgIQRjRy/x6yywCIcfsKggLoYd9V2g1BhLsM62DZvqkwKIHhvu ASb39fntMFcC10EJaHYy25pMDqCsYNEFwl9VJ3Vznebt11HMeFICHhUwb8zWAwAucIcV ywmlwBbwdFR1FgF06sLFy/f/BP+EIhIXueaR90j5MEjzrfs9kaQ0tv4GaO1kFLFAtzig QjUhqN7j1rlmP4UfKgeQFCi1xuYacOvHsaxSaKNLMB9orrIapRAzABHvTkWkOs7UTo5H 6+g541D1ByJNrPlAOonAOGnC3KxL17Rv8W4SJVF6myB9ofHWIZ28RgscHrV0MsUMohZT 8mRg== X-Gm-Message-State: AO0yUKWjyhlXZTLmLrXux0wDLuZWW/WHSo082yN5m+SwzYt7+Z83HJib lrYFLoo85SkLi7vEpnCYEpSduA== X-Google-Smtp-Source: AKy350Zruvtjbv+fgona8nqVG0qIy/sbi6f6oSIOA4qJQ0gTV2WvdxwES7lf4GkIfvxkBn14SBSdVQ== X-Received: by 2002:a05:6870:f116:b0:177:b8a2:5854 with SMTP id k22-20020a056870f11600b00177b8a25854mr391151oac.45.1679510790983; Wed, 22 Mar 2023 11:46:30 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c260:7930:b4e8:7389:be1f? ([2804:1b3:a7c0:c260:7930:b4e8:7389:be1f]) by smtp.gmail.com with ESMTPSA id m3-20020a056870a10300b0016b0369f08fsm5521746oae.15.2023.03.22.11.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Mar 2023 11:46:30 -0700 (PDT) Message-ID: Date: Wed, 22 Mar 2023 15:46:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] elf: Remove glibc.rtld.dynamic_sort tunable Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org, Florian Weimer References: <20230313190627.2000578-1-adhemerval.zanella@linaro.org> <20230313190627.2000578-2-adhemerval.zanella@linaro.org> <45835a92-55a1-6637-183a-4ecad79d9065@linaro.org> <50f4d048-bdde-fccc-fdd2-edd7b67994ee@gotplt.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <50f4d048-bdde-fccc-fdd2-edd7b67994ee@gotplt.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 22/03/23 15:40, Siddhesh Poyarekar wrote: > On 2023-03-22 13:51, Adhemerval Zanella Netto wrote: >> >> >> On 22/03/23 14:08, Siddhesh Poyarekar wrote: >>> On 2023-03-13 15:06, Adhemerval Zanella wrote: >>>> And make the DFS algorithm (added on 2.35) the de-facto implementation. >>> >>> Isn't this orthogonal to the proposal to remove --enable-tunables? >> >> Yes, the DFS is already the default one.  I meant that now there is no way to >> select the one algorithm.  Maybe use the commit messagE: >> >>    And make the old sort algorithm no longer available. > > OK, I'll stick to reviewing the --enable-tunables patch then, assuming that it can go in independently of this one.  I feel much less comfortable acking this one since I haven't been closely involved in sorting algorithm selection.  I get the sense that maybe it makes sense to wait a couple more releases before removing the old sort algorithm but that's not based on any specific knowledge, just an instinct. Well, without tunables the old algorithm can not be selected. So the second part does depend of this. The old algorithm was kept mainly to provide some fallback compatibility to binaries that does not work correctly with newer one; but the default one is already in 3 release, it is faster, and so far I have not heard of any drawnback.