From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by sourceware.org (Postfix) with ESMTPS id BA8163858C3A for ; Tue, 21 Dec 2021 17:49:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA8163858C3A Received: by mail-qv1-xf34.google.com with SMTP id q3so5754214qvc.7 for ; Tue, 21 Dec 2021 09:49:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G/GP9izW9pS2cs41CAr9r66reAeVRofuNoW9y9HbZLU=; b=dtL+ML+GZDRPvzSrT8ZbUu0CA8hQfDjeFW0RX+DuQGIjQqCRrDvCN5YfPZl2FYt4u2 dMOaqvZl1/qYa2WDXxECwIP4ffolS0MRcndFPE/p60uyMTqbhaT9iCk3SysjdfgnKJFN e9/Q1048b33i6l4NQD85mUN/ZCKogbKb8NReFbr3R2CJ+j073jHTEs0rB4YNq6D3H8fS 16zRvAtE3UJmDHtO79vdwBLh97BB+49II/OIvaJRgjp5RJnY/AIccbE9kA3qTbZryVyG kDu5DoS7EcQGYL6d6WmECKj7/NIVE1y7EEddiY0qmoSW9KYgXLgiaKv6+9eO5yol3hf2 7QPQ== X-Gm-Message-State: AOAM531sD3cD5ocmhz3+hu4F2My6N5SOY5QoQ2ZKboIgR7tqVYbdsqaZ SUu5wCjuj1H+eood9o9K+hfdMQ== X-Google-Smtp-Source: ABdhPJw97qzXSr/BVnog/1u3oIBnQR60/Cg3Wqjf86FSEuWJXPkDZsIv0DwOvjEE9WwSrBpe4nDOWQ== X-Received: by 2002:a05:6214:ac1:: with SMTP id g1mr3572496qvi.66.1640108994279; Tue, 21 Dec 2021 09:49:54 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:3b1e:8bd2:32a9:e2a3:1842? ([2804:431:c7cb:3b1e:8bd2:32a9:e2a3:1842]) by smtp.gmail.com with ESMTPSA id s126sm13806720qkf.7.2021.12.21.09.49.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 09:49:53 -0800 (PST) Message-ID: Date: Tue, 21 Dec 2021 14:49:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 19/20] elf: Fix runtime linker auditing on aarch64 (BZ #26643) Content-Language: en-US To: Szabolcs Nagy Cc: libc-alpha@sourceware.org, Florian Weimer , John Mellor-Crummey References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-20-adhemerval.zanella@linaro.org> <20211221174709.GD3294453@arm.com> From: Adhemerval Zanella In-Reply-To: <20211221174709.GD3294453@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 17:49:59 -0000 On 21/12/2021 14:47, Szabolcs Nagy wrote: > The 11/15/2021 15:37, Adhemerval Zanella via Libc-alpha wrote: >> --- a/sysdeps/aarch64/bits/link.h >> +++ b/sysdeps/aarch64/bits/link.h >> @@ -20,23 +20,29 @@ >> # error "Never include directly; use instead." >> #endif >> >> +typedef union >> +{ >> + float s; >> + double d; >> + long double q; >> +} La_aarch64_vector; >> + >> /* Registers for entry into PLT on AArch64. */ >> typedef struct La_aarch64_regs >> { >> - uint64_t lr_xreg[8]; >> - uint64_t lr_dreg[8]; >> - uint64_t lr_sp; >> - uint64_t lr_lr; >> + uint64_t lr_xreg[9]; >> + La_aarch64_vector lr_vreg[8]; >> + uint64_t lr_sp; >> + uint64_t lr_lr; >> } La_aarch64_regs; >> >> /* Return values for calls from PLT on AArch64. */ >> typedef struct La_aarch64_retval >> { >> - /* Up to two integer registers can be used for a return value. */ >> - uint64_t lrv_xreg[2]; >> - /* Up to four D registers can be used for a return value. */ >> - uint64_t lrv_dreg[4]; >> - >> + /* Up to eight integer registers can be used for a return value. */ >> + uint64_t lrv_xreg[8]; >> + /* Up to eight V registers can be used for a return value. */ >> + La_aarch64_vector lrv_vreg[8]; >> } La_aarch64_retval; >> __BEGIN_DECLS > > > i think for variant_pcs we will only need a > > void *extension; > > or similar member at the end of both structs. > > (we can make it point to a dump of all registers > in some format for variant_pcs PLT hooks) > > if this can avoid a second bump of LAV_CURRENT > when we add variant_pcs support then it may be > useful to have. (if this turns out to be not > enough then we don't lose much, but it also > means users have to check extension==0 for now > and avoid interpreting or touching the registers > otherwise. not sure if this is better or bump, > depends on how many users need to keep updating > their auditor libs on our bumps.) That's my idea as well, I really don't want to bump LAV_CURRENT for aarch64 on 2.36.