From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from xry111.site (xry111.site [IPv6:2001:470:683e::1]) by sourceware.org (Postfix) with ESMTPS id 19C223858C1F for ; Tue, 1 Nov 2022 02:14:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19C223858C1F Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=xry111.site Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=xry111.site DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1667268869; bh=Ys/VvP0Ci+yV/Vq0Twr1dl2xIQ7rHek6MUmz48f7/sw=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=c9w9jmLkDGEfWUQNRIHG1tjbvxbMHR6cyYIir1mEdDdKdAbu30dobghcYaovriQCL ejQF1KjedvbX2G89IDw4kh4XSm/ba4mRF00JXlSej8dEPOLtitDDHOpA+pkw6ddrM+ kBxmO/FyIu0S9sdqidxvU6AintZ/W6TM540V6wIk= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384)) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id BB9BF65F11; Mon, 31 Oct 2022 22:14:27 -0400 (EDT) Message-ID: Subject: Re: [PATCH] LoongArch: Fix ABI related macros in elf.h to keep consistent with binutils[1]. From: Xi Ruoyao To: caiyinyu , Carlos O'Donell , adhemerval.zanella@linaro.org Cc: i.swmail@xen0n.name, libc-alpha@sourceware.org Date: Tue, 01 Nov 2022 10:14:26 +0800 In-Reply-To: <51360f07-4965-c6f7-8e30-160c8e6880f7@loongson.cn> References: <20221031034334.3027740-1-caiyinyu@loongson.cn> <0a618c5f8c1d5a621e157a6167048c102fd8d501.camel@xry111.site> <51360f07-4965-c6f7-8e30-160c8e6880f7@loongson.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FROM_SUSPICIOUS_NTLD,GIT_PATCH_0,LIKELY_SPAM_FROM,PDS_OTHER_BAD_TLD,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 2022-11-01 at 10:02 +0800, caiyinyu wrote: > diff --git a/elf/elf.h b/elf/elf.h >=20 > index 3f08823a30..d51eb75a73 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -4093,8 +4093,11 @@ enum > =C2=A0=C2=A0#define R_NDS32_TLS_DESC=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = 119 >=20 > =C2=A0=C2=A0/* LoongArch ELF Flags */ > -#define EF_LARCH_ABI=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 0x07 > -#define EF_LARCH_ABI_LP64D=C2=A0=C2=A0=C2=A0=C2=A0 0x03 > +#define EF_LOONGARCH_ABI_MODIFIER_MASK 0x07 > +#define EF_LOONGARCH_ABI_SOFT_FLOAT=C2=A0=C2=A0=C2=A0=C2=A0 0x01 > +#define EF_LOONGARCH_ABI_SINGLE_FLOAT=C2=A0=C2=A0 0x02 > +#define EF_LOONGARCH_ABI_DOUBLE_FLOAT=C2=A0=C2=A0 0x03 > +#define EF_LOONGARCH_OBJABI_V1=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0 0x40 Again, is "LARCH" -> "LOONGARCH" change intentional? The ABI doc does not specified the name of these macros... And we already have R_LARCH_* so the difference of "LARCH" and "LOONGARCH" seems puzzling. And is it an option to keep old names there with a warning? #define EF_LARCH_ABI_LP64D __glibc_macro_warning ("EF_LARCH_ABI_LP64D is de= precated") 0x03 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University