From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 3E92C385840A for ; Tue, 15 Aug 2023 11:58:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3E92C385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-1c4d67f493bso1696362fac.2 for ; Tue, 15 Aug 2023 04:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692100700; x=1692705500; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=+NcM6LeI0wUP9L6Lom4priUCZvSOF+Q2zVEHGgQHK/Q=; b=ZvxC/6H0JI3N+GIjDv8pvA/v+/JXv2KfmEplopYYqfLdLx/T6EeJhCiV3/CyKI/jEz iss+6HF/GDt67ILC10Bv/c946aUmIm58n4hZKWmAnm9sOQa5OpD3DwkDBUeobbIkv/Rj cFo6jjsdxF9XSeHvARlwFbjsfRJDwHzrJYnnK/3LpTn9T/o3JgBrbpFKVSE4hLKmW5oF r30BR/lDUM/h4UdCrKXeylWvHYKtF36REN3k1ce90ooMTjQjj+ZuADjgNADqDr2Mh0YV 1y5HStKmvwLyaflh3tYj3wpLwKfqWRnA5m5XeuZiB+rgpLxN9fyTmcpZXGZOjgtcVFkU Uq2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692100700; x=1692705500; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+NcM6LeI0wUP9L6Lom4priUCZvSOF+Q2zVEHGgQHK/Q=; b=JF/cRfCs/8yQiYXRfUlww3XGQ+YHo2xYxz3w5/942/7av4QKzLxR0YhzGGlGphbIBk xJggqCNtkd8EG+qKCo2JmSIHm8MiHsWpLAgCfk6La/dLkI72MuYr1hotUEkps6cIvX/Z 9CuBU1TqcuaI8ZMJoYiQyDj5rpt2ezq1WDZ5BpKS1iy+r2KqmNJf+lJ4WjV9kxN1BZ4N DWThArtSNVPkiaZMgjqPvKNNX1F7NCxsfkdm0lr6qMa4RrhNpmrllIfKZ1xeeYH1t+6o r84Sjbu/Vw5wqxzf/ru/sQ8mGIH8TDYgTXUhgd1OkdpH8WBWBeeDhB9WKal/FJShlQ3M 9kcA== X-Gm-Message-State: AOJu0YxAKrpX9B26SMvJAvsmMlASg1rtYGLH8y/grCtqKT+kpMtFqxTA X+TpriVYqTE0YrhoRonhuKY8SA== X-Google-Smtp-Source: AGHT+IEPBExWtt8MNis2Ap5mzZ2/J9aR/ykS6hdWAkmnqY6r9cKT+oQf4kDw22AtF2wIkdTJkWFE1g== X-Received: by 2002:a05:6870:d113:b0:1c1:12dc:70b1 with SMTP id e19-20020a056870d11300b001c112dc70b1mr13278550oac.57.1692100700596; Tue, 15 Aug 2023 04:58:20 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:365b:9c82:894c:88da:f9ac? ([2804:1b3:a7c2:365b:9c82:894c:88da:f9ac]) by smtp.gmail.com with ESMTPSA id dx37-20020a05687076a500b001bbdbe7ccc5sm6171257oab.41.2023.08.15.04.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 04:58:19 -0700 (PDT) Message-ID: Date: Tue, 15 Aug 2023 08:58:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH] malloc: Remove bin scanning from memalign (bug 30723) Content-Language: en-US To: Florian Weimer , Andreas Schwab Cc: Florian Weimer via Libc-alpha , DJ Delorie , Siddhesh Poyarekar References: <87pm3uajev.fsf@oldenburg.str.redhat.com> <87bkfc92hf.fsf@linux-m68k.org> <878raec7c9.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <878raec7c9.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14/08/23 06:16, Florian Weimer wrote: > * Andreas Schwab: > >> malloc.c: In function '_int_free': >> malloc.c:4496:13: error: unused variable 'fwd' [-Werror=unused-variable] >> 4496 | mchunkptr fwd; /* misc temp for linking */ >> | ^~~ >> malloc.c:4495:13: error: unused variable 'bck' [-Werror=unused-variable] >> 4495 | mchunkptr bck; /* misc temp for linking */ >> | ^~~ >> malloc.c:4494:19: error: unused variable 'prevsize' [-Werror=unused-variable] >> 4494 | INTERNAL_SIZE_T prevsize; /* size of previous contiguous chunk */ >> | ^~~~~~~~ >> malloc.c:4493:7: error: unused variable 'nextinuse' [-Werror=unused-variable] >> 4493 | int nextinuse; /* true if nextchunk is used */ >> | ^~~~~~~~~ >> malloc.c:4492:19: error: unused variable 'nextsize' [-Werror=unused-variable] >> 4492 | INTERNAL_SIZE_T nextsize; /* its size */ >> | ^~~~~~~~ >> malloc.c:4491:13: error: unused variable 'nextchunk' [-Werror=unused-variable] >> 4491 | mchunkptr nextchunk; /* next contiguous chunk */ >> | ^~~~~~~~~ >> cc1: all warnings being treated as errors >> make[2]: *** [../o-iterator.mk:9: /home/abuild/rpmbuild/BUILD/glibc-2.38.9000.31.g084fb31bc2/cc-base/malloc/malloc.o] Error 1 > > Found it, I believe I'm not seeing this because of: > > commit 78ceef25d64efeeb6067d1cb282a00466e637e2a > Author: Adhemerval Zanella Netto > Date: Mon Jul 24 14:22:27 2023 -0300 > > configure: Remove --enable-all-warnings option > > The option is not activelly tested and has bitrotten, to fix it > would require a lot of work and multiple fixes. A better option > would to evaluate each option and enable the warning if it makes > sense. > Reviewed-by: Siddhesh Poyarekar > > diff --git a/Makeconfig b/Makeconfig > index 77d7fd14df..c4dd9ea8f2 100644 > --- a/Makeconfig > +++ b/Makeconfig > @@ -857,12 +857,7 @@ host-test-program-cmd = $(host-built-program-cmd) > endif > > # Extra flags to pass to GCC. > -ifeq ($(all-warnings),yes) > -+gccwarn := -Wall -Wwrite-strings -Wcast-qual -Wbad-function-cast -Wmissing-noreturn -Wmissing-prototypes -Wmissing-declarations -Wcomment -Wcomments -Wtrigraphs -Wsign-compare -Wfloat-equal -Wmultichar > -else > -+gccwarn := -Wall -Wwrite-strings > -endif > -+gccwarn += -Wundef > +gccwarn := -Wall -Wwrite-strings -Wundef > ifeq ($(enable-werror),yes) > +gccwarn += -Werror > endif > > It dropped -Wall from glibc's default CFLAGS due to a typo (gccwarn > instead of +gccwarn). > > Will test a fix with build-many-glibcs.py. Oops, sorry about that and thanks for fixing this up.