From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8F0E73858CD1 for ; Thu, 22 Feb 2024 23:36:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F0E73858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F0E73858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708644997; cv=none; b=NFC7MSLB1TWklk9n01hXjLQLgrcmkQd/utf5TA9XOFdPd0HjzSKJCzP8FSmYyLuyaSY8EVr8x/cXbBV+gfYzKBlaMMpSVTXS4dTD+5m9SzTENawJovFsU2M2nMZbERnKPazlGRxqIaeey/J59Ot7XpyZ+Gjch2GlilBZYgKLCWc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708644997; c=relaxed/simple; bh=nOrsJXxNBCOdCWf632SJ3XQC9W8Y9bQbNsj2tD13nRs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=b9Zn0ipekRaRv1xclZH9i3b19qRi26rxp0fuUGi2Kn/susqyuQ9Sstnu1kIX1oiU85QagdYcERtXtRpTMIqB7YGjAHMp2t4neXwhfeM9Cw+fLCbUFhO/MzuKnudnwwIDkYHcTyzvAV3kY9e9qJOGsdkb6eZ4fhdvJzZCXr47CVg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708644995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kk+SPL2ysiTkhvsU4DMbgPhku3LwlD5fHupP/agEiic=; b=Ba8CnX34WHqXy1vE/1KWbDUJUZzcAZDwNPrXFD9oZXYqlQbvMFYbLRhbj7dWmtIMolvAXu phpw53qHjS45Oyzmz5I3u8PQgvBXQvpXbJRvvItsxh/cgEF+15Vc6mxvSUuLvgY9NzDq7N q0xXpk3NRcCYB680yC7dmDJFJ2+6omk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-cgrtn00hOq6Lk36HurO4KQ-1; Thu, 22 Feb 2024 18:36:34 -0500 X-MC-Unique: cgrtn00hOq6Lk36HurO4KQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40e435a606aso1216285e9.3 for ; Thu, 22 Feb 2024 15:36:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708644993; x=1709249793; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Kk+SPL2ysiTkhvsU4DMbgPhku3LwlD5fHupP/agEiic=; b=rLIx6gbm0zZ1sQbp7QA1oPV4G9xGgR1/ZQhninueZ80NQewRKAC4TgWFHIyKixdcLK bTDVjVy6m1xs49ucrBRjAB6sMAUNSi5dArIeddr7wHr/cGR+2beWJ7WBOGWnEGR8zznD p/Uq7kNOG2UPj6L++Go+t2/IVjeXINdkQpwrr1MY1AgIQxBgvVRAh1Z0n6AC9yD9xhdu nlZ/EbdcGVNMB9tmrvdwf0k6kxWshZ6DcdrFhTAACwoM0YGYBwOnFtb93/vsZp9rRICs GimsurcWJZaz0EZZIQ6n/LMqjCdJ+VY2j0UNoMQuXvORT79TqD0pGRbTLlCwrmmGWZ21 9xMw== X-Gm-Message-State: AOJu0Yww0IvqUZhvNY9TqoMoDxUwjWjFdFXs+ZO/Lgk+ilaFMNfu5spP ePAG/HMF1AXClYt1oQ8buGy6jlW63M4xyehlH4Q84sp3lmQ8Dhvo0W6xM0/dB6MYwe0zAenkNwU de0opfafd77LDBZ5B2uxiXgt3r99rKthTA3cF1S6zJ/fsOobOvZFcFFshGg== X-Received: by 2002:a05:600c:cc3:b0:412:8e75:7701 with SMTP id fk3-20020a05600c0cc300b004128e757701mr99998wmb.34.1708644992887; Thu, 22 Feb 2024 15:36:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCl+PYoFHzWQjL5mDhWlYnD1ZaZCn+wcKoOT1BIognVejSBY15eLEGYvL4H3EYeqpiGdgu2A== X-Received: by 2002:a05:600c:cc3:b0:412:8e75:7701 with SMTP id fk3-20020a05600c0cc300b004128e757701mr99992wmb.34.1708644992552; Thu, 22 Feb 2024 15:36:32 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id m9-20020a7bca49000000b00410add3af79sm116449wml.23.2024.02.22.15.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 15:36:32 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rdIcB-004a6q-6W; Thu, 22 Feb 2024 23:36:31 +0000 Date: Thu, 22 Feb 2024 23:36:31 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 14/32] elf: Use struct link_map_private for the internal link map In-Reply-To: <9a95b24fcdf000b7f3591c16afd3edd26d423b50.1701944612.git.fweimer@redhat.com> Message-ID: References: <9a95b24fcdf000b7f3591c16afd3edd26d423b50.1701944612.git.fweimer@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Florian Weimer wrote: > And struct link_map for the external link map type. This avoids > having different definitions of struct link_map in different > translation units, and should help with debugging. > > Upcasts (from struct link_map_private * to struct link_map) should > use &L->l_public (no actual cast). Downcasts should use the l_private > helper function. > > The changes from the move of l_addr, l_name, etc. to l_public.l_addr, > l_public.l_name could be avoided if we built glibc with > -fms-extensions, but this does not seem to be a good idea because > we probably do not want the other extensions enabled by this flag. > Introducing access macros for l_addr does not work because some of > the l_* names (including l_addr) are used as local variables. OK provided this has passed build-many-glibcs.py, and with a few notes below: > elf/dl-fptr.c | 6 +- As this file is only built for hppa and hppa builds it with -Wno-error, you should also check the logs for the build of that file for hppa to make sure there are no new warnings indicating any problems with the patch. > sysdeps/ia64/dl-lookupcfg.h | 6 +- > sysdeps/ia64/dl-machine.h | 29 +-- The ia64 parts will of course need to be removed. > diff --git a/include/link.h b/include/link.h > index adb3886193..ae76a99c30 100644 > --- a/include/link.h > +++ b/include/link.h > @@ -5,7 +5,7 @@ > > The GNU C Library is free software; you can redistribute it and/or > modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > + License as published by the Free Software Foundation; either > version 2.1 of the License, or (at your option) any later version. > > The GNU C Library is distributed in the hope that it will be useful, This spurious indentation change should be removed. -- Joseph S. Myers josmyers@redhat.com