From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
GNU C Library <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH] support: Add TEST_COMPARE macro
Date: Mon, 27 Nov 2017 18:06:00 -0000 [thread overview]
Message-ID: <f0593826-1721-d424-905c-6755b813bbf7@redhat.com> (raw)
In-Reply-To: <72d1c0c0-44b3-69f7-7630-0d47be285a30@cs.ucla.edu>
On 11/27/2017 07:00 PM, Paul Eggert wrote:
> Come to think of it, perhaps it would be easier to add -Wsign-compare
> only for TEST_COMPARE, and remove all the other gorp. What we're trying
> to do here, is to have the effect of -Wsign-compare. Surely it's better
> to do this check at compile-time with the compiler's help, rather than
> try to dodge the compiler and do the check at run-time.
I'm not certain about that at all—the *types* could well differ in
signedness between architectures (as it is common for char). This is
the main reason why I only want to test the values.
Florian
next prev parent reply other threads:[~2017-11-27 18:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 10:19 Florian Weimer
2017-11-23 10:52 ` Siddhesh Poyarekar
2017-11-23 10:54 ` Florian Weimer
2017-11-23 11:09 ` Andreas Schwab
2017-11-23 11:38 ` Florian Weimer
2017-11-23 11:49 ` Andreas Schwab
2017-11-23 11:57 ` Florian Weimer
2017-11-23 13:01 ` Andreas Schwab
2017-11-24 8:46 ` Paul Eggert
2017-11-24 9:28 ` Florian Weimer
2017-11-24 18:31 ` Paul Eggert
2017-11-24 19:13 ` Florian Weimer
2017-11-25 0:05 ` Paul Eggert
2017-11-27 10:46 ` Florian Weimer
2017-11-27 18:00 ` Paul Eggert
2017-11-27 18:06 ` Florian Weimer [this message]
2017-11-27 18:33 ` Paul Eggert
2017-11-27 18:43 ` Florian Weimer
2017-11-27 18:53 ` Paul Eggert
2017-12-01 15:53 ` Florian Weimer
2017-12-01 19:06 ` Paul Eggert
2017-12-04 16:35 ` Florian Weimer
2017-12-04 19:23 ` Paul Eggert
2017-11-27 16:18 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0593826-1721-d424-905c-6755b813bbf7@redhat.com \
--to=fweimer@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=eggert@cs.ucla.edu \
--cc=libc-alpha@sourceware.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).