From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by sourceware.org (Postfix) with ESMTPS id F309A388981B for ; Mon, 28 Jun 2021 20:10:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F309A388981B Received: by mail-pl1-x62b.google.com with SMTP id h1so9601343plt.1 for ; Mon, 28 Jun 2021 13:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sAtb8D6Sp1frVqeux3uXOaWvKtd0qpiZFvgbsmzDXQ8=; b=t5P3Qq/RwYuIQcSU5D/243pd2LITKvQNwa+ft/zhAy4/XXykY8Anti1C2maQmilxDm uae4hyShCKdX3H8QZdWJ2917ypiY/LEr/WwuAGQXbXFexmERLtipjnilf0RiWUGoSe4Q G7otWVBLRPMPeOTxnNprTg4OSyDDXgWUgiZ+ypBuzK4PdxQLp/rwi82zD9qvasHNaF0i ALrSBQ5oHumHcbZoJReV9trxyWHoDPL9WCUfJNyXx3huilAllVJepfdC5ZKP3F3+1C/f QAXOKruods6L0/GA4Vg0EzM4leMsTkJZoqIlA8w/FrHm4Y36b+UauQRwms3uxscG/pnx V7Jg== X-Gm-Message-State: AOAM532i4754cfv9PPVSigu1DaS5kvUDtlomDBlBGEr6fKP3oRxjOyB0 vNIjRuZgL48M2RXEjl5mrXdYow== X-Google-Smtp-Source: ABdhPJxkIfQNIVRkfySWQeEmU1etDA84i76/7bvsVS1y095G9YWSB90W5+W+21zimdYV+GUlZctG/w== X-Received: by 2002:a17:90a:7843:: with SMTP id y3mr29102967pjl.190.1624911031038; Mon, 28 Jun 2021 13:10:31 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id gd5sm388418pjb.45.2021.06.28.13.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 13:10:30 -0700 (PDT) Subject: Re: [PATCH 2/2] posix: Add terminal control setting support for posix_spawn To: Andreas Schwab , Adhemerval Zanella via Libc-alpha Cc: Godmar Back References: <20210617175751.1619846-1-adhemerval.zanella@linaro.org> <20210617175751.1619846-2-adhemerval.zanella@linaro.org> <8735tgmk79.fsf@igel.home> From: Adhemerval Zanella Message-ID: Date: Mon, 28 Jun 2021 17:10:27 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <8735tgmk79.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 20:10:33 -0000 On 17/06/2021 15:15, Andreas Schwab wrote: > On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote: > >> @@ -166,6 +168,18 @@ extern int posix_spawnattr_setschedparam (posix_spawnattr_t *__restrict __attr, >> __restrict __schedparam) >> __THROW __nonnull ((1, 2)); >> >> +#ifdef __USE_GNU >> +/* Make the spawned process the foreground process group on the terminal >> + associated with FD (which must be a controlling terminal, and still be >> + associated with its section. */ > > Missing close paren. Did you mean session? > > Andreas. > Ack and I did mean session, I fixed both thanks.