From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x33.google.com (mail-oa1-x33.google.com [IPv6:2001:4860:4864:20::33]) by sourceware.org (Postfix) with ESMTPS id B1BA63851514 for ; Fri, 28 Oct 2022 14:03:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B1BA63851514 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x33.google.com with SMTP id 586e51a60fabf-13ba86b5ac0so6411280fac.1 for ; Fri, 28 Oct 2022 07:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BtnwoP+ZnMCPBGtZJrM/96vpJwUo3z+oXFExgXYNEF4=; b=MrOe4s2OIRMS57ZiUDEJcEbOnGtomXB9lQE54l/x9p+3Sm5lmcIPno6cQgHHPZUsHv ooZJKKKsLwwL284z+7EsITVcee9pTwceWRxsTYrZyW4nOResITVA9UeLvRGrD52dvDIz 6AsxP89x2orlWE8mmVMgWgnLwrxBIM/JF9RxRtsIoVg+iOWYnbDqX5L/vUl9NOL+MK/j usl5pD2mAmMt8sPFy78LNnThVq79dQD1Ir9mteEuG+Bsv5iG2Wc156nPf4JGI4zEfr5H +1i5VAsML/zgiHwveakJAEn5J0P4Wl006Q5bbXgx+jS2GgRvOC5pFGCpN58V2GkIESPB X4pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BtnwoP+ZnMCPBGtZJrM/96vpJwUo3z+oXFExgXYNEF4=; b=A7BlmJDiJByoiHPQDxVVh/upnotdjLkGeUdyAfuiSZJ17DZd0RyTXmkiuZeQf+Kp12 iFlzLcvyz3YWMulesQkNMICsXyFiv+mlyxkv5uK46FUDwE1MoFvdKb8K4dnLV5BBvurl lkS9nO+dsYzKlvw0lHpRpmqem0TxgnUbMkRifgHg4iUsHrFszUxR6Bv/vt9uskOOei7M jD5QjSha7UYfjIq23q1Pf4twahdEQdeB6yD+GMHxaQjt9V9cM3cJUGJZ9eoVchWjswBO /L6nlWzas3Ow3pOTFiFhqT/d0dvXzYybvO35mHAsyH7+6oB6Wo0r9dOk6ZdzLsj+cHin T/uw== X-Gm-Message-State: ACrzQf26HON7KLnlpSanMoYkOqx7uiYiBqXqBkayJVlKaJfZoxxapln2 smPf5/Svv3u0H1EwDWZDxm/Pyg== X-Google-Smtp-Source: AMsMyM4DDR5KLXtPD5wVRR4vn2S1Ur446DbjKMOJZbnswpv+KVlxJkS8p8I5778GhkIodiUaom61fg== X-Received: by 2002:a05:6870:a713:b0:131:8f4f:b8ea with SMTP id g19-20020a056870a71300b001318f4fb8eamr8928301oam.138.1666965799877; Fri, 28 Oct 2022 07:03:19 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:607a:e74b:8f20:5e5b? ([2804:1b3:a7c0:17c8:607a:e74b:8f20:5e5b]) by smtp.gmail.com with ESMTPSA id r65-20020acaf344000000b00354948e04e4sm1534044oih.2.2022.10.28.07.03.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 07:03:19 -0700 (PDT) Message-ID: Date: Fri, 28 Oct 2022 11:03:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 04/20] aarch64: Fix the extension header write in getcontext and swapcontext Content-Language: en-US To: Szabolcs Nagy , libc-alpha@sourceware.org References: <4f72249e1bd2b5a772973f9faf3b88e62596fdde.1666877952.git.szabolcs.nagy@arm.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <4f72249e1bd2b5a772973f9faf3b88e62596fdde.1666877952.git.szabolcs.nagy@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/10/22 12:32, Szabolcs Nagy via Libc-alpha wrote: > The extension header is two 32bit words and in the last header both > should be 0. There is plenty space in the __reserved area, but it's > better not to write more than we mean to. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix/sysv/linux/aarch64/getcontext.S | 4 ++-- > sysdeps/unix/sysv/linux/aarch64/swapcontext.S | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/sysdeps/unix/sysv/linux/aarch64/getcontext.S b/sysdeps/unix/sysv/linux/aarch64/getcontext.S > index 15fbd2d1a0..3109cbd99a 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/getcontext.S > +++ b/sysdeps/unix/sysv/linux/aarch64/getcontext.S > @@ -86,8 +86,8 @@ ENTRY(__getcontext) > /* Write the termination context extension header. */ > add x2, x2, #FPSIMD_CONTEXT_SIZE > > - str xzr, [x2, #oHEAD + oMAGIC] > - str xzr, [x2, #oHEAD + oSIZE] > + str wzr, [x2, #oHEAD + oMAGIC] > + str wzr, [x2, #oHEAD + oSIZE] > > /* Grab the signal mask */ > /* rt_sigprocmask (SIG_BLOCK, NULL, &ucp->uc_sigmask, _NSIG8) */ > diff --git a/sysdeps/unix/sysv/linux/aarch64/swapcontext.S b/sysdeps/unix/sysv/linux/aarch64/swapcontext.S > index 1ee2e40272..e3ec9da35d 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/swapcontext.S > +++ b/sysdeps/unix/sysv/linux/aarch64/swapcontext.S > @@ -75,8 +75,8 @@ ENTRY(__swapcontext) > /* Write the termination context extension header. */ > add x2, x2, #FPSIMD_CONTEXT_SIZE > > - str xzr, [x2, #oHEAD + oMAGIC] > - str xzr, [x2, #oHEAD + oSIZE] > + str wzr, [x2, #oHEAD + oMAGIC] > + str wzr, [x2, #oHEAD + oSIZE] > > /* Preserve ucp. */ > mov x21, x1