From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id B38F23858C52 for ; Tue, 4 Apr 2023 19:40:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B38F23858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-17ebba88c60so35877950fac.3 for ; Tue, 04 Apr 2023 12:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680637239; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XtrdcxogpPD1/zsK0CEpC+jdXTSAZZtJ7T/0SAyOdWk=; b=lccIapIEILTj0XDvYPneyDY/2T/29xyEHsBo8PXg1TrisTh1xJKKkuco3xVrJUjR7r kzHTqIUu3lCuH09LVDQtHGoFflvZnh8lgA9+10i3W9R+LXuUM5ER3wjKG4W7QBgMuNYF RCFjFy7dTnAdU2/9MQhGf6iPmTGlB5QPqTadVulMdcIsnRq/oD32KB8ft1m60eRr14UH oJ1zizRGzgT3nX39UXxQHGwxoQK3afPR2jUrDTVR8XuWuFfUMhWYuwY6AeLGE3p3XZN/ pZ2uAjr9fYTQ2DC0594hAWL5hCGgq/zdjpqLZB46xCZ7/oYCJZAad3iagt4OKz6bKp21 KnNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680637239; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XtrdcxogpPD1/zsK0CEpC+jdXTSAZZtJ7T/0SAyOdWk=; b=p/m82c6W6dJEq6ZTN1+j54TWnz72z+V3Dknocufu1BfzJmja9VJlvQQu2zQm4BieH2 PGyXW0GKHpqxSxpxiIfCu7X8U7aSLJS2WFT0FkqyOX7cZwFwtMQtiYYgtMwQOpxsvTvt Z6175HB/d7IcXOLmQzQXCFiU6cTDgqiqrmploBNTpsdZDUiuPyPqZIqYShM4Zww1lX8k er2Fx2Cex908gMZ3rkkwSQqB8zOLgX/isFduglJb6dxZ0Eu+NZI+jzIcPHaokhZN9M6x zBBAVMnhmCxkQFKvruSuuqM/EeNEufwX1u9ESkMgegr/8l/px2rZ8u23Ui3GhOA5hpbI ICzw== X-Gm-Message-State: AAQBX9dur7hn/IEYC+tEDQSnXdpmpCyyZEjB19Uw8Dgqx7cn8OpLZdqQ 48qAZSowxD7tBzv/C2c7ubEL6eDxqozWvkP9qO3K6Q== X-Google-Smtp-Source: AKy350ZVQqo1t81UwCoRvX4rGlETEuJNON2ztx/7d2ayWaBfVqJWUHKKZdfgKPMWKsoAVgSIMZouzg== X-Received: by 2002:a05:6870:4799:b0:177:9789:b0ad with SMTP id c25-20020a056870479900b001779789b0admr124777oaq.22.1680637238899; Tue, 04 Apr 2023 12:40:38 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7? ([2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7]) by smtp.gmail.com with ESMTPSA id yi10-20020a05687c208a00b0017197629658sm5098015oab.56.2023.04.04.12.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 12:40:38 -0700 (PDT) Message-ID: Date: Tue, 4 Apr 2023 16:40:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 2/3] string: Add tests for strdup (BZ #30266) Content-Language: en-US To: libc-alpha@sourceware.org, Noah Goldstein References: <20230329150500.2886135-1-josimmon@redhat.com> <20230404190040.2507343-1-josimmon@redhat.com> <20230404190040.2507343-3-josimmon@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 04/04/23 16:17, Noah Goldstein via Libc-alpha wrote: > What about including test-strcpy and just creating macros for FREE? test-strcpy add extra complexity to handle ifunc and uses an external mmap buffer to check of OOB access, which for strdup does not add much.