public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>,
	Adhemerval Zanella <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org
Subject: Re: [PATCH] libio: Add small optimization on fmemopen
Date: Wed, 21 Sep 2016 18:47:00 -0000	[thread overview]
Message-ID: <f1657343-a97b-78d6-c941-2fd65c733b64@redhat.com> (raw)
In-Reply-To: <cf7a6ec8-17fe-18d7-13b7-1ffe9342c4cf@cs.ucla.edu>

On 09/21/2016 08:43 PM, Paul Eggert wrote:
> On 09/21/2016 11:26 AM, Adhemerval Zanella wrote:
>> my idea to use this workaround is
>> to avoid possible issues with faulty compilers.
>
> That's my thought as well. Although we can argue that the C standard,
> GCC, valgrind, etc. are all faulty, possibly the C standard etc. won't
> change (after all, there is a performance advantage to GCC's current
> behavior) and our code would continue to be over the edge.

We don't know the nature of the GCC issue, so we cannot work around it 
reliably.  The most likely explanation is that Address Sanitizer does 
not account for a valid GCC optimization.

Florian

  reply	other threads:[~2016-09-21 18:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-21 14:06 Adhemerval Zanella
2016-09-21 14:57 ` Florian Weimer
2016-09-21 18:18   ` Adhemerval Zanella
2016-09-21 17:22 ` Paul Eggert
2016-09-21 18:17   ` Adhemerval Zanella
2016-09-21 18:23     ` Florian Weimer
2016-09-21 18:26       ` Adhemerval Zanella
2016-09-21 18:43         ` Paul Eggert
2016-09-21 18:47           ` Florian Weimer [this message]
2016-09-21 18:57             ` Paul Eggert
2016-09-21 19:27               ` Florian Weimer
2016-09-21 20:16                 ` Adhemerval Zanella
2016-09-21 20:42                 ` Paul Eggert
2016-09-23  5:17           ` Ondřej Bílka
2016-09-23  5:34             ` Florian Weimer
2016-09-23 18:14               ` Ondřej Bílka
2016-09-23 20:38                 ` Florian Weimer
2016-09-23 18:29             ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1657343-a97b-78d6-c941-2fd65c733b64@redhat.com \
    --to=fweimer@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=eggert@cs.ucla.edu \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).