From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 1919838768AA for ; Wed, 13 Jul 2022 13:10:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1919838768AA Received: by mail-oi1-x230.google.com with SMTP id o133so14238484oig.13 for ; Wed, 13 Jul 2022 06:10:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=oQagSfd1GZgMvRgaPA75ujngPX2S51y58W85CbaUIiw=; b=srNPgtDt0PvVJ2iigyyfpt7wp5KHGCNzFCLcorCDhOHDIHduwAM9kzI5d4/P9LShBU SJaWIEoBa0vSBQDOgsccH0NCw5vHAS5Mtw484ztmr40tlbg4OZUkuuHf6oChx/lIXla3 1eXVRtWduZcY4ZqCX0DlBssxljHONmuU6Qw888gUhCxo8TbXV5GR/LtcYRKMTs/Phqg2 jyPogCNont1+vAWmPSM45QyWL4oG7wt3vm7hhoDb2yuBd2U+MyCxX3so6OeNsYPSixO5 1DkZ2zw4rC8pb7Xymo9kueYsGyl89UNW5v/9qef2tu4SPY8A7wMDVoHp9NOIWKeUC9tE pI1A== X-Gm-Message-State: AJIora+RTtFMqG1yWCCm67MPJlL21uZfz4Cg1bbZloR8EerEpmfDODzq 2Bw5kWQwuhkX3vKb+8pbQqCL3A== X-Google-Smtp-Source: AGRyM1sLixt7FqyLHNRdR65KeCp5jAqsfJc4pKP2y3Dd9EBagAYJMcvj8N/vqhiJ07qk7v4MS2hewg== X-Received: by 2002:a05:6808:18a:b0:339:c49d:29ac with SMTP id w10-20020a056808018a00b00339c49d29acmr4863600oic.120.1657717815244; Wed, 13 Jul 2022 06:10:15 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:19c3:4427:c171:4fa9:c3d9? ([2804:431:c7ca:19c3:4427:c171:4fa9:c3d9]) by smtp.gmail.com with ESMTPSA id q18-20020a9d6312000000b0061c4e836233sm3016167otk.8.2022.07.13.06.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 06:10:14 -0700 (PDT) Message-ID: Date: Wed, 13 Jul 2022 10:10:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v6 05/13] LoongArch: Thread-Local Storage Support Content-Language: en-US To: caiyinyu , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.or, joseph_myers@mentor.com References: <20220708065255.2316410-1-caiyinyu@loongson.cn> <20220708065255.2316410-6-caiyinyu@loongson.cn> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220708065255.2316410-6-caiyinyu@loongson.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 13:10:19 -0000 LGTM, thanks. Reviewed-by: Adhemerval Zanella On 08/07/22 03:52, caiyinyu wrote: > --- > sysdeps/loongarch/dl-tls.h | 46 +++++++++ > sysdeps/loongarch/libc-tls.c | 32 ++++++ > sysdeps/loongarch/nptl/tcb-offsets.sym | 6 ++ > sysdeps/loongarch/nptl/tls.h | 138 +++++++++++++++++++++++++ > sysdeps/loongarch/stackinfo.h | 33 ++++++ > 5 files changed, 255 insertions(+) > create mode 100644 sysdeps/loongarch/dl-tls.h > create mode 100644 sysdeps/loongarch/libc-tls.c > create mode 100644 sysdeps/loongarch/nptl/tcb-offsets.sym > create mode 100644 sysdeps/loongarch/nptl/tls.h > create mode 100644 sysdeps/loongarch/stackinfo.h > > diff --git a/sysdeps/loongarch/dl-tls.h b/sysdeps/loongarch/dl-tls.h > new file mode 100644 > index 0000000000..f82edcae76 > --- /dev/null > +++ b/sysdeps/loongarch/dl-tls.h > @@ -0,0 +1,46 @@ > +/* Thread-local storage handling in the ELF dynamic linker. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +/* Type used for the representation of TLS information in the GOT. */ > +typedef struct > +{ > + unsigned long int ti_module; > + unsigned long int ti_offset; > +} tls_index; > + > +/* The thread pointer points to the first static TLS block. */ > +#define TLS_TP_OFFSET 0 > + > +/* Dynamic thread vector pointers point to the start of each > + TLS block. */ > +#define TLS_DTV_OFFSET 0 > + > +/* Compute the value for a GOTTPREL reloc. */ > +#define TLS_TPREL_VALUE(sym_map, sym) \ > + ((sym_map)->l_tls_offset + (sym)->st_value - TLS_TP_OFFSET) > + > +/* Compute the value for a DTPREL reloc. */ > +#define TLS_DTPREL_VALUE(sym) ((sym)->st_value - TLS_DTV_OFFSET) > + > +extern void *__tls_get_addr (tls_index *ti); > + > +#define GET_ADDR_OFFSET (ti->ti_offset + TLS_DTV_OFFSET) > +#define __TLS_GET_ADDR(__ti) (__tls_get_addr (__ti) - TLS_DTV_OFFSET) > + > +/* Value used for dtv entries for which the allocation is delayed. */ > +#define TLS_DTV_UNALLOCATED ((void *) -1l) > diff --git a/sysdeps/loongarch/libc-tls.c b/sysdeps/loongarch/libc-tls.c > new file mode 100644 > index 0000000000..9285d11a7b > --- /dev/null > +++ b/sysdeps/loongarch/libc-tls.c > @@ -0,0 +1,32 @@ > +/* Thread-local storage handling in the ELF dynamic linker. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#include > +#include > + > +/* On LoongArch, linker optimizations are not required, so __tls_get_addr > + can be called even in statically linked binaries. In this case module > + must be always 1 and PT_TLS segment exist in the binary, otherwise it > + would not link. */ > + > +void * > +__tls_get_addr (tls_index *ti) > +{ > + dtv_t *dtv = THREAD_DTV (); > + return (char *) dtv[1].pointer.val + GET_ADDR_OFFSET; > +} > diff --git a/sysdeps/loongarch/nptl/tcb-offsets.sym b/sysdeps/loongarch/nptl/tcb-offsets.sym > new file mode 100644 > index 0000000000..7d0c7596e8 > --- /dev/null > +++ b/sysdeps/loongarch/nptl/tcb-offsets.sym > @@ -0,0 +1,6 @@ > +#include > +#include > + > +#define thread_offsetof(mem) (long)(offsetof (struct pthread, mem) - TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE) > + > +MULTIPLE_THREADS_OFFSET thread_offsetof (header.multiple_threads) > diff --git a/sysdeps/loongarch/nptl/tls.h b/sysdeps/loongarch/nptl/tls.h > new file mode 100644 > index 0000000000..f77265ae52 > --- /dev/null > +++ b/sysdeps/loongarch/nptl/tls.h > @@ -0,0 +1,138 @@ > +/* Definition for thread-local data handling. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +#ifndef _LOONGARCH_TLS_H > +#define _LOONGARCH_TLS_H 1 > + > +#include > + > +#ifndef __ASSEMBLER__ > +#include > +#include > +#include > +#include > + > +register void *__thread_self asm("$tp"); > +#define READ_THREAD_POINTER() ({ __thread_self; }) > + > +/* Get system call information. */ > +#include > + > +/* The TP points to the start of the thread blocks. */ > +#define TLS_DTV_AT_TP 1 > +#define TLS_TCB_AT_TP 0 > + > +/* Get the thread descriptor definition. */ > +#include > + > +typedef struct > +{ > + dtv_t *dtv; > + void *private; > +} tcbhead_t; > + > +/* This is the size of the initial TCB. Because our TCB is before the thread > + pointer, we don't need this. */ > +#define TLS_INIT_TCB_SIZE 0 > + > +/* Alignment requirements for the initial TCB. */ > +#define TLS_INIT_TCB_ALIGN __alignof__(struct pthread) > + > +/* This is the size of the TCB. Because our TCB is before the thread > + pointer, we don't need this. */ > +#define TLS_TCB_SIZE 0 > + > +/* Alignment requirements for the TCB. */ > +#define TLS_TCB_ALIGN __alignof__(struct pthread) > + > +/* This is the size we need before TCB - actually, it includes the TCB. */ > +#define TLS_PRE_TCB_SIZE \ > + (sizeof (struct pthread) \ > + + ((sizeof (tcbhead_t) + TLS_TCB_ALIGN - 1) & ~(TLS_TCB_ALIGN - 1))) > + > +/* The thread pointer tp points to the end of the TCB. > + The pthread_descr structure is immediately in front of the TCB. */ > +#define TLS_TCB_OFFSET 0 > + > +/* Install the dtv pointer. The pointer passed is to the element with > + index -1 which contain the length. */ > +#define INSTALL_DTV(tcbp, dtvp) (((tcbhead_t *) (tcbp))[-1].dtv = (dtvp) + 1) > + > +/* Install new dtv for current thread. */ > +#define INSTALL_NEW_DTV(dtv) (THREAD_DTV () = (dtv)) > + > +/* Return dtv of given thread descriptor. */ > +#define GET_DTV(tcbp) (((tcbhead_t *) (tcbp))[-1].dtv) > + > +/* Code to initially initialize the thread pointer. */ > +#define TLS_INIT_TP(tcbp) \ > + ({ \ > + __thread_self = (char *) tcbp + TLS_TCB_OFFSET; \ > + NULL; \ > + }) > + > +/* Return the address of the dtv for the current thread. */ > +#define THREAD_DTV() \ > + (((tcbhead_t *) (READ_THREAD_POINTER () - TLS_TCB_OFFSET))[-1].dtv) > + > +/* Return the thread descriptor for the current thread. */ > +#define THREAD_SELF \ > + ((struct pthread *) (READ_THREAD_POINTER () - TLS_TCB_OFFSET \ > + - TLS_PRE_TCB_SIZE)) > + > +/* Value passed to 'clone' for initialization of the thread register. */ > +#define TLS_DEFINE_INIT_TP(tp, pd) \ > + void *tp = (void *) (pd) + TLS_TCB_OFFSET + TLS_PRE_TCB_SIZE > + > +/* Informs libthread_db that the thread pointer is register 2, which is used > + * to know how to do THREAD_SELF. */ > +#define DB_THREAD_SELF \ > + REGISTER (64, 64, 2 * 8, -TLS_TCB_OFFSET - TLS_PRE_TCB_SIZE) > + > +/* Access to data in the thread descriptor is easy. */ > +# include > + > +/* l_tls_offset == 0 is perfectly valid, so we have to use some different > + value to mean unset l_tls_offset. */ > +#define NO_TLS_OFFSET -1 > + > +/* Get and set the global scope generation counter in struct pthread. */ > +#define THREAD_GSCOPE_IN_TCB 1 > +#define THREAD_GSCOPE_FLAG_UNUSED 0 > +#define THREAD_GSCOPE_FLAG_USED 1 > +#define THREAD_GSCOPE_FLAG_WAIT 2 > +#define THREAD_GSCOPE_RESET_FLAG() \ > + do \ > + { \ > + int __res = atomic_exchange_rel (&THREAD_SELF->header.gscope_flag, \ > + THREAD_GSCOPE_FLAG_UNUSED); \ > + if (__res == THREAD_GSCOPE_FLAG_WAIT) \ > + lll_futex_wake (&THREAD_SELF->header.gscope_flag, 1, LLL_PRIVATE); \ > + } \ > + while (0) > +#define THREAD_GSCOPE_SET_FLAG() \ > + do \ > + { \ > + THREAD_SELF->header.gscope_flag = THREAD_GSCOPE_FLAG_USED; \ > + atomic_write_barrier (); \ > + } \ > + while (0) > + > +#endif /* __ASSEMBLER__ */ > + > +#endif /* tls.h */ > diff --git a/sysdeps/loongarch/stackinfo.h b/sysdeps/loongarch/stackinfo.h > new file mode 100644 > index 0000000000..ff8b9b7bf2 > --- /dev/null > +++ b/sysdeps/loongarch/stackinfo.h > @@ -0,0 +1,33 @@ > +/* Stack environment definitions for LoongArch. > + Copyright (C) 2022 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library. If not, see > + . */ > + > +/* This file contains a bit of information about the stack allocation > + of the processor. */ > + > +#ifndef _STACKINFO_H > +#define _STACKINFO_H 1 > + > +#include > + > +/* On LoongArch the stack grows down. */ > +#define _STACK_GROWS_DOWN 1 > + > +/* Default to a non-executable stack. */ > +#define DEFAULT_STACK_PERMS (PF_R | PF_W) > + > +#endif /* stackinfo.h */