From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 74D2C3858D37 for ; Tue, 4 Aug 2020 23:54:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 74D2C3858D37 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-805JltZXPXeIRLQOWd0K9g-1; Tue, 04 Aug 2020 19:54:55 -0400 X-MC-Unique: 805JltZXPXeIRLQOWd0K9g-1 Received: by mail-qt1-f198.google.com with SMTP id d24so23114491qtg.23 for ; Tue, 04 Aug 2020 16:54:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dD4T4GoRKRBHQ5dRvnW5h1ehkSAyH5KTb5jHJinhFtI=; b=lNIzHGwG+MPT5L9XhRkhh7Y8WCB6I+oybafdM/NEMX+XQe2OiGYrsFUBfJ1Z1126iW vM8GOQf9jMwTWXVsIxHkAxJz9zj0+H7Ldhd1zFM/AMfgU8G8Yf4/PEwLxZ9iXiEz3f4C RsiumQWk8LpSpB8H+KGlYC4pHpYAwTCWRQNF75Rh4DesHm68fUs+i6Ilolndyw2UYJN5 s9du//8fnGUXci4qUCZwkIfm5aoBV2CbFMw869dVRJii0caMkh67pmCmt/fuuLuZKcnR JrFFZEZWLFcsb79e8g6uoTH/vG5G70J3MKikJaNMrsMilzaJZmyyZL/oUucCpCpfK/lu 7PVA== X-Gm-Message-State: AOAM532MY0Lu7Nvb+VCSvbZkCZNHPuQRfz+IQcQMXrOqawr2vW3ffaOY 0COHpS31xqoEWf5D5YkPEv2rSgpYCxSekXGL9bzASUzwzZxj1r178Rv+JHyZvNM7/P6/bTIEcWj UYiAL/J2HZp+kdqvt/AAn X-Received: by 2002:aed:34e2:: with SMTP id x89mr574622qtd.313.1596585295172; Tue, 04 Aug 2020 16:54:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZY2e1D35rT1nlc76Is37zsR/cqWhFYhtMPK01wKrBstFxYEQQty6Aehh+TfTztlCVe+D5ag== X-Received: by 2002:aed:34e2:: with SMTP id x89mr574613qtd.313.1596585294924; Tue, 04 Aug 2020 16:54:54 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id 205sm237921qkn.104.2020.08.04.16.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2020 16:54:54 -0700 (PDT) Subject: Re: Emit a warning when -z relro is unsupported From: Carlos O'Donell To: Florian Weimer , Alan Modra via Libc-alpha Cc: binutils@sourceware.org, Joseph Myers , Alan Modra References: <20200619024818.GA21885@bubble.grove.modra.org> <20200729003850.GO9601@bubble.grove.modra.org> <20200729071002.GP9601@bubble.grove.modra.org> <87eeounv93.fsf@oldenburg2.str.redhat.com> <20347cab-df22-79de-52bf-00ce5c4c7def@redhat.com> Organization: Red Hat Message-ID: Date: Tue, 4 Aug 2020 19:54:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20347cab-df22-79de-52bf-00ce5c4c7def@redhat.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2020 23:55:00 -0000 On 8/4/20 4:57 PM, Carlos O'Donell wrote: > On 7/29/20 12:25 PM, Florian Weimer via Libc-alpha wrote: >> * Alan Modra via Libc-alpha: >> >>> From 3425515f19d47eb2e13180fe031d94a9c13ce39b Mon Sep 17 00:00:00 2001 >>> From: Alan Modra >>> Date: Wed, 29 Jul 2020 16:28:57 +0930 >>> Subject: Don't mix linker error messages into edited scripts >>> >>> * Makerules (shlib.lds): Discard linker warning output. >>> (format.lds): Likewise. >>> >>> diff --git a/Makerules b/Makerules >>> index 341db86c7e..ef0fe67d9a 100644 >>> --- a/Makerules >>> +++ b/Makerules >>> @@ -557,7 +557,7 @@ $(common-objpfx)shlib.lds: $(common-objpfx)config.make $(..)Makerules >>> $(LINK.o) -shared -Wl,-O1 \ >>> -nostdlib -nostartfiles \ >>> $(sysdep-LDFLAGS) $(rtld-LDFLAGS) $(LDFLAGS.so) \ >>> - -Wl,--verbose 2>&1 | \ >>> + -Wl,--verbose 2>/dev/null | \ >>> sed > $@T \ >>> -e '/^=========/,/^=========/!d;/^=========/d' \ >>> $(if $(filter yes,$(have-hash-style)), \ >>> @@ -1073,7 +1073,7 @@ ifneq (unknown,$(output-format)) >>> else >>> $(LINK.o) -shared $(sysdep-LDFLAGS) $(rtld-LDFLAGS) \ >>> $(LDFLAGS.so) $(LDFLAGS-lib.so) \ >>> - -x c /dev/null -o $@.so -Wl,--verbose -v 2>&1 \ >>> + -x c /dev/null -o $@.so -Wl,--verbose -v 2>/dev/null \ >>> | sed -n -f $< > $@.new >>> test -s $@.new >>> rm -f $@.so >> >> This change looks reasonable to me. Thanks for tracking this down. >> >> We are in the glibc 2.32, so Carlos as the release manager needs to >> approve this. > > I'm testing this fix for inclusion today before I cut the branch. Fix looks good. I just pushed for glibc 2.32. Thanks Alan! Reviewed-by: Carlos O'Donell -- Cheers, Carlos.