From: Carlos O'Donell <carlos@redhat.com>
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
Subject: Re: Use __glibc_reserved convention in mcontext, sigcontext (bug 21457)
Date: Thu, 04 May 2017 02:25:00 -0000 [thread overview]
Message-ID: <f1ca5f1b-596c-8628-ab8a-edf994d46a43@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1705032243300.13632@digraph.polyomino.org.uk>
On 05/03/2017 06:43 PM, Joseph Myers wrote:
> This patch implements the most straightforward part of fixing
> namespace issues for sys/ucontext.h and related headers: where fields
> in sys/ucontext.h or bits/sigcontext.h are named "reserved", "padding"
> or similar, they are renamed to use the __glibc_reserved* naming
> convention. It does not change fields with a leading underscore, or
> even those with a prefix such as uc_ or sc_. It only fixes a small
> part of bug 21457, so no XFAILs are removed.
>
> Tested for x86_64 and x86, and with build-many-glibcs.py.
>
> 2017-05-03 Joseph Myers <joseph@codesourcery.com>
>
> [BZ #21457]
> * sysdeps/unix/sysv/linux/mips/sys/ucontext.h
> [_MIPS_SIM != _ABIO32] (mcontext_t): Rename field reserved to
> __glibc_reserved1.
> * sysdeps/unix/sysv/linux/x86/bits/sigcontext.h
> (struct _fpx_sw_bytes): Rename field padding to __glibc_reserved1.
> (struct _fpxreg): Likewise.
> [!__x86_64__] (struct _fpstate): Rename field reserved to
> __glibc_reserved1. Rename field padding to __glibc_reserved2.
> [__x86_64__] (struct _fpstate): Rename field padding to
> __glibc_reserved1.
> (struct _xsave_hdr): Rename field reserved1 to __glibc_reserved1.
> Rename field reserved2 to __glibc_reserved2.
> * sysdeps/unix/sysv/linux/x86/sys/ucontext.h
> [__x86_64__] (struct _libc_fpxreg): Rename field padding to
> __glibc_reserved1.
> [__x86_64__] (struct _libc_fpstate): Rename field padding to
> __glibc_reserved1.
OK.
I looked to see if gdb used any of the named reserved fields, or if any
other low-level program did, like strace, but I couldn't find any.
--
Cheers,
Carlos.
prev parent reply other threads:[~2017-05-04 2:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 22:43 Joseph Myers
2017-05-04 2:25 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1ca5f1b-596c-8628-ab8a-edf994d46a43@redhat.com \
--to=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).