From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9761 invoked by alias); 4 May 2017 02:25:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 9739 invoked by uid 89); 4 May 2017 02:25:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,URIBL_RED autolearn=no version=3.3.2 spammy=reserved X-HELO: mail-qt0-f171.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=iGCrGLNVP/pvMddUFeHYcWatryics3XX/kC44CHcxqQ=; b=LuvahiTW6ZeXGXG4cvQJe39igmYiCD3NI1ux9GlFMP/zIBqisfdXD2N72sluPYlty9 mgXwPvixSC5ODBJK96iDMpsGSqZ9a8qwvlVdzZkmvtBN/JTYMNsr5FfemVOJzBk0vIj5 eIwEr8gWNL3GTGg6pHFEhJhq3zX8lJgk9Act9bb3xZRexKNT0fsYaKhjAdDsWyh+IPuG nTq+jUGSGey4oS6il3c/RFnT1w19GRn+oQ4CWBpLKwYo90lYrQd09sWK+psVxiXyjr60 CMjZ0Kt3ngB1urhAZPX5CHtwmT4MTlXsCmjiy1AvcHCjgAxT/uXKoUt2m+y2fxxcKonv UM+Q== X-Gm-Message-State: AN3rC/6ZkhkS+dtY5RO3dmbcc+mlkjSeviv3oE8rsbZ9y/PGdMMv4c2c Y7jWFNDHVO76VdrJg7xtew== X-Received: by 10.200.57.37 with SMTP id s34mr5744626qtb.141.1493864747353; Wed, 03 May 2017 19:25:47 -0700 (PDT) Subject: Re: Use __glibc_reserved convention in mcontext, sigcontext (bug 21457) To: Joseph Myers , libc-alpha@sourceware.org References: From: Carlos O'Donell Message-ID: Date: Thu, 04 May 2017 02:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00078.txt.bz2 On 05/03/2017 06:43 PM, Joseph Myers wrote: > This patch implements the most straightforward part of fixing > namespace issues for sys/ucontext.h and related headers: where fields > in sys/ucontext.h or bits/sigcontext.h are named "reserved", "padding" > or similar, they are renamed to use the __glibc_reserved* naming > convention. It does not change fields with a leading underscore, or > even those with a prefix such as uc_ or sc_. It only fixes a small > part of bug 21457, so no XFAILs are removed. > > Tested for x86_64 and x86, and with build-many-glibcs.py. > > 2017-05-03 Joseph Myers > > [BZ #21457] > * sysdeps/unix/sysv/linux/mips/sys/ucontext.h > [_MIPS_SIM != _ABIO32] (mcontext_t): Rename field reserved to > __glibc_reserved1. > * sysdeps/unix/sysv/linux/x86/bits/sigcontext.h > (struct _fpx_sw_bytes): Rename field padding to __glibc_reserved1. > (struct _fpxreg): Likewise. > [!__x86_64__] (struct _fpstate): Rename field reserved to > __glibc_reserved1. Rename field padding to __glibc_reserved2. > [__x86_64__] (struct _fpstate): Rename field padding to > __glibc_reserved1. > (struct _xsave_hdr): Rename field reserved1 to __glibc_reserved1. > Rename field reserved2 to __glibc_reserved2. > * sysdeps/unix/sysv/linux/x86/sys/ucontext.h > [__x86_64__] (struct _libc_fpxreg): Rename field padding to > __glibc_reserved1. > [__x86_64__] (struct _libc_fpstate): Rename field padding to > __glibc_reserved1. OK. I looked to see if gdb used any of the named reserved fields, or if any other low-level program did, like strace, but I couldn't find any. -- Cheers, Carlos.