From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 6E60E3858CD1 for ; Wed, 26 Jul 2023 02:27:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6E60E3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690338422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KIL6Y1jXlsKcB8n+1BEA7Jdw6RHNW6Z4hqqGyLW6SgE=; b=KN/u1lRrSAi4DFOh+nmcE9paYa98EmtJctFkE9OAnbI+Y/FKnZo32d8xoaMIzzxACKIhCT L5C7tEPCEylgwv/wBgnJAYV3dTZ8cfdzo5vsdHgKMZWnuLJpEBpAyUHUkyRTmYO3g6JuSh 5q/0S7e0X1O1+2j/XhrpoOVluTD7eJ8= Received: from mail-yb1-f200.google.com (mail-yb1-f200.google.com [209.85.219.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-655-CFeMON6MPVS6K2YYfPEjEw-1; Tue, 25 Jul 2023 22:27:00 -0400 X-MC-Unique: CFeMON6MPVS6K2YYfPEjEw-1 Received: by mail-yb1-f200.google.com with SMTP id 3f1490d57ef6-d052f49702dso5602004276.3 for ; Tue, 25 Jul 2023 19:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690338420; x=1690943220; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KIL6Y1jXlsKcB8n+1BEA7Jdw6RHNW6Z4hqqGyLW6SgE=; b=fSUPfps2C5fa3yZDGyVFVBDxTNRG1k2tIWlwDaFawQhBj5PK852tKcCQlLgnEz1cju 87SjQUGigXQcY9CAccKJo9d5wiUsimSKeSX5Fkdh9cgR3xNAVAcZrEOoMOsoIMvGSEi0 XLndip3SjJtQJk4GyC40nDU4+Db5ZJDqvxo/SI1jDvzuCjgRXuaoSZ/k0npc5ltgbWgH Z3udmn8GeaoPI5Y4MpNUnXmXcXkjIoHMEWsz3ALYiM7ENPWAizQr2BjlV5cRofXIqYai dHY2PXgyO65DC/TvS+Llk6jMGuRyluhMNjSeebXAFYNKVvjSUc1ul/KBhFEvLPzHFlPB ErrA== X-Gm-Message-State: ABy/qLahKKJok8UrkBwjX1AITCq/fndIfpucKMUjsqkvBSt4wFCR4lmS j9m1ST2LzZj++K/tBd0AR8PL091zlLvp9T+Bto3MAwbVq0ARL+hX3NwOpwIPDHQLngSq1PmHPyK 1ScWqJ6eGCv7PEoyEqwU0LJ9n+sxx X-Received: by 2002:a25:804f:0:b0:d1c:77de:cf7a with SMTP id a15-20020a25804f000000b00d1c77decf7amr590320ybn.64.1690338420071; Tue, 25 Jul 2023 19:27:00 -0700 (PDT) X-Google-Smtp-Source: APBJJlF4WesAzzo6r6+01K7MGpNRLGvi0axV3C/qEWqSSyt0RPk3V8g2JF6EsItgROQr57Xq+0MJ1w== X-Received: by 2002:a25:804f:0:b0:d1c:77de:cf7a with SMTP id a15-20020a25804f000000b00d1c77decf7amr590316ybn.64.1690338419809; Tue, 25 Jul 2023 19:26:59 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id s13-20020a25aa0d000000b00caec634aaeasm1480890ybi.50.2023.07.25.19.26.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 19:26:59 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 22:26:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/3] malloc: Fix set-freeres.c with gcc 6 To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20230724171524.2687112-1-adhemerval.zanella@linaro.org> <20230724171524.2687112-2-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20230724171524.2687112-2-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 7/24/23 13:15, Adhemerval Zanella via Libc-alpha wrote: > Old GCC might trigger the the comparison will always evaluate as ‘true’ > warnig for static build: > > set-freeres.c:87:14: error: the comparison will always evaluate as > ‘true’ for the address of ‘__libc_getgrgid_freemem_ptr’ will never be > NULL [-Werror=address] > if (&__ptr != NULL) \ > > So add pragma weak for all affected usages. Agreed, if these work for older gcc we should put prama weak for them. LGTM. Reviewed-by: Carlos O'Donell > Checked on x86_64 and i686 with gcc 6 and 13. > --- > malloc/set-freeres.c | 46 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/malloc/set-freeres.c b/malloc/set-freeres.c > index 1aab34b586..41ef9c2dd6 100644 > --- a/malloc/set-freeres.c > +++ b/malloc/set-freeres.c > @@ -63,6 +63,52 @@ > # pragma weak __libpthread_freeres > # pragma weak __libc_dlerror_result_free > # pragma weak __check_pf_freemem > +# pragma weak __libc_fgetgrent_freemem_ptr > +# pragma weak __libc_fgetsgent_freeres_ptr > +# pragma weak __libc_getnetgrent_freemem_ptr > +# pragma weak __libc_rcmd_freemem_ptr > +# pragma weak __libc_rexec_freemem_ptr > +# pragma weak __libc_mntent_freemem_ptr > +# pragma weak __libc_fgetpwent_freemem_ptr > +# pragma weak __libc_getspent_freemem_ptr > +# pragma weak __libc_resolv_res_hconf_freemem_ptr > +# pragma weak __libc_fgetspent_freemem_ptr > +# pragma weak __libc_tzfile_freemem_ptr > +# pragma weak __libc_getnameinfo_freemem_ptr > +# pragma weak __libc_getutent_freemem_ptr > +# pragma weak __libc_getutid_freemem_ptr > +# pragma weak __libc_getutline_freemem_ptr > +# pragma weak __libc_reg_printf_freemem_ptr > +# pragma weak __libc_reg_type_freemem_ptr > +# pragma weak __libc_getgrgid_freemem_ptr > +# pragma weak __libc_getgrnam_freemem_ptr > +# pragma weak __libc_getpwnam_freemem_ptr > +# pragma weak __libc_getpwuid_freemem_ptr > +# pragma weak __libc_getspnam_freemem_ptr > +# pragma weak __libc_getaliasbyname_freemem_ptr > +# pragma weak __libc_gethostbyaddr_freemem_ptr > +# pragma weak __libc_gethostbyname_freemem_ptr > +# pragma weak __libc_gethostbyname2_freemem_ptr > +# pragma weak __libc_getnetbyaddr_freemem_ptr > +# pragma weak __libc_getnetbyname_freemem_ptr > +# pragma weak __libc_getprotobynumber_freemem_ptr > +# pragma weak __libc_getprotobyname_freemem_ptr > +# pragma weak __libc_getrpcbyname_freemem_ptr > +# pragma weak __libc_getrpcbynumber_freemem_ptr > +# pragma weak __libc_getservbyname_freemem_ptr > +# pragma weak __libc_getservbyport_freemem_ptr > +# pragma weak __libc_getgrent_freemem_ptr > +# pragma weak __libc_getpwent_freemem_ptr > +# pragma weak __libc_getaliasent_freemem_ptr > +# pragma weak __libc_gethostent_freemem_ptr > +# pragma weak __libc_getnetent_freemem_ptr > +# pragma weak __libc_getprotoent_freemem_ptr > +# pragma weak __libc_getrpcent_freemem_ptr > +# pragma weak __libc_getservent_freemem_ptr > +# pragma weak __libc_efgcvt_freemem_ptr > +# pragma weak __libc_qefgcvt_freemem_ptr > +# pragma weak __libc_qefgcvt_freemem_ptr > +# pragma weak __ttyname_freemem_ptr > #endif > > #ifdef SHARED -- Cheers, Carlos.