public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: daurnimator <quae@daurnimator.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH][BZ 21340] add support for POSIX_SPAWN_SETSID
Date: Mon, 03 Apr 2017 19:12:00 -0000	[thread overview]
Message-ID: <f2125c2c-342d-b4c0-44a4-8d075044fc2b@redhat.com> (raw)
In-Reply-To: <20170401142954.23142-1-quae@daurnimator.com>

On 04/01/2017 04:29 PM, daurnimator wrote:
> diff --git a/posix/spawn.h b/posix/spawn.h
> index 36e3867e17..8d2ace1b87 100644
> --- a/posix/spawn.h
> +++ b/posix/spawn.h
> @@ -60,6 +60,7 @@ typedef struct
>  #ifdef __USE_GNU
>  # define POSIX_SPAWN_USEVFORK		0x40
>  #endif
> +#define POSIX_SPAWN_SETSID		0x80
>

Doesn't this add the flag to past POSIX versions?

I'd prefer if there was a test case for the new functionality, perhaps 
using the getsid function.

I wonder if we should add a new symbol version for 
posix_spawnattr_setflags, so that applications which do not perform 
error checking for the function call fail in a predictable manner.

Thanks,
Florian

  parent reply	other threads:[~2017-04-03 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-01 14:30 daurnimator
2017-04-03 18:39 ` Adhemerval Zanella
2017-04-03 19:12 ` Florian Weimer [this message]
2017-04-03 19:35   ` Adhemerval Zanella
2017-04-04  9:38     ` Florian Weimer
2017-04-04 10:41       ` Szabolcs Nagy
2017-04-04 11:05         ` Florian Weimer
2017-04-05  3:47 ` Daurnimator

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2125c2c-342d-b4c0-44a4-8d075044fc2b@redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=quae@daurnimator.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).