From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buffalo.birch.relay.mailchannels.net (buffalo.birch.relay.mailchannels.net [23.83.209.24]) by sourceware.org (Postfix) with ESMTPS id 5574F3858039 for ; Fri, 18 Jun 2021 05:52:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5574F3858039 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id B10D1322850; Fri, 18 Jun 2021 05:52:03 +0000 (UTC) Received: from pdx1-sub0-mail-a91.g.dreamhost.com (100-101-162-60.trex.outbound.svc.cluster.local [100.101.162.60]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 52F14322804; Fri, 18 Jun 2021 05:52:03 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a91.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.101.162.60 (trex/6.3.3); Fri, 18 Jun 2021 05:52:03 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Scare-Keen: 0868e0c01c89cff5_1623995523556_4204590822 X-MC-Loop-Signature: 1623995523555:1895624319 X-MC-Ingress-Time: 1623995523555 Received: from pdx1-sub0-mail-a91.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTP id 102677E67C; Thu, 17 Jun 2021 22:52:03 -0700 (PDT) Received: from [192.168.1.126] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a91.g.dreamhost.com (Postfix) with ESMTPSA id B53ED7E3B8; Thu, 17 Jun 2021 22:52:00 -0700 (PDT) Subject: Re: [PATCH] malloc: Ensure that ptmalloc_init runs only once To: Florian Weimer Cc: Siddhesh Poyarekar via Libc-alpha References: <20210617103217.2633690-1-siddhesh@sourceware.org> <87a6no4l71.fsf@oldenburg.str.redhat.com> <68f4386f-9ae5-8791-31bf-7dcf14479847@sourceware.org> <87y2b7u3n5.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a91 From: Siddhesh Poyarekar Message-ID: Date: Fri, 18 Jun 2021 11:21:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <87y2b7u3n5.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3487.0 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 05:52:08 -0000 On 6/18/21 11:15 AM, Florian Weimer wrote: > There is no way to allocate a TCB for such foreign threads, and malloc > depends on the TCB, so this is not something that can work for > completely different reasons. That's a fair point, thanks for reviewing this. In that case, doesn't it make sense to simplify __malloc_initialized to a bool and have it set at ptmalloc_init entry? Siddhesh