* [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
@ 2020-08-28 16:55 Mark Wielaard
2020-08-28 18:03 ` Florian Weimer
0 siblings, 1 reply; 7+ messages in thread
From: Mark Wielaard @ 2020-08-28 16:55 UTC (permalink / raw)
To: libc-alpha; +Cc: Mark Wielaard
From: Mark Wielaard <mark@klomp.org>
Constants double checked against binutils and the ELF for the Arm 64-bit
Architecture (AArch64) Release 2020Q2 document.
---
elf/elf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/elf/elf.h b/elf/elf.h
index 197b557d15..ff9f1dadd5 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -2875,6 +2875,8 @@ enum
#define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */
/* AArch64 specific values for the Dyn d_tag field. */
+#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1)
+#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3)
#define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
#define DT_AARCH64_NUM 6
--
2.18.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-08-28 16:55 [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants Mark Wielaard
@ 2020-08-28 18:03 ` Florian Weimer
2020-08-28 18:47 ` Mark Wielaard
0 siblings, 1 reply; 7+ messages in thread
From: Florian Weimer @ 2020-08-28 18:03 UTC (permalink / raw)
To: Mark Wielaard via Libc-alpha; +Cc: Mark Wielaard, Mark Wielaard
* Mark Wielaard via Libc-alpha:
> From: Mark Wielaard <mark@klomp.org>
>
> Constants double checked against binutils and the ELF for the Arm 64-bit
> Architecture (AArch64) Release 2020Q2 document.
> ---
> elf/elf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 197b557d15..ff9f1dadd5 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -2875,6 +2875,8 @@ enum
> #define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */
>
> /* AArch64 specific values for the Dyn d_tag field. */
> +#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1)
> +#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3)
> #define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
> #define DT_AARCH64_NUM 6
I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that in
the commit message? There's no PAC PLT with glibc, and people are
expected to use BIND_NOW.
(I hope I remember this correctly.)
Thanks,
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-08-28 18:03 ` Florian Weimer
@ 2020-08-28 18:47 ` Mark Wielaard
2020-08-28 19:04 ` Florian Weimer
0 siblings, 1 reply; 7+ messages in thread
From: Mark Wielaard @ 2020-08-28 18:47 UTC (permalink / raw)
To: Florian Weimer, Libc-alpha
[-- Attachment #1: Type: text/plain, Size: 318 bytes --]
Hi Florian,
On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote:
> I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that
> in the commit message? There's no PAC PLT with glibc, and people are
> expected to use BIND_NOW.
OK, how about with the attached commit message?
Thanks,
Mark
[-- Attachment #2: 0001-elf.h-Add-aarch64-bti-pac-dynamic-tag-constants.patch --]
[-- Type: text/x-patch, Size: 927 bytes --]
From 3b925f004607cebc167af907c053bd7ef7146a3b Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 28 Aug 2020 18:44:16 +0200
Subject: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
Constants double checked against binutils and the ELF for the Arm 64-bit
Architecture (AArch64) Release 2020Q2 document.
Only BTI PLT is used in glibc, there's no PAC PLT with glibc, and people
are expected to use BIND_NOW.
---
elf/elf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/elf/elf.h b/elf/elf.h
index 197b557d15..ff9f1dadd5 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -2875,6 +2875,8 @@ enum
#define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */
/* AArch64 specific values for the Dyn d_tag field. */
+#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1)
+#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3)
#define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
#define DT_AARCH64_NUM 6
--
2.18.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-08-28 18:47 ` Mark Wielaard
@ 2020-08-28 19:04 ` Florian Weimer
2020-09-02 11:28 ` Mark Wielaard
0 siblings, 1 reply; 7+ messages in thread
From: Florian Weimer @ 2020-08-28 19:04 UTC (permalink / raw)
To: Mark Wielaard; +Cc: Libc-alpha
* Mark Wielaard:
> Hi Florian,
>
> On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote:
>> I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned that
>> in the commit message? There's no PAC PLT with glibc, and people are
>> expected to use BIND_NOW.
>
> OK, how about with the attached commit message?
Yes, this is what I had in mind, but please wait for an ack from an
AArch64 maintainer.
Thanks,
Florian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-08-28 19:04 ` Florian Weimer
@ 2020-09-02 11:28 ` Mark Wielaard
2020-09-06 20:21 ` Szabolcs Nagy
0 siblings, 1 reply; 7+ messages in thread
From: Mark Wielaard @ 2020-09-02 11:28 UTC (permalink / raw)
To: Florian Weimer; +Cc: Libc-alpha
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote:
> * Mark Wielaard:
> > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote:
> > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned
> > > that
> > > in the commit message? There's no PAC PLT with glibc, and people
> > > are
> > > expected to use BIND_NOW.
> >
> > OK, how about with the attached commit message?
>
> Yes, this is what I had in mind, but please wait for an ack from an
> AArch64 maintainer.
OK. Ping. Any AArch64 maintainer want to ack or nack this commit?
Thanks,
Mark
[-- Attachment #2: 0001-elf.h-Add-aarch64-bti-pac-dynamic-tag-constants.patch --]
[-- Type: text/x-patch, Size: 927 bytes --]
From 3b925f004607cebc167af907c053bd7ef7146a3b Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mark@klomp.org>
Date: Fri, 28 Aug 2020 18:44:16 +0200
Subject: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
Constants double checked against binutils and the ELF for the Arm 64-bit
Architecture (AArch64) Release 2020Q2 document.
Only BTI PLT is used in glibc, there's no PAC PLT with glibc, and people
are expected to use BIND_NOW.
---
elf/elf.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/elf/elf.h b/elf/elf.h
index 197b557d15..ff9f1dadd5 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -2875,6 +2875,8 @@ enum
#define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */
/* AArch64 specific values for the Dyn d_tag field. */
+#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1)
+#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3)
#define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
#define DT_AARCH64_NUM 6
--
2.18.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-09-02 11:28 ` Mark Wielaard
@ 2020-09-06 20:21 ` Szabolcs Nagy
2020-09-07 7:22 ` Mark Wielaard
0 siblings, 1 reply; 7+ messages in thread
From: Szabolcs Nagy @ 2020-09-06 20:21 UTC (permalink / raw)
To: Mark Wielaard; +Cc: Florian Weimer, Libc-alpha
* Mark Wielaard <mark@klomp.org> [2020-09-02 13:28:02 +0200]:
> On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote:
> > * Mark Wielaard:
> > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote:
> > > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned
> > > > that
> > > > in the commit message? There's no PAC PLT with glibc, and people
> > > > are
> > > > expected to use BIND_NOW.
> > >
> > > OK, how about with the attached commit message?
> >
> > Yes, this is what I had in mind, but please wait for an ack from an
> > AArch64 maintainer.
>
> OK. Ping. Any AArch64 maintainer want to ack or nack this commit?
i'm on a long holiday, i will be back on sept 21.
the patch looks good, but i wont use my @arm.com
email until i'm back.
>
> Thanks,
>
> Mark
> From 3b925f004607cebc167af907c053bd7ef7146a3b Mon Sep 17 00:00:00 2001
> From: Mark Wielaard <mark@klomp.org>
> Date: Fri, 28 Aug 2020 18:44:16 +0200
> Subject: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
>
> Constants double checked against binutils and the ELF for the Arm 64-bit
> Architecture (AArch64) Release 2020Q2 document.
>
> Only BTI PLT is used in glibc, there's no PAC PLT with glibc, and people
> are expected to use BIND_NOW.
> ---
> elf/elf.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/elf/elf.h b/elf/elf.h
> index 197b557d15..ff9f1dadd5 100644
> --- a/elf/elf.h
> +++ b/elf/elf.h
> @@ -2875,6 +2875,8 @@ enum
> #define R_AARCH64_IRELATIVE 1032 /* STT_GNU_IFUNC relocation. */
>
> /* AArch64 specific values for the Dyn d_tag field. */
> +#define DT_AARCH64_BTI_PLT (DT_LOPROC + 1)
> +#define DT_AARCH64_PAC_PLT (DT_LOPROC + 3)
> #define DT_AARCH64_VARIANT_PCS (DT_LOPROC + 5)
> #define DT_AARCH64_NUM 6
>
> --
> 2.18.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants
2020-09-06 20:21 ` Szabolcs Nagy
@ 2020-09-07 7:22 ` Mark Wielaard
0 siblings, 0 replies; 7+ messages in thread
From: Mark Wielaard @ 2020-09-07 7:22 UTC (permalink / raw)
To: Szabolcs Nagy; +Cc: Florian Weimer, Libc-alpha
On Sun, 2020-09-06 at 22:21 +0200, Szabolcs Nagy wrote:
> * Mark Wielaard <mark@klomp.org> [2020-09-02 13:28:02 +0200]:
> > On Fri, 2020-08-28 at 21:04 +0200, Florian Weimer wrote:
> > > * Mark Wielaard:
> > > > On Fri, 2020-08-28 at 20:03 +0200, Florian Weimer wrote:
> > > > > I think DT_AARCH64_PAC_PLT isn't really used, so maybe mentioned
> > > > > that in the commit message? There's no PAC PLT with glibc, and
> > > > > people are expected to use BIND_NOW.
> > > >
> > > > OK, how about with the attached commit message?
> > >
> > > Yes, this is what I had in mind, but please wait for an ack from an
> > > AArch64 maintainer.
> >
> > OK. Ping. Any AArch64 maintainer want to ack or nack this commit?
>
> i'm on a long holiday, i will be back on sept 21.
>
> the patch looks good
Thanks pushed. Have a nice holiday.
Cheers,
Mark
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-09-07 7:23 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-28 16:55 [PATCH] elf.h: Add aarch64 bti/pac dynamic tag constants Mark Wielaard
2020-08-28 18:03 ` Florian Weimer
2020-08-28 18:47 ` Mark Wielaard
2020-08-28 19:04 ` Florian Weimer
2020-09-02 11:28 ` Mark Wielaard
2020-09-06 20:21 ` Szabolcs Nagy
2020-09-07 7:22 ` Mark Wielaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).