public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
	"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH 1/6] Remove slow paths from sin/cos
Date: Fri, 09 Mar 2018 15:54:00 -0000	[thread overview]
Message-ID: <f25a5854-e32d-37b4-ded5-d650c973231f@gotplt.org> (raw)
In-Reply-To: <DB6PR0801MB2053AD9AD20C0A43F628239683DE0@DB6PR0801MB2053.eurprd08.prod.outlook.com>

On Friday 09 March 2018 09:14 PM, Wilco Dijkstra wrote:
> This series of patches removes the slow patchs from sin, cos and sincos.
> Besides greatly simplifying the implementation, the new version is also much
> faster for inputs up to PI (41% faster) and for large inputs needing range
> reduction (27% faster).
> 
> ULP is ~0.55 with no errors found after testing 1.6 billion inputs across most
> of the range with mpsin and mpcos.  The number of incorrectly rounded results
> (ie. ULP >0.5) is at most ~2750 per million inputs between 0.125 and 0.5,
> the average is ~850 per million between 0 and PI.
> 
> Tested on AArch64 and x86_64 with no regressions.
> 
> The first patch removes the slow paths for the cases where the input is small
> and doesn't require range reduction.  Update ULP tables for sin, cos and sincos
> on AArch64 and x86_64.

Please drop the mp benchtests as well (the ##name:768bits namespaces).
A separate pre-approved patch to simply drop that name line is
sufficient once these slow paths are removed.

Siddhesh

  reply	other threads:[~2018-03-09 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 15:44 Wilco Dijkstra
2018-03-09 15:54 ` Siddhesh Poyarekar [this message]
2018-03-09 16:20   ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25a5854-e32d-37b4-ded5-d650c973231f@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).