From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id 31247399BC0C for ; Wed, 9 Jun 2021 17:06:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31247399BC0C Received: by mail-qk1-x72c.google.com with SMTP id c138so11505004qkg.5 for ; Wed, 09 Jun 2021 10:06:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XkOBAO6PZh1+ohitweu3/O4CIzJwO6ldo1XljBbrfvc=; b=VoEocm7N/jHU8ObzQqLUtBjA/txYi4mAMNBgxtsekpS8C43O1fC4JwROl0msU7FSSa qC1LERix38/LLw4tYEsTAm5L+JGv25BDFa5dvdbINcYKq+5gmKo7x1PYmr6mxfKOXh0P zCpsleIES2pP4o9U6eeBtL0Q03u7//mBxnK5xamuAaFkifoQ5HZfnno4d+xws8Tlf6EL ly+q/RwmFFihGhn79m/m/sWuo8IPl9iQBXCK5pL9v+0mU77gge/8VAeU/XNNx4Kbeww6 ZrZ5ubKHcfVLtgV7rSCG+QdihtbCIoMPl5Nt1GPayROAsVsSwwRDTmb0vxBP2YdSy7EO v3dw== X-Gm-Message-State: AOAM533MXMHojm+L8jHl5uN3KnaZHFC2A5J08O3fFkeYWCrmblir66Bc TuEyAyVyFPIrKGQLfxIQsPY1QeSd0xekkQ== X-Google-Smtp-Source: ABdhPJxW7WPhgJjTmb/wUhABUu177CrDV6GLsdOmv+4FR9hyLGAgdmgcuU4T89Wlo7FoNsP4fjWveg== X-Received: by 2002:a37:390:: with SMTP id 138mr621930qkd.5.1623258379574; Wed, 09 Jun 2021 10:06:19 -0700 (PDT) Received: from [192.168.1.4] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id u123sm397565qkh.83.2021.06.09.10.06.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Jun 2021 10:06:19 -0700 (PDT) Subject: Re: [PATCH v2 6/9] nptl: Move cancel type out of cancelhandling From: Adhemerval Zanella To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210527172823.3461314-1-adhemerval.zanella@linaro.org> <20210527172823.3461314-7-adhemerval.zanella@linaro.org> <87o8cp69rt.fsf@oldenburg.str.redhat.com> <4344d96f-8477-fcf6-f6d9-6615985193d0@linaro.org> Message-ID: Date: Wed, 9 Jun 2021 14:06:16 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <4344d96f-8477-fcf6-f6d9-6615985193d0@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jun 2021 17:06:21 -0000 On 02/06/2021 10:11, Adhemerval Zanella wrote: > > > On 01/06/2021 09:37, Florian Weimer wrote: >> * Adhemerval Zanella via Libc-alpha: >> >>> Now that the thread cancellation type is not accessed concurrently >>> anymore, it is possible to move it out the cancelhandling. >>> >>> By removing the cancel state out of the internal thread cancel handling >>> state there is no need to check if cancelled bit was set in CAS >>> operation. >>> >>> It allows simplifing the cancellation wrappers and the >>> CANCEL_CANCELED_AND_ASYNCHRONOUS is removed. >> >> Patch looks okay to me. Maybe this should be merged with the other >> patch that changes the cancel state handling. > > I don't have a strong preference, I split just to make easier to review > and see the logical changes. I will merge when commit then. > In fact merging will result in a larger, which might be harder for a reader (and there is no direct gain in doing so). I will keep the change in two patches.