From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) by sourceware.org (Postfix) with ESMTPS id F3F953835837 for ; Fri, 18 Jun 2021 18:50:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3F953835837 Received: by mail-qv1-xf2d.google.com with SMTP id c10so4072532qvo.9 for ; Fri, 18 Jun 2021 11:50:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Quhvc0oCrL8hnySr36IdGBBFir+jWPJxBxaIt050NtA=; b=YHtVo62DdVfvectGw30EhJJJwlcPYNTpRXyDQXj0aYgzGBo+NpbrdupZSIqlY5YFxb +CxQmi3XLaFOPo2v+ho7fRNMxGtQo8Fe4MHMaRg+qfATrD7G9zzjpGLx9eN7EWt8tA/P tpZnwoJg+ZjSzO1fx+Jx6jzRsJPTJynrExBBe0/TDB2hT7Op+nj+1ZPLARzhWEMYcC2+ pULBABown75WHWVwgFTGaSf1cUzzqJ2+YXQ5GY8z/Gh2soFF27AE6rPq5dj5p5toWV1L k4SQOXt72H1Y5nRGbxevPwtOJSUPeDqVlQrpr8wyKUA7tdUpJBE0hH4tUhn9pldxPY9P 1tkw== X-Gm-Message-State: AOAM532diY2h06Yx6DU2kpb27gZ/TLxGb1Oy7qJ35u7xhbegUiuwVTmP Ku44THHUNjwTAAvq5BbHSoqA/A== X-Google-Smtp-Source: ABdhPJy9BiNFsiU56093zuXZ6s+tgAXLoOe3cmBrhXzfp3ADf5OPmswhdKCS3vTp2bB6Hq7xKR0khQ== X-Received: by 2002:a0c:fdc5:: with SMTP id g5mr7118499qvs.15.1624042248505; Fri, 18 Jun 2021 11:50:48 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id w195sm4567776qkb.127.2021.06.18.11.50.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 11:50:48 -0700 (PDT) Subject: Re: [PATCH 02/18] Use LFS and 64 bit time for installed programs To: Andreas Schwab , Adhemerval Zanella via Libc-alpha References: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> <20210617115104.1359598-3-adhemerval.zanella@linaro.org> <87fsxgn0nr.fsf@igel.home> From: Adhemerval Zanella Message-ID: Date: Fri, 18 Jun 2021 15:50:45 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <87fsxgn0nr.fsf@igel.home> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 18:50:50 -0000 On 17/06/2021 09:19, Andreas Schwab wrote: > On Jun 17 2021, Adhemerval Zanella via Libc-alpha wrote: > >> diff --git a/Makeconfig b/Makeconfig >> index 6482a43025..de30ba3fa6 100644 >> --- a/Makeconfig >> +++ b/Makeconfig >> @@ -851,6 +851,10 @@ endif >> # -fno-math-errno. >> +extra-math-flags = $(if $(filter libm,$(in-module)),-fno-math-errno,-fmath-errno) >> >> +# Use 64 bit time_t support for installed programs >> ++extra-time-flags = $(if $(filter nonlib nscd lddlibc4 ldconfig locale_programs iconvprogs,\ > > I'd suggest to put the list of module names in a variable, to make it > easier to shorten the line. I will add it. > >> diff --git a/Makerules b/Makerules >> index 12f1a5cb50..770a573134 100644 >> --- a/Makerules >> +++ b/Makerules >> @@ -1313,14 +1313,22 @@ lib := testsuite >> include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left)) >> endif >> >> -all-nonlib := $(strip $(tests-internal) $(test-internal-extras) \ >> - $(others) $(others-extras)) >> +all-nonlib := $(strip $(others) $(others-extras)) >> ifneq (,$(all-nonlib)) >> cpp-srcs-left = $(all-nonlib) >> lib := nonlib >> include $(patsubst %,$(..)libof-iterator.mk,$(cpp-srcs-left)) >> endif >> >> +# All internal tests use testsuite-internal module since for 64 bit time >> +# support is set as default for MODULE_NAME=nonlib (which include some >> +# installed programs. > > Missing close paren. Ack. > >> diff --git a/locale/localeinfo.h b/locale/localeinfo.h >> index b3d4da0185..9e53681829 100644 >> --- a/locale/localeinfo.h >> +++ b/locale/localeinfo.h >> @@ -50,7 +50,7 @@ struct __locale_data >> { >> const char *name; >> const char *filedata; /* Region mapping the file data. */ >> - off_t filesize; /* Size of the file (and the region). */ >> + __off_t filesize; /* Size of the file (and the region). */ > > Why is that needed? It is a leftover from development, I will remove it.