From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by sourceware.org (Postfix) with ESMTPS id 7580F3857C4C for ; Mon, 5 Apr 2021 11:03:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7580F3857C4C Received: by mail-wm1-x32f.google.com with SMTP id f22-20020a7bc8d60000b029010c024a1407so7407719wml.2 for ; Mon, 05 Apr 2021 04:03:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:cc:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=JAFKMTH0MxDWPWNpxB3FligJ6QOIJ7RnO+l28PHZzuk=; b=eE9zgFf+4+RLwAhtgPXBgHe38KuJjcFV1yjrZn0cGfRTfV9GDvtgS9Ol11GQuJCzaV HAorQ2Lt2WjWInTltRrv+pcGxBdgMc9KOt+v2SgjFnHUQAGNOJKGo5Eq9GJYbHcq7IL0 0kCRIkHyYMjgfkNLg+OFQpSobYF8m2PCsoQitEj84PNDMG2hm6PE4ev6pRD/a8Lx7PfD F49dnxA3cijpIao3nEQ9+x/2Nvr0HJ/ViJOQtxOe+1uUJ8iPDwkQzd9TqkwTAlJhX2T2 kujL8GOpJkTgKdHlCDHrlEai1ACBGHTVbfb+rzw0t3kuzjsVo9JbblsA97q96xJSEMNR fVcg== X-Gm-Message-State: AOAM532WFln5juTQ1HD/vOfQZizko+VNYtQkqaQ4+YbPDcC338fMWZph cl9/67A3/lR5pg6xlulAxwyRq7ltrpw= X-Google-Smtp-Source: ABdhPJy/yskE/UcRi3EZmgczQutQluA1/lIa/H9PLgqZXaw97gSOLjpKzbR5vqdPKxKPrbc9bnX6sQ== X-Received: by 2002:a7b:cb05:: with SMTP id u5mr1380468wmj.183.1617620580352; Mon, 05 Apr 2021 04:03:00 -0700 (PDT) Received: from ?IPv6:2001:a61:2553:a401:cfc6:2039:a9ec:21ff? ([2001:a61:2553:a401:cfc6:2039:a9ec:21ff]) by smtp.gmail.com with ESMTPSA id b15sm27349617wrx.73.2021.04.05.04.02.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Apr 2021 04:02:59 -0700 (PDT) Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, libc-alpha@sourceware.org Subject: Re: [PATCH v5 29/35] ioctl_fat.2: Make clear why is each header exactly needed. To: Alejandro Colomar References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-30-alx.manpages@gmail.com> From: "Michael Kerrisk (man-pages)" Message-ID: Date: Mon, 5 Apr 2021 13:02:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210404115847.78166-30-alx.manpages@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Apr 2021 11:03:02 -0000 Hi Alex, On 4/4/21 1:58 PM, Alejandro Colomar wrote: > Only the one that provides the prototype doesn't need a comment. > > Signed-off-by: Alejandro Colomar > --- > man2/ioctl_fat.2 | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/man2/ioctl_fat.2 b/man2/ioctl_fat.2 > index 30e410280..263738dad 100644 > --- a/man2/ioctl_fat.2 > +++ b/man2/ioctl_fat.2 > @@ -26,6 +26,7 @@ > ioctl_fat \- manipulating the FAT filesystem > .SH SYNOPSIS > .nf > +.RB " /* Definition of [" V ] FAT_* " and " ATTR_* " constants */" > .B #include > .B #include > .PP Patch applied. But, I reformatted in a manner more typical of what I normally write. See my follow-on commit. Thanks, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/