From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xi Ruoyao <xry111@xry111.site>,
Viktor Reznov <yann.collet.is.not.a.perfectionist@gmail.com>,
Carlos O'Donell <carlos@redhat.com>,
libc-alpha@sourceware.org
Subject: Re: [PATCH] Halving the number of recursive calls
Date: Tue, 14 May 2024 11:14:15 +0200 [thread overview]
Message-ID: <f34a94ad-c304-432d-bdbc-263112695154@linaro.org> (raw)
In-Reply-To: <2608026cbd3b9624dfa0d925cb59df61ac176492.camel@xry111.site>
On 14/05/24 08:08, Xi Ruoyao wrote:
> On Tue, 2024-05-14 at 08:27 +0300, Viktor Reznov wrote:
>> On Mon, May 13, 2024 at 5:14 PM Carlos O'Donell <carlos@redhat.com>
>> wrote:
>>> Lastly, How did you test the performance gains?
>>> Does this change show up visibly in a microbenchmark or workload?
>>
>> Even if a compiler is capable of doing "partial inlining", it is
>> better to do this inlining manually.
>
> No, in Glibc if we are pretty sure the compiler will optimize it, we
> don't optimize it manually.
>
> It's not really "better" unless a not-so-old GCC or Clang fails to
> optimize it, *and* the optimization really makes it faster for
> microbenchmark or workload.
>
Kuan-Wei sent a similar optimization some time ago [1], which I
complete forgot to install. My plan is to re-run some tests and
apply, so how this patch compare to Kuan's change?
[1] https://sourceware.org/pipermail/libc-alpha/2024-March/155648.html
prev parent reply other threads:[~2024-05-14 9:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 2:40 Viktor Reznov
2024-05-13 14:04 ` Carlos O'Donell
2024-05-14 5:27 ` Viktor Reznov
2024-05-14 6:08 ` Xi Ruoyao
2024-05-14 9:14 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f34a94ad-c304-432d-bdbc-263112695154@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=xry111@xry111.site \
--cc=yann.collet.is.not.a.perfectionist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).