From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa2f.google.com (mail-vk1-xa2f.google.com [IPv6:2607:f8b0:4864:20::a2f]) by sourceware.org (Postfix) with ESMTPS id B709E3858299 for ; Mon, 3 Oct 2022 16:52:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B709E3858299 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vk1-xa2f.google.com with SMTP id s76so1692913vke.11 for ; Mon, 03 Oct 2022 09:52:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=SoFRxvDawuEjStW02t4/Mii8DHyn4RD/nSPvxMwYsto=; b=xTGPglXjTAvrVrLYlpp2VhdaVyfnu4ap9eN2O1Fxu0ipurr0jiKUkwBF0/gixj7tzh /pSxa9revjQJhx5MjLnhJReErqnMvWnVu81wKcuh7cl07QlccaqfBNFcvOWKM33OHZ4i fcGwtUgSvk240NNeWs+4OZJ5jHwbp99EcON8LwM6exZ9FHOuVU4CBGqlzEDVvyD3OHc/ uxeAZePK2xm+eYCGjOky4qXr2MDDTWWdSbWE4rVBIPSrgsJkeCdScmpfLc+CCxLJWSYv 7ZXygng8g9DyZjwXj2xv3Yxf7NON319faDo6JSqNBW8RV8b6BPdAw5lwXNEoKdhulla0 jerg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=SoFRxvDawuEjStW02t4/Mii8DHyn4RD/nSPvxMwYsto=; b=OrzH9bDhUHEF3RhTN3uie3h1Y0qPrK+p1GwvJvdOG//WC0xx6DcIxNBKSphYvtedaD ELfjvr+FYv2ZbJq7VTkUNScVmRRXJT1AIi658H/+Y0Lo8aJV2ga7ywu92HTS2BrPECId Vo2Kq8uwp8YQsnBdZryJuhfwzeyslCata0Yi7YszSRpVpP/jPbY43vSxA4nSP9qXki9G 65bwhOykZBmBXwdzyfQ0mzSPG4bw0Ltj+vsuIf68CQnXlOBh/j61CS3e1na/Xm118a1f VQUchmUBneCXI6905SOWMw4smftp9/qHwA3ic0RPmF1zMEpSwRCODQwKfZqduawnfdR1 oe+g== X-Gm-Message-State: ACrzQf0ughJ24HdC4MI9dUI8Dh4xWL/FhxFoleTjiW8JR844ruD2vQ1q fEL/+SDjzewaLZw1O8w023HKeg== X-Google-Smtp-Source: AMsMyM4TWDJki592lAR6M54S+zvWbdtrzmXr85z6DLeZJLioVjGxI8DqdMnWK3fcM54Lq1XzviVt7g== X-Received: by 2002:a1f:5243:0:b0:3a4:a4e9:417c with SMTP id g64-20020a1f5243000000b003a4a4e9417cmr9897458vkb.16.1664815954907; Mon, 03 Oct 2022 09:52:34 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:b87d:f936:fc03:6bdb:fa59? ([2804:1b3:a7c2:b87d:f936:fc03:6bdb:fa59]) by smtp.gmail.com with ESMTPSA id c17-20020ab07a71000000b003d235702cdesm7822195uat.8.2022.10.03.09.52.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Oct 2022 09:52:34 -0700 (PDT) Message-ID: Date: Mon, 3 Oct 2022 13:52:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 7/8] elf: Remove _dl_string_hwcap Content-Language: en-US To: Javier Pello , libc-alpha@sourceware.org References: <20220905200652.d69204581d15c64647da5cd2@otheo.eu> <87h71l9crb.fsf@oldenburg.str.redhat.com> <20220906201207.e7b3d08272af5649754e76b1@otheo.eu> <87h71i6rfa.fsf@oldenburg.str.redhat.com> <20220914200724.8e685fbbaf441c96d19011c6@otheo.eu> <20220917161748.2b76e1731a27eb78880ee57c@otheo.eu> <20220927200352.0424a12908a437fef9d3a7bc@otheo.eu> <20220927200928.c8ad6f420801d92476faa865@otheo.eu> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20220927200928.c8ad6f420801d92476faa865@otheo.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/09/22 15:09, Javier Pello wrote: > Removal of legacy hwcaps support from the dynamic loader left > no users of _dl_string_hwcap. > > Signed-off-by: Javier Pello LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > sysdeps/alpha/dl-procinfo.h | 2 -- > sysdeps/csky/dl-procinfo.h | 2 -- > sysdeps/generic/dl-procinfo.h | 2 -- > sysdeps/mips/dl-procinfo.h | 2 -- > sysdeps/powerpc/dl-procinfo.h | 10 ---------- > sysdeps/s390/dl-procinfo.h | 14 -------------- > sysdeps/sparc/dl-procinfo.h | 13 ------------- > sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h | 12 ------------ > sysdeps/unix/sysv/linux/arm/dl-procinfo.h | 12 ------------ > sysdeps/x86/dl-hwcap.h | 14 -------------- > 10 files changed, 83 deletions(-) > > diff --git a/sysdeps/alpha/dl-procinfo.h b/sysdeps/alpha/dl-procinfo.h > index 31630fbb..6a12297d 100644 > --- a/sysdeps/alpha/dl-procinfo.h > +++ b/sysdeps/alpha/dl-procinfo.h > @@ -54,6 +54,4 @@ _dl_string_platform (const char *str) > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > -#define _dl_string_hwcap(str) (-1) > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/csky/dl-procinfo.h b/sysdeps/csky/dl-procinfo.h > index d29e19a9..5da90087 100644 > --- a/sysdeps/csky/dl-procinfo.h > +++ b/sysdeps/csky/dl-procinfo.h > @@ -54,6 +54,4 @@ _dl_string_platform (const char *str) > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > -#define _dl_string_hwcap(str) (-1) > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/generic/dl-procinfo.h b/sysdeps/generic/dl-procinfo.h > index 8f736e1d..033bcb3e 100644 > --- a/sysdeps/generic/dl-procinfo.h > +++ b/sysdeps/generic/dl-procinfo.h > @@ -34,8 +34,6 @@ > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > -#define _dl_string_hwcap(str) (-1) > - > #define _dl_string_platform(str) (-1) > > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/mips/dl-procinfo.h b/sysdeps/mips/dl-procinfo.h > index 619dc089..25127c36 100644 > --- a/sysdeps/mips/dl-procinfo.h > +++ b/sysdeps/mips/dl-procinfo.h > @@ -54,6 +54,4 @@ _dl_string_platform (const char *str) > /* We don't have any hardware capabilities. */ > #define _DL_HWCAP_COUNT 0 > > -#define _dl_string_hwcap(str) (-1) > - > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/powerpc/dl-procinfo.h b/sysdeps/powerpc/dl-procinfo.h > index 6ed15610..a0b2d779 100644 > --- a/sysdeps/powerpc/dl-procinfo.h > +++ b/sysdeps/powerpc/dl-procinfo.h > @@ -69,16 +69,6 @@ _dl_hwcap_string (int idx) > return GLRO(dl_powerpc_cap_flags)[idx]; > } > > -static inline int > -__attribute__ ((unused)) > -_dl_string_hwcap (const char *str) > -{ > - for (int i = 0; i < _DL_HWCAP_COUNT; ++i) > - if (strcmp (str, _dl_hwcap_string (i)) == 0) > - return i; > - return -1; > -} > - > static inline int > __attribute__ ((unused, always_inline)) > _dl_string_platform (const char *str) > diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h > index e1f88b9a..73aad1fd 100644 > --- a/sysdeps/s390/dl-procinfo.h > +++ b/sysdeps/s390/dl-procinfo.h > @@ -83,20 +83,6 @@ _dl_hwcap_string (int idx) > return _dl_s390_cap_flags[idx]; > }; > > -static inline int > -__attribute__ ((unused, always_inline)) > -_dl_string_hwcap (const char *str) > -{ > - int i; > - > - for (i = 0; i < _DL_HWCAP_COUNT; i++) > - { > - if (strcmp (str, _dl_s390_cap_flags[i]) == 0) > - return i; > - } > - return -1; > -}; > - > static inline int > __attribute__ ((unused, always_inline)) > _dl_string_platform (const char *str) > diff --git a/sysdeps/sparc/dl-procinfo.h b/sysdeps/sparc/dl-procinfo.h > index 4a723b53..fa095832 100644 > --- a/sysdeps/sparc/dl-procinfo.h > +++ b/sysdeps/sparc/dl-procinfo.h > @@ -52,19 +52,6 @@ _dl_hwcap_string (int idx) > return GLRO(dl_sparc_cap_flags)[idx]; > }; > > -static inline int > -__attribute__ ((unused, always_inline)) > -_dl_string_hwcap (const char *str) > -{ > - int i; > - for (i = 0; i < _DL_HWCAP_COUNT; i++) > - { > - if (strcmp (str, GLRO(dl_sparc_cap_flags) [i]) == 0) > - return i; > - } > - return -1; > -}; > - > #include > #define HWCAP_IMPORTANT_V9 (__WORDSIZE == 64 ? 0 : HWCAP_SPARC_V9) > #define HWCAP_IMPORTANT (HWCAP_IMPORTANT_V9 | HWCAP_SPARC_ULTRA3 \ > diff --git a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > index aa505223..f7382f63 100644 > --- a/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h > @@ -37,18 +37,6 @@ _dl_hwcap_string (int idx) > return (unsigned)idx < _DL_HWCAP_COUNT ? GLRO(dl_aarch64_cap_flags)[idx] : ""; > }; > > -static inline int > -__attribute__ ((unused)) > -_dl_string_hwcap (const char *str) > -{ > - for (int i = 0; i < _DL_HWCAP_COUNT; i++) > - { > - if (strcmp (str, _dl_hwcap_string (i)) == 0) > - return i; > - } > - return -1; > -}; > - > /* There're no platforms to filter out. */ > #define _DL_HWCAP_PLATFORM 0 > > diff --git a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > index 1f4c8c3a..d8c0f262 100644 > --- a/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > +++ b/sysdeps/unix/sysv/linux/arm/dl-procinfo.h > @@ -75,18 +75,6 @@ _dl_procinfo (unsigned int type, unsigned long int word) > > #define HWCAP_IMPORTANT (HWCAP_ARM_VFP | HWCAP_ARM_NEON) > > -static inline int > -__attribute__ ((unused)) > -_dl_string_hwcap (const char *str) > -{ > - for (int i = 0; i < _DL_HWCAP_COUNT; i++) > - { > - if (strcmp (str, _dl_hwcap_string (i)) == 0) > - return i; > - } > - return -1; > -}; > - > #define _dl_string_platform(str) (-1) > > #endif /* dl-procinfo.h */ > diff --git a/sysdeps/x86/dl-hwcap.h b/sysdeps/x86/dl-hwcap.h > index 26790afc..1313cecd 100644 > --- a/sysdeps/x86/dl-hwcap.h > +++ b/sysdeps/x86/dl-hwcap.h > @@ -57,20 +57,6 @@ _dl_hwcap_string (int idx) > return GLRO(dl_x86_hwcap_flags)[idx]; > }; > > -static inline int > -__attribute__ ((unused, always_inline)) > -_dl_string_hwcap (const char *str) > -{ > - int i; > - > - for (i = HWCAP_START; i < HWCAP_COUNT; i++) > - { > - if (strcmp (str, GLRO(dl_x86_hwcap_flags)[i]) == 0) > - return i; > - } > - return -1; > -}; > - > /* We cannot provide a general printing function. */ > #define _dl_procinfo(type, word) -1 >