From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by sourceware.org (Postfix) with ESMTPS id B20323858C56 for ; Mon, 1 Apr 2024 01:41:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B20323858C56 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=huawei.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B20323858C56 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=45.249.212.191 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711935676; cv=none; b=raGJMEYidCR1TwVLUTNJp+rBvIu3WHY833L6528h0jYKP2y/i/Nm/5nezzajfA7nL9YeMIbiH97qd6UDjdtKCVIocDKxpdkPqBtwybhnKrdocvp+DJRzyOzdBkL+Y5eJ1f5hZwo2KTPKI4Q3IQXi23S/dBfk/voTBeicJenVclk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711935676; c=relaxed/simple; bh=rOOr2Zk3h+cglMtyW1AbXz7rczNyjejLgEHrm0L+DHw=; h=Subject:To:From:Message-ID:Date:MIME-Version; b=Cp+UBElEWiYDjO/7CVppDxBSK6+bH5L7Pq6p1DMeKhWGNyUFSsZbe75KP7clrdQ8uDsf9U6qkA7xtb/Wh+y5MJjZKakajd0pD21icNugYIpRYPYW70eeEjKD0SApT9aKdtYscYvGCyeRqMiJew6tniMOtJAFqeeqrgx5AoLeuYU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4V7DGz3n0Fz1GDr3; Mon, 1 Apr 2024 09:40:27 +0800 (CST) Received: from canpemm500010.china.huawei.com (unknown [7.192.105.118]) by mail.maildlp.com (Postfix) with ESMTPS id 6CB241A0172; Mon, 1 Apr 2024 09:41:03 +0800 (CST) Received: from [10.67.111.82] (10.67.111.82) by canpemm500010.china.huawei.com (7.192.105.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 1 Apr 2024 09:41:03 +0800 Subject: Re: [PATCH] elf: handle NULL input to fatal_error To: Andreas Schwab References: <1711806052-117857-1-git-send-email-xiaojiangfeng@huawei.com> <874jcnhgb6.fsf@igel.home> CC: , , , , From: Jiangfeng Xiao Message-ID: Date: Mon, 1 Apr 2024 09:40:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <874jcnhgb6.fsf@igel.home> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.82] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500010.china.huawei.com (7.192.105.118) X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024/3/30 23:47, Andreas Schwab wrote: > _dl_signal_error used to set objname to "" if it is null, it should > continue to do so (this has been removed in commit 2449ae7b2d). It > still sanitizes errstring, so nothing needs to be done about that. > Thank you very much, it sounds good to me. I'm going to submit a patch to sanitize objname in _dl_signal_error, just like early code.