public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Florian Weimer <fweimer@redhat.com>
Cc: Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v4 1/3] Add support for locales with zero collation rules.
Date: Thu, 29 Jul 2021 12:12:55 -0700	[thread overview]
Message-ID: <f387325a-b423-e56a-fe9c-3e456060193f@cs.ucla.edu> (raw)
In-Reply-To: <8735rx4fpn.fsf@oldenburg.str.redhat.com>

On 7/29/21 2:44 AM, Florian Weimer via Libc-alpha wrote:
> Looks like ~((uint32_t) 0) needs to be added as a macro/constant to
> __collseq_table_lookup.

A small point: UINT32_MAX would be simpler and cleaner definiens for 
that macro, as UINT32_MAX can be used in #if and is more portable to 
potential future platforms where int is wider than 32 bits.

  reply	other threads:[~2021-07-29 19:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  6:35 [PATCH v4 0/3] C.UTF-8 Carlos O'Donell
2021-07-29  6:35 ` [PATCH v4 1/3] Add support for locales with zero collation rules Carlos O'Donell
2021-07-29  9:44   ` Florian Weimer
2021-07-29 19:12     ` Paul Eggert [this message]
2021-07-29  6:35 ` [PATCH v4 2/3] Add 'strcmp_collation' support for LC_COLLATE Carlos O'Donell
2021-07-29  6:35 ` [PATCH v4 3/3] Add generic C.UTF-8 locale (Bug 17318) Carlos O'Donell
2021-07-29  7:53 ` [PATCH v4 0/3] C.UTF-8 Florian Weimer
2021-07-30  3:12   ` Carlos O'Donell
2021-08-18  8:12   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f387325a-b423-e56a-fe9c-3e456060193f@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).