From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf43.google.com (mail-qv1-xf43.google.com [IPv6:2607:f8b0:4864:20::f43]) by sourceware.org (Postfix) with ESMTPS id 0FAA23861038 for ; Wed, 8 Jul 2020 12:23:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0FAA23861038 Received: by mail-qv1-xf43.google.com with SMTP id m9so20352614qvx.5 for ; Wed, 08 Jul 2020 05:23:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Z+OKupHpN/Fnbrp2P4mdQCWFPYfv/vyu7VgvSnKD40Y=; b=YtolQXXQ+nxnBF50o/f+fxWnj1G5/0aEhaG67DayG4vEXtmgdBZ36IYRkCrnn8/KFr iBuJi2NFXzzNhg7QMXC7smMkBaYiM+pyZYun7SJu2viMCCNsPBepnjVA7Ufd50sBvJeM Pf3X1CwHlxYkhWB8xH55Hb9VfRT5NbthTTsSZo1WsaKC2ikGKLHA5M/UoAL1VrObH6cN zjJBg8HGm2Uz1D2lTccLg9gbHrIiROJxqs5WtVzu6cebuCV98Iis1mLCXbpidtuUwtAi sifWoTkfm5jch119wN88VbQYhLzITmgtakAkHqF4zK3lpow/7IGyiz6vuzAaeolC5+Ef BU2Q== X-Gm-Message-State: AOAM532AFPqX8vmDfU6tmlPT2IlRHvcq5ttukji/2ylUwEwuLA6l3zDe 85dlfbhuZFE2FGHYLjvGeziDWq7G5Gw= X-Google-Smtp-Source: ABdhPJzPosaJUmXPMZtEOVfEumUvXXIvVfC217Z/HpQ57GUTGYaRr+rYNx34PUFWtRifciUP2a9Glw== X-Received: by 2002:ad4:4672:: with SMTP id z18mr58359116qvv.104.1594211014399; Wed, 08 Jul 2020 05:23:34 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id n28sm31740652qtf.8.2020.07.08.05.23.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2020 05:23:33 -0700 (PDT) Subject: Re: [PATCH v5 12/13] string: Add sigabbrev_np and sigdescr_np To: Tamar Christina , Florian Weimer Cc: Carlos O'Donell , "libc-alpha@sourceware.org" References: <20200619134352.297146-1-adhemerval.zanella@linaro.org> <20200619134352.297146-12-adhemerval.zanella@linaro.org> <05744028-6434-5c9f-7498-12965f0b793c@redhat.com> <87sge2tezr.fsf@oldenburg2.str.redhat.com> <87k0zetea7.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Wed, 8 Jul 2020 09:23:31 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2020 12:23:36 -0000 Thanks for catching it, the oldest gcc I tested it was 7.5. On 08/07/2020 09:16, Tamar Christina wrote: > Hi Florian, > > Yup, that patch works. > > Thanks! > Tamar > >> -----Original Message----- >> From: Florian Weimer >> Sent: Wednesday, July 8, 2020 12:52 PM >> To: Tamar Christina >> Cc: Adhemerval Zanella ; Carlos O'Donell >> ; libc-alpha@sourceware.org >> Subject: Re: [PATCH v5 12/13] string: Add sigabbrev_np and sigdescr_np >> >> * Tamar Christina: >> >>>> What's your GCC version? I don't see this when building with a GCC >>>> 10 cross- compiler. >>> >>> It seems to be GCC 6.3 from a native Debian docker image >>> >>> 0e188cdeda88 ~# gcc --version >>> ... >>> gcc version 6.3.0 20170516 (Debian 6.3.0-18+deb9u1) ... >>> >>> 0e188cdeda88 ~# lsb_release -a >>> No LSB modules are available. >>> Distributor ID: Debian >>> Description: Debian GNU/Linux 9.12 (stretch) >>> Release: 9.12 >>> Codename: stretch >> >> I see. Looks like GCC 6 does not discard the const on the return type, >> although it has no effect in C: >> >> const char *const >> sigabbrev_np (int signum) >> { >> … >> >> Does this patch fixes things for you? >> >> diff --git a/string/sigabbrev_np.c b/string/sigabbrev_np.c index >> 3cbe14e769..a5ac6da053 100644 >> --- a/string/sigabbrev_np.c >> +++ b/string/sigabbrev_np.c >> @@ -20,7 +20,7 @@ >> #include >> #include >> >> -const char *const >> +const char * >> sigabbrev_np (int signum) >> { >> const char *abbrev = NULL; >> diff --git a/string/sigdescr_np.c b/string/sigdescr_np.c index >> 5bcf814c1d..bf2d462b9c 100644 >> --- a/string/sigdescr_np.c >> +++ b/string/sigdescr_np.c >> @@ -20,7 +20,7 @@ >> #include >> #include >> >> -const char *const >> +const char * >> __sigdescr_np (int signum) >> { >> const char *descr = NULL; >> >> >> Thanks, >> Florian >