From: Carlos O'Donell <carlos@redhat.com>
To: Tom Honermann <tom@honermann.net>,
Andreas Schwab <schwab@suse.de>,
libc-alpha <libc-alpha@sourceware.org>,
Rafal Luzynski <digitalfreak@lingonborough.com>
Subject: Re: [PATCH v2] Reset converter state after second wchar_t output (Bug 25734)
Date: Wed, 15 Apr 2020 23:10:23 -0400 [thread overview]
Message-ID: <f4858453-d696-74bd-b4f0-a8f6d15490e7@redhat.com> (raw)
In-Reply-To: <59e55e76-b85d-acd1-c016-1bf1a44d79ed@honermann.net>
On 4/15/20 11:08 PM, Tom Honermann wrote:
> On 4/15/20 10:41 PM, Carlos O'Donell wrote:
>> On 4/14/20 3:56 PM, Carlos O'Donell wrote:
>>> On 4/14/20 3:03 PM, Tom Honermann wrote:
>>>> On 4/4/20 2:41 PM, Carlos O'Donell via Libc-alpha wrote:
>>>>> v2 - Add test dependency on locale. - Make test use generic
>>>>> converter dependency (builds all converters) - Move Rules
>>>>> inclusion to after locale generation to match localedata/
>>>>> order.
>>>>>
>>>>> No regressions on x86_64 and i686.
>>>>>
>>>>> I'll push this next week unless someone objects.
>>>> Hi, Carlos. Do you have an update on pushing this?
>>>>
>>>> I sent a patch [1] for bug 25744 that depends on your changes.
>>>> Do you have any concerns to share with that patch? If not,
>>>> could you please commit it along with your changes for bug
>>>> 25734?
>>>>
>>>> Tom.
>>>>
>>>> [1]:
>>>> https://sourceware.org/pipermail/libc-alpha/2020-April/112595.html
>>>
>>>>
I'm retesting this again today on 64-bit and 32-bit and will push shortly.
>>>
>>> Thanks for the ping. Sorry for the delay.
>> All clean. Pushed v2.
>>
> Thanks, Carlos. I see the patch
> <https://sourceware.org/pipermail/libc-alpha/2020-April/112595.html>
> [1] I submitted for bug 25744 wasn't included. Do you have some
> concerns with that patch? If not, could you please commit it as
> well?
I have to review your patch, and get consensus on that. The converter
hang is an obvious fix (bug 25734), but I haven't had a chance to fully
review your change. Next is to review your change and see if we can
finally smooth out the bugs in the converter for these cases.
Thank you for your patience!
--
Cheers,
Carlos.
next prev parent reply other threads:[~2020-04-16 3:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 21:18 [PATCH] " Carlos O'Donell
2020-03-28 20:37 ` Carlos O'Donell
2020-03-28 20:51 ` Florian Weimer
2020-03-28 23:42 ` Carlos O'Donell
2020-03-30 17:40 ` Tom Honermann
2020-04-01 17:34 ` Tom Honermann
2020-04-04 18:41 ` [PATCH v2] " Carlos O'Donell
2020-04-07 4:20 ` Tom Honermann
2020-04-14 19:03 ` Tom Honermann
2020-04-14 19:56 ` Carlos O'Donell
2020-04-16 2:41 ` Carlos O'Donell
2020-04-16 3:08 ` Tom Honermann
2020-04-16 3:10 ` Carlos O'Donell [this message]
2020-03-30 12:11 ` [PATCH] " Andreas Schwab
2020-03-30 14:19 ` Florian Weimer
2020-03-30 14:28 ` Andreas Schwab
2020-03-30 14:32 ` Florian Weimer
2020-03-30 14:36 ` Carlos O'Donell
2020-03-30 15:28 ` Andreas Schwab
2020-03-30 17:52 ` Carlos O'Donell
2020-03-30 14:34 ` Carlos O'Donell
2020-03-30 17:36 ` Tom Honermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4858453-d696-74bd-b4f0-a8f6d15490e7@redhat.com \
--to=carlos@redhat.com \
--cc=digitalfreak@lingonborough.com \
--cc=libc-alpha@sourceware.org \
--cc=schwab@suse.de \
--cc=tom@honermann.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).