From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127448 invoked by alias); 24 Nov 2016 21:24:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 127418 invoked by uid 89); 24 Nov 2016 21:24:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=spell, shortly X-HELO: mail-vk0-f51.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=og+7RI1Z/dFDIMUEmmJzmKWLBSi28lVqT3ph1/XkWuw=; b=eQv55HOYUIbKveI046TfTYRCdDovjFuONrSHrKRTA/VokmQ2yE0IgyObIXAQleVG+o SXZclfypm8udyAQAF7Pld645Th3dItzvadpHsF1UE6fD8pZ4AB07L81mou7+ntTXsMri 15DnGJHLAjk7jPOKHB+IkUi3Y+RIjA1MDaomuBXjkrJxNN0ayDgsn4GCtLwidXOpAxxY zEd3F83KQfUx7IgjHeMKWt1RVkRamvkZPdcKuuFLzBCApTUVM8lAeh/uG/zCpB6PRhAz 2f/OV7E/sugX+5aNuGQMSk1rNR8Ya5d/laOHUmSiScGXXBr+xL3BIbDx9/o5/F+WDQPW 7ywQ== X-Gm-Message-State: AKaTC02R7/UjIT3yWD7e62JV3f61XRAoECb+36Nc00YwGF3Wp3HOYD814e1ixCUQskMoy/53 X-Received: by 10.31.74.65 with SMTP id x62mr1487940vka.146.1480022645093; Thu, 24 Nov 2016 13:24:05 -0800 (PST) Subject: Re: [PATCH] Remove cached PID/TID in clone To: Florian Weimer , libc-alpha@sourceware.org References: <1476387924-4509-1-git-send-email-adhemerval.zanella@linaro.org> <58c8bc8e-e643-2d3a-5e57-55a3457ca70f@redhat.com> <6d415988-fb13-5f58-70fc-8b7d3d5ccfde@redhat.com> From: Adhemerval Zanella Message-ID: Date: Thu, 24 Nov 2016 21:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <6d415988-fb13-5f58-70fc-8b7d3d5ccfde@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00906.txt.bz2 On 15/11/2016 12:29, Florian Weimer wrote: > On 11/15/2016 03:26 PM, Adhemerval Zanella wrote: >> On 09/11/2016 10:18, Florian Weimer wrote: >>> >>> I really think we should document the clone system call wrapper and spell out these requirements, but that's a separate matter. >>> >> >> Right, I think we can update documentation after patch is upstream. > > Agreed. > >> I also did a full check on aarch64, powerpc64le, and armhf. I also did >> some basic tests (basically the posix and nptl one involving clone/fork) >> on a simulated sparc{64} and mips{64} machine to check if I missed >> something in clone/vfork assembly changes. > > I'm happy with the patch as-is. I'd suggest to wait another week to see if the architecture maintainers have further comments and if not, check it in. I has been about a week and no architecture maintainer chimed in. I will commit it shortly. As before, I rebased and I ran a full make check on x86_64, x32, i686, armhf, aarch64, and powerpc64le. I also checked some basic tests on sparc{32,64} and mips{32,64} on a simulated system. So it would require further testing on alpha, hppa, ia64, m68k, nios2, s390, sh, and tile (I excluded microblaze because it is already implementing the patch semantic regarding clone/vfork).