From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 86BE8386EC23 for ; Sun, 11 Apr 2021 19:30:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 86BE8386EC23 Received: by mail-wr1-x42b.google.com with SMTP id a6so10723065wrw.8 for ; Sun, 11 Apr 2021 12:30:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=slkxDl8IRxKF3zuF883SVhwtrEr/ovRH2Iuxng4IIVU=; b=KqePIBBAUJ/RHRkl5mLJIfE5sViIeG4rMlKSUyhVc3q4ySkImBxPdVgfhsLBJ3jxMB 3kD646X3RJ30tcVEW+CmxuQdX9il3L2jPipgkM8wKx033JzJTfUJqpJBLlkW0x/Wk4ax 2yB/c03OXb2q95HrXW8rz/m3cNmklrMG+ctZYOAnUImWj2mYa20pj9EK3MjvJctdLcQB vBDY1h4Jg5lD0oKQXpk1dyCNijJDiNOwwKgmRoH5cx4dvSiIqGkl4ovXFUXRa2f0IEHH K8dukWNm0r1ARcePdXWmUp2dtWW+aLXnm04G/DXsrfLnrBDmoe4r+w2AO6Dh/7Ud9neK 9YmQ== X-Gm-Message-State: AOAM531UzDSFI5NZcaufZSYbVbGfZzKeh0wcghIVTEX9PWSw2vg48gWf xtEokWM1oWOUtqsPKizDV73157sg4rg= X-Google-Smtp-Source: ABdhPJx9aoeutPsullidSrPwkIhomp4KDeOK4Zy5vF4SHwxFRAxkTHAwQmawGMgdrfLqLymGs8U59w== X-Received: by 2002:a5d:4f82:: with SMTP id d2mr1301287wru.228.1618169403102; Sun, 11 Apr 2021 12:30:03 -0700 (PDT) Received: from [192.168.1.143] ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id e11sm2783127wrt.41.2021.04.11.12.30.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Apr 2021 12:30:02 -0700 (PDT) Subject: Re: [PATCH v5 00/35] SYNOPSIS: Use syscall(SYS_...); and fix '#include's From: "Alejandro Colomar (man-pages)" To: "Michael Kerrisk (man-pages)" Cc: linux-man@vger.kernel.org, libc-alpha@sourceware.org References: <20210403194026.102818-1-alx.manpages@gmail.com> <20210404115847.78166-1-alx.manpages@gmail.com> <4298cc3c-8f24-5a3c-3c54-b24ca804d373@gmail.com> <7750fa83-c252-7a60-bddc-34fb7ebed0bf@gmail.com> Message-ID: Date: Sun, 11 Apr 2021 21:30:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <7750fa83-c252-7a60-bddc-34fb7ebed0bf@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2021 19:30:11 -0000 On 4/11/21 9:23 PM, Alejandro Colomar (man-pages) wrote: > Hi Michael, > > On 4/5/21 1:49 PM, Michael Kerrisk (man-pages) wrote: >> So, I think I'm okay with the syscall() changes in the SYNOPSIS. >> It might just take me a moment to get used to them. However, I do >> wonder if it is worth retaining a comment in the SYSNOPSIS, >> something like: >> >>     SYNOPSIS >>         #include         /* Definition of ARCH_* >> constants */ >>         #include       /* Definition of SYS_* constants */ >>         #include >> >>         int syscall(SYS_arch_prctl, int code, unsigned long addr); >>         int syscall(SYS_arch_prctl, int code, unsigned long *addr); >> >>         Note: glibc provides no wrapper for arch_prctl(), necessitating >>         the use of syscall(2). I'm not sure what text to write in cases such as faccessat2(2). Could you have a look at that? There's actually a wrapper, but it's faccessat(2). >> >> Without something like this, the reader may be puzzled at the use of >> syscall(). >> >> What do you think? > > Yes.  I had doubts, and you confirmed them.  I'll add that. > Thanks, Alex -- Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/