From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Alejandro Colomar <alx.manpages@gmail.com>, libc-alpha@sourceware.org
Cc: Alejandro Colomar <alx@kernel.org>
Subject: Re: [PATCH] Use __nonnull for the epoll_wait(2) family of syscalls
Date: Tue, 23 May 2023 09:27:52 -0300 [thread overview]
Message-ID: <f4ac5b66-3f75-0321-1d73-4f8fc9618972@linaro.org> (raw)
In-Reply-To: <20230522220120.37208-1-alx@kernel.org>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
On 22/05/23 19:01, Alejandro Colomar wrote:
> Signed-off-by: Alejandro Colomar <alx@kernel.org>
> ---
> include/sys/epoll.h | 3 ++-
> sysdeps/unix/sysv/linux/sys/epoll.h | 8 ++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/include/sys/epoll.h b/include/sys/epoll.h
> index 8049381a26..b23bc9c7c0 100644
> --- a/include/sys/epoll.h
> +++ b/include/sys/epoll.h
> @@ -9,7 +9,8 @@ libc_hidden_proto (epoll_pwait)
> #else
> extern int __epoll_pwait2_time64 (int fd, struct epoll_event *ev, int maxev,
> const struct __timespec64 *tmo,
> - const sigset_t *s);
> + const sigset_t *s)
> + __nonnull ((2));
> libc_hidden_proto (__epoll_pwait2_time64)
> #endif
>
> diff --git a/sysdeps/unix/sysv/linux/sys/epoll.h b/sysdeps/unix/sysv/linux/sys/epoll.h
> index b17d344e79..23872c9438 100644
> --- a/sysdeps/unix/sysv/linux/sys/epoll.h
> +++ b/sysdeps/unix/sysv/linux/sys/epoll.h
> @@ -123,7 +123,7 @@ extern int epoll_ctl (int __epfd, int __op, int __fd,
> __THROW. */
> extern int epoll_wait (int __epfd, struct epoll_event *__events,
> int __maxevents, int __timeout)
> - __attr_access ((__write_only__, 2, 3));
> + __attr_access ((__write_only__, 2, 3)) __nonnull ((2));
>
>
> /* Same as epoll_wait, but the thread's signal mask is temporarily
> @@ -134,7 +134,7 @@ extern int epoll_wait (int __epfd, struct epoll_event *__events,
> extern int epoll_pwait (int __epfd, struct epoll_event *__events,
> int __maxevents, int __timeout,
> const __sigset_t *__ss)
> - __attr_access ((__write_only__, 2, 3));
> + __attr_access ((__write_only__, 2, 3)) __nonnull ((2));
>
> /* Same as epoll_pwait, but the timeout as a timespec.
>
> @@ -144,7 +144,7 @@ extern int epoll_pwait (int __epfd, struct epoll_event *__events,
> extern int epoll_pwait2 (int __epfd, struct epoll_event *__events,
> int __maxevents, const struct timespec *__timeout,
> const __sigset_t *__ss)
> - __attr_access ((__write_only__, 2, 3));
> + __attr_access ((__write_only__, 2, 3)) __nonnull ((2));
> #else
> # ifdef __REDIRECT
> extern int __REDIRECT (epoll_pwait2, (int __epfd, struct epoll_event *__ev,
> @@ -152,7 +152,7 @@ extern int __REDIRECT (epoll_pwait2, (int __epfd, struct epoll_event *__ev,
> const struct timespec *__timeout,
> const __sigset_t *__ss),
> __epoll_pwait2_time64)
> - __attr_access ((__write_only__, 2, 3));
> + __attr_access ((__write_only__, 2, 3)) __nonnull ((2));
> # else
> # define epoll_pwait2 __epoll_pwait2_time64
> # endif
next prev parent reply other threads:[~2023-05-23 12:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 22:50 nonnull on epoll_wait(2) syscall wrappers? Alejandro Colomar
2023-05-22 20:51 ` Adhemerval Zanella Netto
2023-05-22 22:01 ` [PATCH] Use __nonnull for the epoll_wait(2) family of syscalls Alejandro Colomar
2023-05-23 12:27 ` Adhemerval Zanella Netto [this message]
2023-05-29 17:39 ` Adhemerval Zanella Netto
2023-05-29 23:17 ` Alejandro Colomar
2023-05-30 11:41 ` Adhemerval Zanella Netto
2023-05-31 20:44 ` [PATCH v2 1/2] Fix invalid use of NULL in epoll_pwait2(2) test Alejandro Colomar
2023-06-01 17:59 ` Adhemerval Zanella Netto
2023-05-31 20:44 ` [PATCH v2 2/2] Use __nonnull for the epoll_wait(2) family of syscalls Alejandro Colomar
2023-06-01 18:00 ` Adhemerval Zanella Netto
2023-06-01 23:46 ` Alejandro Colomar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ac5b66-3f75-0321-1d73-4f8fc9618972@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=alx.manpages@gmail.com \
--cc=alx@kernel.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).