From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by sourceware.org (Postfix) with ESMTPS id C691F385842D for ; Tue, 23 May 2023 12:29:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C691F385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-195ee1be418so5661182fac.2 for ; Tue, 23 May 2023 05:29:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684844951; x=1687436951; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=61925H/IoWr2+1mhyM0uJt/Y2bNeiuctw4AQhxKHRCE=; b=v1kxTljgDk7XOkhN4CtH0okiyEjbZZTdudLQOpk+/cjwkAgFliS4xw9LMsvzJLRNyT SjnwGN+FcufQvw2ryVHGgP8Py1+5MYRS6wgOkCf+DYVVhpKAr/J7yOtVMFuATMZEVVb9 Shzlp86s7OZ7SR9jTpxHwgN83o0FemujYeZ7TWRnplfNmur1d3SUtubSOCJnMtpBJ4rd 9RRD6cFDj7yZoVToj8EssxHqBjxjE/bjYHzEwOmvCgPynD7lyU2LMejqPx3i5wU4lXhn N4tB3ZsUt4Daz/dcBpDDq75I9Ibld2sfhsiVn+mNjhIBwetA0fsHzYx5IRKog63+Y0Hy r/Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684844951; x=1687436951; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=61925H/IoWr2+1mhyM0uJt/Y2bNeiuctw4AQhxKHRCE=; b=jg68gJNXTVOA36C/Kv/c57JP8oqyEK2jKB1a6o/jQqPQ0T+5iosmUHQwLkl4d0dW1R vPbpjnrmrzHKIFfyB89Guops1IoNcnnBY21eHjFFubf0+G5qecU6vnTQQgpUyKo3Or9y NuNH7tpjVqKMZvYh2urpFrMT/gulzpU901iJOsrsand54kUoMyViO8o3+nwcTZTXQyPv XoFk0VfKlspuG6wwz1TRpzI7p6o7pLp2ssBlNWm8fjPE+jen/m1xES/nCftRLczxghRX nbhyGBDl1+g2MvAlpQNOpII9nGeuR2ovROT3PLkq95LpObGVZcsTBfbvAd0GQOEDYW4/ eQQg== X-Gm-Message-State: AC+VfDyOqM/y93CQ9Bb7hybsphXJ9eO04k/YDVcIlyLAR7X3NupseFs4 poIyLxNCBlAXuNnnx5MBUxiEuQ== X-Google-Smtp-Source: ACHHUZ4DZKOMYAApoBMOdP8Jp8drs+/xl+aX6iXoBMI4vmA6Mg4rfyLEGoiCMQiqk8tr6DEo0l8gmw== X-Received: by 2002:a05:6870:702a:b0:187:dbb8:f5fc with SMTP id u42-20020a056870702a00b00187dbb8f5fcmr8835912oae.35.1684844951152; Tue, 23 May 2023 05:29:11 -0700 (PDT) Received: from [192.168.15.31] (200-232-172-197.dsl.telesp.net.br. [200.232.172.197]) by smtp.gmail.com with ESMTPSA id v24-20020a0568301bd800b006af87f3c6b8sm1209745ota.29.2023.05.23.05.29.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 05:29:10 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 09:27:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Use __nonnull for the epoll_wait(2) family of syscalls Content-Language: en-US To: Alejandro Colomar , libc-alpha@sourceware.org Cc: Alejandro Colomar References: <6c399f6b-6e89-17c4-2a56-1219a1b86448@linaro.org> <20230522220120.37208-1-alx@kernel.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230522220120.37208-1-alx@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: LGTM, thanks. Reviewed-by: Adhemerval Zanella On 22/05/23 19:01, Alejandro Colomar wrote: > Signed-off-by: Alejandro Colomar > --- > include/sys/epoll.h | 3 ++- > sysdeps/unix/sysv/linux/sys/epoll.h | 8 ++++---- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/include/sys/epoll.h b/include/sys/epoll.h > index 8049381a26..b23bc9c7c0 100644 > --- a/include/sys/epoll.h > +++ b/include/sys/epoll.h > @@ -9,7 +9,8 @@ libc_hidden_proto (epoll_pwait) > #else > extern int __epoll_pwait2_time64 (int fd, struct epoll_event *ev, int maxev, > const struct __timespec64 *tmo, > - const sigset_t *s); > + const sigset_t *s) > + __nonnull ((2)); > libc_hidden_proto (__epoll_pwait2_time64) > #endif > > diff --git a/sysdeps/unix/sysv/linux/sys/epoll.h b/sysdeps/unix/sysv/linux/sys/epoll.h > index b17d344e79..23872c9438 100644 > --- a/sysdeps/unix/sysv/linux/sys/epoll.h > +++ b/sysdeps/unix/sysv/linux/sys/epoll.h > @@ -123,7 +123,7 @@ extern int epoll_ctl (int __epfd, int __op, int __fd, > __THROW. */ > extern int epoll_wait (int __epfd, struct epoll_event *__events, > int __maxevents, int __timeout) > - __attr_access ((__write_only__, 2, 3)); > + __attr_access ((__write_only__, 2, 3)) __nonnull ((2)); > > > /* Same as epoll_wait, but the thread's signal mask is temporarily > @@ -134,7 +134,7 @@ extern int epoll_wait (int __epfd, struct epoll_event *__events, > extern int epoll_pwait (int __epfd, struct epoll_event *__events, > int __maxevents, int __timeout, > const __sigset_t *__ss) > - __attr_access ((__write_only__, 2, 3)); > + __attr_access ((__write_only__, 2, 3)) __nonnull ((2)); > > /* Same as epoll_pwait, but the timeout as a timespec. > > @@ -144,7 +144,7 @@ extern int epoll_pwait (int __epfd, struct epoll_event *__events, > extern int epoll_pwait2 (int __epfd, struct epoll_event *__events, > int __maxevents, const struct timespec *__timeout, > const __sigset_t *__ss) > - __attr_access ((__write_only__, 2, 3)); > + __attr_access ((__write_only__, 2, 3)) __nonnull ((2)); > #else > # ifdef __REDIRECT > extern int __REDIRECT (epoll_pwait2, (int __epfd, struct epoll_event *__ev, > @@ -152,7 +152,7 @@ extern int __REDIRECT (epoll_pwait2, (int __epfd, struct epoll_event *__ev, > const struct timespec *__timeout, > const __sigset_t *__ss), > __epoll_pwait2_time64) > - __attr_access ((__write_only__, 2, 3)); > + __attr_access ((__write_only__, 2, 3)) __nonnull ((2)); > # else > # define epoll_pwait2 __epoll_pwait2_time64 > # endif