From: "Paul E. Murphy" <murphyp@linux.vnet.ibm.com>
To: Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>,
libc-alpha@sourceware.org
Cc: munroesj@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc: Add a POWER8-optimized version of expf()
Date: Fri, 24 Jun 2016 22:54:00 -0000 [thread overview]
Message-ID: <f4acab4b-b7b2-21d0-4676-f3320089c715@linux.vnet.ibm.com> (raw)
In-Reply-To: <1466715228-29670-1-git-send-email-tuliom@linux.vnet.ibm.com>
On 06/23/2016 03:53 PM, Tulio Magno Quites Machado Filho wrote:
> +#ifndef __ieee754_expf
> +# define IS_MAIN_DEF
> +#endif
> +#ifdef IS_MAIN_DEF
> +strong_alias (__ieee754_expf, __expf_finite)
> +#endif
>
This is inconsistent with many of the other ppc64
multiarch files.
Why not undef and redefine strong_alias in
e_expf-power8.S?
Similarly, the formatting seems inconsistent with
the other PPC asm.
next prev parent reply other threads:[~2016-06-24 22:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 20:54 Tulio Magno Quites Machado Filho
2016-06-24 22:54 ` Paul E. Murphy [this message]
2016-06-27 13:33 ` Tulio Magno Quites Machado Filho
2016-06-27 14:11 ` Paul E. Murphy
2016-06-27 19:03 ` [PATCH V2] " Tulio Magno Quites Machado Filho
2016-06-28 22:08 ` Paul E. Murphy
2016-06-30 19:20 ` Tulio Magno Quites Machado Filho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4acab4b-b7b2-21d0-4676-f3320089c715@linux.vnet.ibm.com \
--to=murphyp@linux.vnet.ibm.com \
--cc=libc-alpha@sourceware.org \
--cc=munroesj@linux.vnet.ibm.com \
--cc=tuliom@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).