From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 672C73858D33 for ; Wed, 22 Feb 2023 21:33:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 672C73858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677101628; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BVcD0JJHWhWjOuZGh1o5osCV8nQihCs6Y6/J66Wccns=; b=ISIc6+c4WP6bPRldtQ1URACTUEmdSyJlXDVWWtY3oyuOgTHbuZS1Hct++blLUhr/Lsbj6g egPxzAOeAdeL10ExGomp7J23L8m1EnP82ixIWcELYAzLHbZyJMw5BhCmQcThGS8u/bmAm5 WPHSkZXr+q+eitHEPymWEZzPl3YDynM= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-296-mSwtUGbGOjSKRPZKdHZTQg-1; Wed, 22 Feb 2023 16:33:45 -0500 X-MC-Unique: mSwtUGbGOjSKRPZKdHZTQg-1 Received: by mail-il1-f199.google.com with SMTP id h12-20020a92c08c000000b00316f82f1d98so912579ile.7 for ; Wed, 22 Feb 2023 13:33:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BVcD0JJHWhWjOuZGh1o5osCV8nQihCs6Y6/J66Wccns=; b=PQOtc9SP5IBsuJoRwWzQ+NGB1FitzMMtJjHxUeH/tN6aV/BVwzrJZoJ1wvAyxXEHF7 Aglho/shlNLcsxTHjugYYB0FbOOhFRuCQ3AFrYp8rs5Z/Xni0nvefWWW+2ojwzvRpsC9 TlYcjCEwDvE1AWEVIBbeM9qttQTQbOZ/2WdG5gZOYeffN6vYvxnBkrdx1lvxK80gNfMV a0bZ7e9hiGhPukUad3ItenQl0tj9ggK4dh0I3MEz7YRg02SMopzIKWpXzSMfNFVMdQyn xv0d9k+lVCWQ9EoVrLGvOYJZpq2AyDuV5bleMLAuBDRtb4psp+HPWJs3Y6IgmGOGJyY9 lQ8w== X-Gm-Message-State: AO0yUKXxyMMzDuUq0SLTrnrBlKkrtIZ9k+EeRfWyOESpgGSOFuInm0bF 2B603di6BDaP5aDxE2Ekjy2RNcpRr+69UYE3YOeP7twDTs55bp7BHwdmNBI0eulO1DS5BJv+Fj9 hIqPumS/+0ZbCxnCKRToPUzjuxQ== X-Received: by 2002:a05:6e02:219b:b0:316:e54a:82a3 with SMTP id j27-20020a056e02219b00b00316e54a82a3mr5052232ila.30.1677101623751; Wed, 22 Feb 2023 13:33:43 -0800 (PST) X-Google-Smtp-Source: AK7set9jfHeubi1OSdSlAZeZDksleJf0TdWOmVebBWJJWG1E7ecghNxyo0OlRDnQJODVapUDn6gK/Q== X-Received: by 2002:a05:6e02:219b:b0:316:e54a:82a3 with SMTP id j27-20020a056e02219b00b00316e54a82a3mr5052221ila.30.1677101623529; Wed, 22 Feb 2023 13:33:43 -0800 (PST) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id l7-20020a92d8c7000000b0031595ea003asm2011539ilo.85.2023.02.22.13.33.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 13:33:43 -0800 (PST) Message-ID: Date: Wed, 22 Feb 2023 16:33:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: Ignore MAP_VARIABLE in tst-mman-consts.py To: Joseph Myers , libc-alpha@sourceware.org References: <8b3784bd-fdfb-bc98-9b9b-49e1c11482b@codesourcery.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <8b3784bd-fdfb-bc98-9b9b-49e1c11482b@codesourcery.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/22/23 12:56, Joseph Myers wrote: > Linux 6.2 removed the hppa compatibility MAP_VARIABLE define. That > means that, whether or not we remove it in glibc, it needs to be > ignored in tst-mman-consts.py (since this macro comparison > infrastructure expects that new kernel header versions only add new > macros, not remove old ones). > > Tested with build-many-glibcs.py for hppa-linux-gnu (Linux 6.2 > headers). Confirmed that with 71bdea6f798b425bc0003780b13e3fdecb16a010 the MAP_VARIABLE define to 0 is removed. LGTM. Reviewed-by: Carlos O'Donell > diff --git a/sysdeps/unix/sysv/linux/tst-mman-consts.py b/sysdeps/unix/sysv/linux/tst-mman-consts.py > index 0bba893064..92b78a877c 100644 > --- a/sysdeps/unix/sysv/linux/tst-mman-consts.py > +++ b/sysdeps/unix/sysv/linux/tst-mman-consts.py > @@ -47,9 +47,12 @@ def main(): > # MAP_ANON alias for MAP_ANONYMOUS. MAP_RENAME, MAP_AUTOGROW, > # MAP_LOCAL and MAP_AUTORSRV are in the kernel header for > # MIPS, marked as "not used by linux"; SPARC has MAP_INHERIT > - # in the kernel header, but does not use it. > + # in the kernel header, but does not use it. The kernel > + # header for HPPA removed a define of MAP_VARIABLE to 0 in > + # Linux 6.2. > 'MAP_HUGE_[0-9].*|MAP_UNINITIALIZED|MAP_FAILED|MAP_ANON' > - '|MAP_RENAME|MAP_AUTOGROW|MAP_LOCAL|MAP_AUTORSRV|MAP_INHERIT', > + '|MAP_RENAME|MAP_AUTOGROW|MAP_LOCAL|MAP_AUTORSRV|MAP_INHERIT' > + '|MAP_VARIABLE', > linux_version_glibc > linux_version_headers, > linux_version_headers > linux_version_glibc)) > > -- Cheers, Carlos.