From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id B9CC53851C33 for ; Mon, 7 Dec 2020 16:39:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B9CC53851C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id A2156362528; Mon, 7 Dec 2020 16:39:47 +0000 (UTC) Received: from pdx1-sub0-mail-a90.g.dreamhost.com (100-96-8-104.trex.outbound.svc.cluster.local [100.96.8.104]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B589C361DC3; Mon, 7 Dec 2020 16:39:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a90.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.18.11); Mon, 07 Dec 2020 16:39:47 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Relation-Print: 556c001e20cc857a_1607359187012_3310928610 X-MC-Loop-Signature: 1607359187012:1442088738 X-MC-Ingress-Time: 1607359187012 Received: from pdx1-sub0-mail-a90.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a90.g.dreamhost.com (Postfix) with ESMTP id 15C147E670; Mon, 7 Dec 2020 08:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=McD16z kV2V2OWKifD1X+GXqARsg=; b=lEYgIIaKBprvwrpZPUskdSlXFLF4Vlb9/XbdbR 5HkeTq7m7PvVwTefwMLE56KDObUY34tC7w0w1jhp5Cc2omJ4HnnLHBAtnFmtKyix e3DHJ7Pv9aE4viW9TAnBmbSgWpJFUJza20LEycsrPu+vkVMX4PlFstbVubjJFf5i eVu+A= Received: from [192.168.1.111] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a90.g.dreamhost.com (Postfix) with ESMTPSA id AEE277E0AA; Mon, 7 Dec 2020 08:39:44 -0800 (PST) Subject: Re: [RFC] Updating patchwork patches on commit To: DJ Delorie Cc: libc-alpha@sourceware.org References: X-DH-BACKEND: pdx1-sub0-mail-a90 From: Siddhesh Poyarekar Message-ID: Date: Mon, 7 Dec 2020 22:09:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Dec 2020 16:39:53 -0000 On 12/7/20 9:45 PM, DJ Delorie wrote: > Siddhesh Poyarekar writes: >> This means that diffs of 14 patches were modified before committing. > > Do you try removing the Reviewed-by tags and re-hashing? My last step > before committing is usually to add those according to the reviews, so > my patches might never match patchwork. > Well your NSS patches did match and auto-close; in fact the v4 of 3/6 in that patchset also got closed as Committed because diff-wise it was identical to v5 3/6 :) Patchwork stores the diff separately and the hash is generated only on the diff using the patchwork hasher in patchwork/hasher.py. So changing the commit message in any way does not change the hash. Siddhesh