From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2D7CC3858428 for ; Mon, 11 Jul 2022 14:47:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2D7CC3858428 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-TverZrr_PIW1JHvSMAUEkQ-1; Mon, 11 Jul 2022 10:47:34 -0400 X-MC-Unique: TverZrr_PIW1JHvSMAUEkQ-1 Received: by mail-qk1-f197.google.com with SMTP id l189-20020a37bbc6000000b006af2596c5e8so5519797qkf.14 for ; Mon, 11 Jul 2022 07:47:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=6cu7I5BAF0MVhbiBoH/1yhUz3cGV/V38D9AXF1JkC4g=; b=01nl9o+9DqTOhYS1+/zeJTaZB7fn2KrYxUGGKnzo6jGHg7Pmr0pKDHZ9BuvfRk6HEV 2NunuC0SrPSJq6GnUQtPv5L5p5hY5riuSlk3r6VPY8ezpxoQ9ycWBDGlasy+8kuSQfFE AeeO3DHGrZU1Zw4h3REdZOJDYMRP+DWbzVoVDAhOb+xNXgy9FLOgzyB7zy60VPbOpPZ3 1rHrVqQhk0rs9qrZDh1wUvSDUH4jCJAOLmXRaeWyGgcAlaZjR+/ze9LI3rildNm6AQ85 CwGzerMx7o24CVu516Dz+ixx7nlxjJUqg7rc50uJJK8T9QfZz1uHRew8Trqx9ldFFt3H nauA== X-Gm-Message-State: AJIora8ali2TyzI7uNVsnScn6JnOMz3/GjRmXvwYg8NUsbDbm/tMwuGD vdeVMhh1pQ1EDPOARCvop/q7FxdIk6+DZfu1oz7XCTCJdQ/7DtUxzwTC/Z8JocCVyWaElveJcgU uc9wK8bWRTPwjAsdRcnQR X-Received: by 2002:a05:6214:2389:b0:473:17a8:102 with SMTP id fw9-20020a056214238900b0047317a80102mr13589020qvb.40.1657550853421; Mon, 11 Jul 2022 07:47:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uwcsEw5CukLGDEymi63sf4xTHwRzHdTf4k3P69hjlqAaJ7tx/0EviMlp/azftpbZUG29xLyQ== X-Received: by 2002:a05:6214:2389:b0:473:17a8:102 with SMTP id fw9-20020a056214238900b0047317a80102mr13589002qvb.40.1657550853164; Mon, 11 Jul 2022 07:47:33 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id w18-20020a05620a445200b0069c72b41b59sm6447440qkp.2.2022.07.11.07.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 07:47:32 -0700 (PDT) Message-ID: Date: Mon, 11 Jul 2022 10:47:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v7 1/5] linux: Add fsconfig To: Fangrui Song Cc: Adhemerval Zanella , libc-alpha@sourceware.org References: <20220624195919.435424-1-adhemerval.zanella@linaro.org> <20220624195919.435424-2-adhemerval.zanella@linaro.org> <20220711081624.ws7lhii2baq7efoe@google.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20220711081624.ws7lhii2baq7efoe@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, BODY_8BITS, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 14:47:37 -0000 On 7/11/22 04:16, Fangrui Song wrote: > On 2022-07-04, Carlos O'Donell via Libc-alpha wrote: >> On 6/24/22 15:59, Adhemerval Zanella wrote: >>> It was added on Linux 5.2 (ecdab150fddb42fe6a739335257949220033b782) >>> as a way to a configure filesystem creation context and trigger >>> actions upon it, to be used in conjunction with fsopen, fspick and >>> fsmount. >>> >>> The fsconfig_command commands are currently only defined as an enum, >>> so they can't be checked on tst-mount-consts.py with current test >>> support. >> >> LGTM. API uses const void * correctly and syscall wrapper signature matches. >> >> Reviewed-by: Carlos O'Donell > > https://sourceware.org/glibc/wiki/Synchronizing_Headers can be updated that > >     #include >     #include > > no longer works. This led to a compiler-rt build failure which I am > going to fix in https://reviews.llvm.org/D129471 (llvm-project 15.0 will be branched soon > https://discourse.llvm.org/t/llvm-15-0-0-release-schedule/63495) > > Note: > >     #include >     #include > > doesn't work for a long time > >     /usr/include/x86_64-linux-gnu/sys/mount.h:35:3: error: expected identifier before numeric constant >        35 |   MS_RDONLY = 1,                /* Mount read-only.  */ >           |   ^~~~~~~~~ > I added the known conflict to the wiki. Thanks. -- Cheers, Carlos.