From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 6F5FF3845188 for ; Mon, 31 Oct 2022 16:08:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F5FF3845188 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x231.google.com with SMTP id t62so2428404oib.12 for ; Mon, 31 Oct 2022 09:08:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YqZJfcMAJUmk2oQSx14hp3PKDdKQJL1NwH+HlYAcQXA=; b=Wdsc3WRIYvJ/TeHg8INqK7HKl4l/eMlDd4bYvA52TZLnjVNIXZ7drb2njoh8GbToHg syNYj5Pfh4ab8tvR1pznX/v6884Ihz6fYz/Ma9oqDnct907KG6sF4gpcSTFNGxvxDSNc t3jgRBJ1Q5DQZ8I7XNhZSWrtIFbj/jge9iFGLJ+wZoJc/3uzeAed7uv0Nvq2tHPbYqh8 yQuA7Lmee+z3qSoQxa5atMMRSmk3IHpqFYPXVuVsMSTGNXR5Uply/n+wBhn6IgFIl1OM nMXXiIyvLd0PvpicNA6uAWQi2kA5kxs+f+15liBhZE30yWBM73LjbgMUvEUlkXHCw8hA d1uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YqZJfcMAJUmk2oQSx14hp3PKDdKQJL1NwH+HlYAcQXA=; b=QHIxniOTg1IpD6URpO8F0ofGCa0P+VLGYs66pC3my2hvSj8qEgPOMxjPffaQhVN1UU ft4jZRsX5qqX1yPae7cEk8z9FAKcl9tDFvdbJZmMm16oHkFVj/YpkXABk2dEkshBNeLB BjncBKLmrCLGdnHfqqdUw+ToMiohutNK9URrT8B2/t++5ah5DQ0FCUf0k4qpmPUoe9Ug WBpVYg9JAKfks9hkwGaqOY/8go8CWl7GAVJVXMrpe7RkdcjA448ZKy2+Rs9fo8OwTqXp MPJcc4sZDuNpjREkutRNcHz0MZ4BqqZELc/rEY8VQ/LzCPQKhLnVVZ+8h5BYxBnE/DNq iVjA== X-Gm-Message-State: ACrzQf1X6GTJ2KnON5qlrMIJkBrs539bS9+nvJAthAVS/OtjAQYAFDnE UrI0qGRZ+TGQ+16yIzN+CmOAZA== X-Google-Smtp-Source: AMsMyM6TPX74sLHK5ZNqUH5Dge7wB1dZeed+XZLPoiGiBbOOIi9BphI2Eybes/Y62OfRoLGzjjeNgw== X-Received: by 2002:a05:6808:23c8:b0:354:c993:88b5 with SMTP id bq8-20020a05680823c800b00354c99388b5mr6984780oib.227.1667232534648; Mon, 31 Oct 2022 09:08:54 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1? ([2804:1b3:a7c0:17c8:29c8:c66:a795:b2b1]) by smtp.gmail.com with ESMTPSA id y15-20020a544d8f000000b00354d9b9f6b4sm2428256oix.27.2022.10.31.09.08.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Oct 2022 09:08:54 -0700 (PDT) Message-ID: Date: Mon, 31 Oct 2022 13:08:52 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 07/20] Use uintptr_t in fts for pointer alignment Content-Language: en-US To: Szabolcs Nagy , libc-alpha@sourceware.org References: <5703dc6417979ab222d19f31e9d363c7bc415e96.1666877952.git.szabolcs.nagy@arm.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <5703dc6417979ab222d19f31e9d363c7bc415e96.1666877952.git.szabolcs.nagy@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/10/22 12:32, Szabolcs Nagy via Libc-alpha wrote: > The code assumed unsigned long can represent pointers. LGTM, thanks. Reviewed-by: Adhemerval Zanella > --- > io/fts.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/io/fts.c b/io/fts.c > index 283cf1791a..5a0a47a360 100644 > --- a/io/fts.c > +++ b/io/fts.c > @@ -55,6 +55,7 @@ static char sccsid[] = "@(#)fts.c 8.6 (Berkeley) 8/14/94"; > #include > #include > #include > +#include > #include > #include > #include > @@ -67,7 +68,7 @@ static char sccsid[] = "@(#)fts.c 8.6 (Berkeley) 8/14/94"; > #endif > /* Align P to that size. */ > #ifndef ALIGN > -#define ALIGN(p) (((unsigned long int) (p) + ALIGNBYTES) & ~ALIGNBYTES) > +#define ALIGN(p) (((uintptr_t) (p) + ALIGNBYTES) & ~ALIGNBYTES) > #endif > >