From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51713 invoked by alias); 4 Nov 2019 20:11:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 51703 invoked by uid 89); 4 Nov 2019 20:11:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=correspondence X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 02/30] ldbl-128ibm-compat: Add wide character printing functions To: "Gabriel F. T. Gomes" Cc: libc-alpha@sourceware.org References: <20191025153410.15405-1-gabriel@inconstante.net.br> <20191025153410.15405-3-gabriel@inconstante.net.br> <6cd56f3e-847f-f1bc-7ae4-f30d58bfdd0a@linux.ibm.com> <20191104151041.69c50b4c@tereshkova> From: Paul E Murphy Message-ID: Date: Mon, 04 Nov 2019 20:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191104151041.69c50b4c@tereshkova> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-11/txt/msg00091.txt.bz2 On 11/4/19 12:10 PM, Gabriel F. T. Gomes wrote: > Hi, Paul, > > On Mon, 04 Nov 2019, Paul E Murphy wrote: >> >> Is it prohibitively difficult to merge the wide character tester with >> the one in the previous patch? Otherwise, this looks OK too. > > It's not difficult... In fact, that's how I started it, but it ended up > being too hard to read (imo, anyway), because of the excessive use of > macros and because of the not so nice correspondence between function > names. > > I suppose you're suggesting it so that we have less code duplication. > I can make the merge... It's just not how I would do it. I can agree with this line of reasoning. I think the tradeoff made by these patches is OK. I don't think these tests will see much change once merged.