From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id BF79B3858D32 for ; Mon, 8 May 2023 14:01:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BF79B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683554473; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rxCaCkBmft3djr7QDh8RxPDfVuwU0eDWVSHrKdjTDts=; b=gHRKuvsnnZnRwbJsB2e281POs7EVtwVGfelNprwOdwPOa0cG8KYYhUXR4VGQX5Vn8fODFT lZm86As6Z56fopZvhLT9Bg20sHsTIIj/ggVHgMG/buN8BpBrIkgicV5C8mt/MZkLHoWNsO HVkvaE4EK4vH+/PNprun8ZbyvI0NDG4= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-jgOMOTiBN5-ck1_CPUiWxg-1; Mon, 08 May 2023 10:01:11 -0400 X-MC-Unique: jgOMOTiBN5-ck1_CPUiWxg-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7577c8f57f8so194505085a.0 for ; Mon, 08 May 2023 07:01:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683554470; x=1686146470; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rxCaCkBmft3djr7QDh8RxPDfVuwU0eDWVSHrKdjTDts=; b=f23ixcNfGK4dP00C5v63mZxM/W6pgxQWdXzkezKBbxZcAy0YWKCot1VgwHi/KQCbQl WEj7vfzEox7SLJi0k5ZjmRi3fs65Mdf6lLc1SEhWK2nahtPHEpApuqK5ABrmQ/N+HVYt 5dI2owmxiCqZDn7tPC2oDk8WaULFW2chY71bYTNJZFt41H+wiC+999LuCbC+CX85NEUv /ibDq8WUZ98949VyVxxaZxRhDiA/WrXW+TceWmSJgddxDVQbYXGro3s9ONqI3ZVLtrnc jqQR6dAHXxRnKZFeIZCpKtrEdPCB6iDkevPospg3L5zGDsRtY/FQuCcSXHroLiUoTel0 HsWw== X-Gm-Message-State: AC+VfDzuS/DqPiycj0XILWplMAhHtAyfiDLOrfgLxYNSXdb/hyj2vxgC M4KNrw+syrSJRqIR6mMZjogbgER4C/Syq+lowhz08jzJnU1MgLvkC1Cqrgu75BtxLJ1PuDWgBk6 D2ZFE9vcvoit6wblXMh2w0A6V5q0n X-Received: by 2002:a05:6214:c46:b0:61a:175c:6ca7 with SMTP id r6-20020a0562140c4600b0061a175c6ca7mr14344439qvj.39.1683554470292; Mon, 08 May 2023 07:01:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54GAcL38vU83e81b9euR6NWgsdXXr0VfgiVeEfR+tREnCFrhc0ZuIwArLET4b5onaWmZlIrg== X-Received: by 2002:a05:6214:c46:b0:61a:175c:6ca7 with SMTP id r6-20020a0562140c4600b0061a175c6ca7mr14344376qvj.39.1683554469864; Mon, 08 May 2023 07:01:09 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id z14-20020a25bb0e000000b00b96a0d1a0a7sm2305992ybg.11.2023.05.08.07.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 07:01:09 -0700 (PDT) Message-ID: Date: Mon, 8 May 2023 10:01:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2] testsuite: stdlib/isomac.c: fix REQUIREMENTS To: =?UTF-8?B?0L3QsNCx?= Cc: libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/4/23 16:25, наб via Libc-alpha wrote: > All of the mentioned variables are gone. gcc is just the default and > argv[1] can be used instead. /usr/include isn't hard-coded and you can > pass argv[2] with -I... to adjust. LGTM. Thank you! Pushed. Reviewed-by: Carlos O'Donell > > Signed-off-by: Ahelenia Ziemiańska > --- > v2: no-change resend after clean rebase > > stdlib/isomac.c | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/stdlib/isomac.c b/stdlib/isomac.c > index 3a6009d988..a371bb2593 100644 > --- a/stdlib/isomac.c > +++ b/stdlib/isomac.c > @@ -45,14 +45,11 @@ > compiler compiles some other language than Standard C. > > REQUIREMENTS: > - This program calls gcc to get the list of defined macros. If you > + This program calls ${1-gcc} to get the list of defined macros. If you OK. > don't have gcc you're probably out of luck unless your compiler or > - preprocessor has something similar to gcc's -dM option. Tune > - PRINT_MACROS in this case. This program assumes headers are found > - under /usr/include and that there is a writable /tmp directory. > - Tune SYSTEM_INCLUDE if your system differs. > - #define BROKEN_SYSTEM if system(NULL) bombs -- one more violation > - of ISO C, by the way. > + preprocessor has something similar to gcc's -dM option. This program > + assumes headers are found in the default search path (pass -I... in > + $2 if this is not the case) and that there is a writable /tmp directory. OK. > > OUTPUT: > Each header file name is printed, followed by illegal macro names -- Cheers, Carlos.